From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6005C433B4 for ; Mon, 19 Apr 2021 15:14:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 637766113C for ; Mon, 19 Apr 2021 15:14:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 637766113C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BCED16B006C; Mon, 19 Apr 2021 11:14:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B80006B006E; Mon, 19 Apr 2021 11:14:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F79B6B0070; Mon, 19 Apr 2021 11:14:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 7CB596B006C for ; Mon, 19 Apr 2021 11:14:26 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 261503489 for ; Mon, 19 Apr 2021 15:14:26 +0000 (UTC) X-FDA: 78049462932.24.1C0D676 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf17.hostedemail.com (Postfix) with ESMTP id DF5ED40002C8 for ; Mon, 19 Apr 2021 15:14:22 +0000 (UTC) Received: by mail-qv1-f43.google.com with SMTP id bs7so16536038qvb.12 for ; Mon, 19 Apr 2021 08:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=55uomXciVSZ6J6HOTB32O4AbktADuhgCDGYMDuRmQxE=; b=RQhB8OjlxbRDagS7zeb7sF3QHZwiZdGpXuuxJSsZOxySpSixsl4FqbgevMPiEdfs5V SRiDYvj2aok3lt+Kb0CaDE3nO0nzdifSCwV5jMfBFJKlVGGw/SPYIp+lJPWdQxVl560T KwQRD7NBYrflCIbsLoFGLGlPICDLLjfLaQ0HYUmIZjCRldM6OI4HbuVdhXzoKRxCpaUo u5u7RbH0I2icI19RuUvEqPq/Xhey6DWAxZzyBlCCemoLeo2zwVbfv8HkjRR7iyIZ652x +zYC+YI6muSdaB8L13xdzgdASaPEkae7oXWHP5rleWZLqiD8bRo2JZNvQKm2o4u1CmOa FsgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=55uomXciVSZ6J6HOTB32O4AbktADuhgCDGYMDuRmQxE=; b=in+4UfKpm/vxZF0h+AU9wfG235YUR0D9jl2VsOrt3fLPw/S0TWOrrOgJ/aDv7m6Egl Gq7DCq3CnFNauQrSSVLDrEZ6JzJ5lUXeuTAElIEGiB/8MdJNViPIxqV2tlr6FUYGgPQy O/Ej0wEPvY63pfuXosUTPe+xV1bdeO5B3igLhE+zPBcENTu/TM4z80f4iwD/++oDLBU7 1oqeGXuGxVrD2k5xDrhp0tUc7TRr/w7IWpeW6mhpOfXdadUFsf5PdT0tc4mZXAvdejdm Vgf9zzTXjMzqV5Ypn6Nnkp0YNBe9vC2GlusZ73veY/ij9tVnN0lYsjRr6hUOxNF/EY2E 04ag== X-Gm-Message-State: AOAM5308D1i/BTUtkrmOHdIkjIk3TK9tK2fL7Vgtuv+m71ZH6xEcs7Z4 PICrVZK50UbbQz5wCU8Wu2uxUA== X-Google-Smtp-Source: ABdhPJxpsSV7l37HtQTRT1SxTkkytlcWsNYVRzMS2JBB0kroc1KQt8l+9N1P/5oyTmVh5BwQvaqBrA== X-Received: by 2002:a0c:e24e:: with SMTP id x14mr22422271qvl.33.1618845264783; Mon, 19 Apr 2021 08:14:24 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id o25sm5681249qtl.37.2021.04.19.08.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 08:14:23 -0700 (PDT) Date: Mon, 19 Apr 2021 11:14:23 -0400 From: Johannes Weiner To: Waiman Long Cc: Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun , Matthew Wilcox Subject: Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c Message-ID: References: <20210419000032.5432-1-longman@redhat.com> <20210419000032.5432-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210419000032.5432-2-longman@redhat.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DF5ED40002C8 X-Stat-Signature: wogboyu4bqjmsdy7ofbk4qh7zbcsofex Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mail-qv1-f43.google.com; client-ip=209.85.219.43 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618845262-751808 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 18, 2021 at 08:00:28PM -0400, Waiman Long wrote: > The mod_objcg_state() function is moved from mm/slab.h to mm/memcontrol.c > so that further optimization can be done to it in later patches without > exposing unnecessary details to other mm components. > > Signed-off-by: Waiman Long > --- > mm/memcontrol.c | 13 +++++++++++++ > mm/slab.h | 16 ++-------------- > 2 files changed, 15 insertions(+), 14 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e064ac0d850a..dc9032f28f2e 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3150,6 +3150,19 @@ void __memcg_kmem_uncharge_page(struct page *page, int order) > css_put(&memcg->css); > } > > +void mod_objcg_state(struct obj_cgroup *objcg, struct pglist_data *pgdat, > + enum node_stat_item idx, int nr) > +{ > + struct mem_cgroup *memcg; > + struct lruvec *lruvec = NULL; > + > + rcu_read_lock(); > + memcg = obj_cgroup_memcg(objcg); > + lruvec = mem_cgroup_lruvec(memcg, pgdat); > + mod_memcg_lruvec_state(lruvec, idx, nr); > + rcu_read_unlock(); > +} It would be more naturally placed next to the others, e.g. below __mod_lruvec_kmem_state(). But no deal breaker if there isn't another revision. Acked-by: Johannes Weiner