From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC9EFC433DB for ; Thu, 25 Mar 2021 13:21:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A708E61A11 for ; Thu, 25 Mar 2021 13:21:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A708E61A11 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 31FF56B006C; Thu, 25 Mar 2021 09:21:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CF686B0070; Thu, 25 Mar 2021 09:21:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 172F96B0071; Thu, 25 Mar 2021 09:21:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id EB71A6B006C for ; Thu, 25 Mar 2021 09:21:23 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AADE8DDFA for ; Thu, 25 Mar 2021 13:21:23 +0000 (UTC) X-FDA: 77958458046.33.74780AF Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf03.hostedemail.com (Postfix) with ESMTP id 1638CC0007E3 for ; Thu, 25 Mar 2021 13:21:21 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B723DAC16; Thu, 25 Mar 2021 13:21:21 +0000 (UTC) Date: Thu, 25 Mar 2021 14:21:19 +0100 From: Oscar Salvador To: Wang Wensheng Cc: akpm@linux-foundation.org, pasha.tatashin@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rui.xiang@huawei.com Subject: Re: [PATCH] mm/sparse: Add the missing sparse_buffer_fini() in error branch Message-ID: References: <20210325113155.118574-1-wangwensheng4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325113155.118574-1-wangwensheng4@huawei.com> X-Stat-Signature: 79b9ct9scbsiurfxsqx9d8uxws8w89o4 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1638CC0007E3 Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1616678481-454943 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 25, 2021 at 11:31:55AM +0000, Wang Wensheng wrote: > sparse_buffer_init() and sparse_buffer_fini() should appear in pair, or > a WARN issue would be through the next time sparse_buffer_init() runs. > > Add the missing sparse_buffer_fini() in error branch. > > Fixes: 85c77f791390 ("mm/sparse: add new sparse_init_nid() and sparse_init()") > Signed-off-by: Wang Wensheng Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3