From: Oscar Salvador <osalvador@suse.de>
To: Wang Wensheng <wangwensheng4@huawei.com>
Cc: akpm@linux-foundation.org, pasha.tatashin@oracle.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rui.xiang@huawei.com
Subject: Re: [PATCH] mm/sparse: Add the missing sparse_buffer_fini() in error branch
Date: Thu, 25 Mar 2021 14:21:19 +0100 [thread overview]
Message-ID: <YFyOT/1j95uON6/9@localhost.localdomain> (raw)
In-Reply-To: <20210325113155.118574-1-wangwensheng4@huawei.com>
On Thu, Mar 25, 2021 at 11:31:55AM +0000, Wang Wensheng wrote:
> sparse_buffer_init() and sparse_buffer_fini() should appear in pair, or
> a WARN issue would be through the next time sparse_buffer_init() runs.
>
> Add the missing sparse_buffer_fini() in error branch.
>
> Fixes: 85c77f791390 ("mm/sparse: add new sparse_init_nid() and sparse_init()")
> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-03-25 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 11:31 Wang Wensheng
2021-03-25 12:45 ` David Hildenbrand
2021-03-25 13:21 ` Oscar Salvador [this message]
2021-03-26 2:23 Wang Wensheng
2021-03-26 9:11 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFyOT/1j95uON6/9@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@oracle.com \
--cc=rui.xiang@huawei.com \
--cc=wangwensheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox