From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5410FC433DB for ; Thu, 25 Mar 2021 16:07:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DA1C4619C9 for ; Thu, 25 Mar 2021 16:07:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA1C4619C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5249B6B0036; Thu, 25 Mar 2021 12:07:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FB186B0071; Thu, 25 Mar 2021 12:07:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C3616B0072; Thu, 25 Mar 2021 12:07:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 24C516B0036 for ; Thu, 25 Mar 2021 12:07:12 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DC57E8BAF846 for ; Thu, 25 Mar 2021 16:07:11 +0000 (UTC) X-FDA: 77958875862.19.DF92FF9 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf01.hostedemail.com (Postfix) with ESMTP id 1604B500152D for ; Thu, 25 Mar 2021 16:07:05 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616688424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7ofJ/SzRjNvBQCBUiomtR9gZ1AM18bk0f0SRyUhB5O0=; b=J1nkte6qbWXyQdsFzjlnnxqk6EmfvOa9lLcEYfxvqiNLe3GJ/PJO7Vi+fsl8qF5e+VXRfN 1Cd3xBI244n3QpZ1Ccc6d35dLsfwb+lrYDCPYrmagrfz9plh+tsRKj480Ih0zy0Z0v2BDi PZV40Ptlvnjt1u3uxqu1rBM+Ru99ULY= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CD600AA55; Thu, 25 Mar 2021 16:07:04 +0000 (UTC) Date: Thu, 25 Mar 2021 17:07:03 +0100 From: Michal Hocko To: David Hildenbrand Cc: Oscar Salvador , Andrew Morton , Anshuman Khandual , Vlastimil Babka , Pavel Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/5] mm,memory_hotplug: Allocate memmap from the added memory range Message-ID: References: <31110e58-c99a-8dee-6f6e-98f456b77759@redhat.com> <062bc5d7-a83c-1c1a-7b77-9f043643f4fa@redhat.com> <31c3e6f7-f631-7b00-2c33-518b0f24a75f@redhat.com> <40fac999-2d28-9205-23f0-516fa9342bbe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1604B500152D X-Stat-Signature: kjbb19bb76z67rwwn7a17zskzzj5pqji Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616688425-3470 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 25-03-21 16:35:58, Michal Hocko wrote: [...] > So there is indeed a difference. One way around that would be to mark > vmemmap pages (e.g. PageReserved && magic value stored somewhere in the > struct page - resembling bootmem vmemmaps) or mark section fully backing > vmemmaps as online (ugly). I am not yet ready to give up on this. Here is a quick stab at the pfn_to_online_page approach. It is not great but it is not really terrible either. I think we can do better and skip find_memory_block_by_id in most cases because nr_vmemmap_pages should be constant with our current implementation. diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 754026a9164d..0d2bc22c29d3 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -304,8 +304,20 @@ struct page *pfn_to_online_page(unsigned long pfn) return NULL; ms = __nr_to_section(nr); - if (!online_section(ms)) + if (!online_section(ms)) { + if (memmap_on_memory) { + struct memory_block *mem; + unsigned long section_pfn = section_nr_to_pfn(nr); + + mem = find_memory_block_by_id(memory_block_id(nr)); + if (!mem || !mem->nr_vmemmap_pages || pfn - section_pfn > mem->nr_vmemmap_pages) + return NULL; + + return pfn_to_page(pfn); + + } return NULL; + } /* * Save some code text when online_section() + -- Michal Hocko SUSE Labs