From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE79FC433C1 for ; Wed, 24 Mar 2021 03:31:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3BFB861962 for ; Wed, 24 Mar 2021 03:31:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BFB861962 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CA5ED6B029A; Tue, 23 Mar 2021 23:31:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2ED96B029F; Tue, 23 Mar 2021 23:31:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA8376B02A0; Tue, 23 Mar 2021 23:31:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id 8AC926B029A for ; Tue, 23 Mar 2021 23:31:36 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 468018134 for ; Wed, 24 Mar 2021 03:31:36 +0000 (UTC) X-FDA: 77953342992.27.04D3E58 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf24.hostedemail.com (Postfix) with ESMTP id 6501DA0009DC for ; Wed, 24 Mar 2021 03:31:34 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id l1so13701824pgb.5 for ; Tue, 23 Mar 2021 20:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=j9te7omEbpKZ/N4rlb8wG4FVpFTLsGLsOoHiGZQa/MQ=; b=vA5er0UpZRPIE11eaIlIxYJor2VwhaBGCYr32FNWFPKbvFjNaEM9t7yzW5jrDyT9C4 yZv7GGnhzIAx7XnfwalWMgqfeC7lCdMUuPbEdtP2PW4Nd4pP4jjJkCts0hE9A6ctt0tY qq0iS4S5DGINTxLrsaqQypVEnqcbTbDnr/UBjDDVosozQvUEvl4CkJAmQ2Dm2ZMZehT8 h7bHj8GbwY/ytrJJ3DyUnTEtR5GU1KNURGVPP70bDIXWcudWhgmfFCoqFRysV11rwJC1 k64u0LlfiuacrdGSV+jDVhSLJ/m05dkbwpdjJBRjAB2xWESNH2omF+dE72v1DcwUpgDH dmlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=j9te7omEbpKZ/N4rlb8wG4FVpFTLsGLsOoHiGZQa/MQ=; b=pfCILiO8QGkpEM/mGwP/V2j41Cq8soygZmt3vCxPdVsuRogIxt48a9IFZafXoeYf5D m+rp9AAybrZc2dQP6gHc7sMosqkqwrUSW8KQ+BpD6Uy/aaCAnm6sjuowmWXWWiH1Xykb yXLwC8zQNdtfOwIraBHzIwANNVaXcJ6eJzLHCiKyv9RDQ0CNUgWnnrgVaqVfRhMMB+6t qO4YK8t1aa4wnMwGP53FDGLNhUqTPUQgXJ8cZgS5kjJ3fC8Go/DZ0VD4LnFinsZMQalQ Ka5CTerFcRrINWSwuPFCnYOqT1YDZS9Yln0/Ee6xcFMZKqmacTix7CCI6Pu5nGakl+81 1AmQ== X-Gm-Message-State: AOAM532f7Fxcu7NzuvrXF39Z9cHnYKqI9+i4CrTyWPBYV/KeRGhbwimO cSZGU9HLsvgZlh33+fgfcJA= X-Google-Smtp-Source: ABdhPJxMn7EGa6KEQcrL6Cy9awi9U1hljgaVowP+kN5H7zJTo4qA5jMFFERacDq6VlECDstvXx3t9Q== X-Received: by 2002:a62:7b83:0:b029:1f1:5ef3:b4d9 with SMTP id w125-20020a627b830000b02901f15ef3b4d9mr1274163pfc.65.1616556694767; Tue, 23 Mar 2021 20:31:34 -0700 (PDT) Received: from google.com ([2620:15c:211:201:7dfa:1e53:536:7976]) by smtp.gmail.com with ESMTPSA id 143sm571513pfx.144.2021.03.23.20.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 20:31:33 -0700 (PDT) Date: Tue, 23 Mar 2021 20:31:31 -0700 From: Minchan Kim To: Matthew Wilcox Cc: Andrew Morton , linux-mm , LKML , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, jhubbard@nvidia.com, digetx@gmail.com Subject: Re: [PATCH v5] mm: cma: support sysfs Message-ID: References: <20210323195050.2577017-1-minchan@kernel.org> <20210324030224.GO1719932@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324030224.GO1719932@casper.infradead.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6501DA0009DC X-Stat-Signature: ncwt3gtdatmz713cyn4eb8h9u9wdw33j Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-pg1-f175.google.com; client-ip=209.85.215.175 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616556694-927727 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 24, 2021 at 03:02:24AM +0000, Matthew Wilcox wrote: > On Tue, Mar 23, 2021 at 12:50:50PM -0700, Minchan Kim wrote: > > + /* the number of CMA page successful allocations */ > > + atomic64_t nr_pages_succeeded; > > > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count) > > +{ > > + atomic64_add(count, &cma->nr_pages_succeeded); > > +} > > I don't understand. A size_t is a byte count. But the variable is called > 'nr_pages'. So which is it, a byte count or a page count? It's page count. I followed the cma_alloc interface since it has size_t count variable for nr_pages. Let's go with unsigned long nr_pages: void cma_sysfs_alloc_pages_count(struct cma *cma, unsigned long nr_pages) > > > +static ssize_t alloc_pages_success_show(struct kobject *kobj, > > + struct kobj_attribute *attr, char *buf) > > +{ > > + struct cma_kobject *cma_kobj = container_of(kobj, > > + struct cma_kobject, kobj); > > + struct cma *cma = cma_kobj->cma; > > + > > + return sysfs_emit(buf, "%llu\n", > > + atomic64_read(&cma->nr_pages_succeeded)); > > ... if it's in bytes, it should probably be reported in kilobytes > and be suffixed with a 'K' like many other stats. >