From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB891C433C1 for ; Wed, 24 Mar 2021 00:54:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B6B5619DF for ; Wed, 24 Mar 2021 00:54:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B6B5619DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F041F6B01A6; Tue, 23 Mar 2021 20:54:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB5016B01A9; Tue, 23 Mar 2021 20:54:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D618E6B01AA; Tue, 23 Mar 2021 20:54:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id B79216B01A6 for ; Tue, 23 Mar 2021 20:54:34 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 69638180AE811 for ; Wed, 24 Mar 2021 00:54:34 +0000 (UTC) X-FDA: 77952947268.33.967B4B8 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf05.hostedemail.com (Postfix) with ESMTP id A3291E0001B2 for ; Wed, 24 Mar 2021 00:54:33 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id i22so1957438pgl.4 for ; Tue, 23 Mar 2021 17:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EfbPWafZHV8B+cMZtnKVDYJFNv040tyCmUoTNPfkBmM=; b=RMzd0YqTs0PKqc2JKz713ff7M4RphjrpA3SNfYRl6XifFatQwEZ2x4Entv4C2sDK9O /L0vqnoeYD4vKlLJyUEFrp0TP12NBXr8dxoccLxqMZpU0LhaEP3/ilzR2Tq8V2PLNYOX 3Vp9GegzqnT+56//st+gjB/TUYRhkSPVPTV64PBdw7w/Jl7YUaIuTSw1Qvx0oPZW2hw4 qKOXyygJP1O5VDfyE0F/S9vLscgesCjfr6bkINMxnxXPHI3cXWMklf3Anp9fvoPViXDp egMoVGD0BIyRPVvgj6A3Nvz36krv65OEOuF/9HBClKR4exhnbm6nr9qkvb0b0J77Si6c sp1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=EfbPWafZHV8B+cMZtnKVDYJFNv040tyCmUoTNPfkBmM=; b=jU0dMAlOTu5EBCsQPz1cR4XIyOJD+HfCSIJmxjd/EkmzJ43YqFIqjE8DeT5p6DB0Vj RLOAH8mapOGgmLv0o6Rdcgrd5Hj648/4RHQtID8y8npr2IrHBX0lsoTouzbPbNeU90Q0 1tQFW3XG8wuJzl/Dfg8qu47cHVUYwpwbs6gzG5qUdvX7IuOdOZt6luCQFslfasXTREl/ +bJqBKVeXq235HRUyLEt7s5XQV2opO8woVCe9lteSLsYRznmpiWw0MiJDjh22ECeqDnU nrfshCOZF4qnGtFIJn803dIPdrHbYSKfTGfL1ThNEOS3qo4DwxDI6Gpupee8y2gWsF2o XcIg== X-Gm-Message-State: AOAM531NsDlLNo8Pcpp0DTZbhrFlb6gkquCex4GhlFDOFC3KWLEekGzn 21ecLQhz8zpMtG880A52pHQ= X-Google-Smtp-Source: ABdhPJxvjqENNNydmKnOpx8JBk92Te4AIDn06xzGtQChfXuD7JF2FDPsHTYB2mNihOhEycR6DQJoLg== X-Received: by 2002:a62:928f:0:b029:1ef:2370:2600 with SMTP id o137-20020a62928f0000b02901ef23702600mr535310pfd.9.1616547272862; Tue, 23 Mar 2021 17:54:32 -0700 (PDT) Received: from google.com ([2620:15c:211:201:7dfa:1e53:536:7976]) by smtp.gmail.com with ESMTPSA id mr5sm315830pjb.53.2021.03.23.17.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 17:54:32 -0700 (PDT) Date: Tue, 23 Mar 2021 17:54:30 -0700 From: Minchan Kim To: Dmitry Osipenko Cc: Andrew Morton , linux-mm , LKML , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org Subject: Re: [PATCH v5] mm: cma: support sysfs Message-ID: References: <20210323195050.2577017-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Stat-Signature: njyqijprei947ewr7fdo8pgtgzembrfj X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A3291E0001B2 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=mail-pg1-f172.google.com; client-ip=209.85.215.172 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616547273-157656 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 24, 2021 at 12:44:06AM +0300, Dmitry Osipenko wrote: > 23.03.2021 22:50, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > +#ifdef CONFIG_CMA_SYSFS > > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count); > > +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count); >=20 > I'd also rename cma_sysfs_alloc_pages_count to > cma_sysfs_account_success_pages and cma_sysfs_fail_pages_count to > cma_sysfs_account_fail_pages. Every comment makes sense. Will revise and resend. Thanks for the review.