From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0DBC433E2 for ; Mon, 22 Mar 2021 10:47:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C4CFF6198E for ; Mon, 22 Mar 2021 10:47:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4CFF6198E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F4336B00AA; Mon, 22 Mar 2021 06:28:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B8D66B00AC; Mon, 22 Mar 2021 06:28:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57FEB6B00AD; Mon, 22 Mar 2021 06:28:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 3D2426B00AA for ; Mon, 22 Mar 2021 06:28:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A2BE3180424C5 for ; Mon, 22 Mar 2021 10:47:46 +0000 (UTC) X-FDA: 77947184532.29.9253F98 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id F10EA2000255 for ; Mon, 22 Mar 2021 10:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hlbTbL1bDzeKPY7EsML2QdUuMjl1zuiAUSBb6VTOOwQ=; b=vq0G7E4dmauEGmK8/emUUDYZon NNjYF1OmrbnibpO3sK1EBuqrCPxvPbi1lPhi596vu88weXqmIoZyMZLdhlRZbM3uVaQfI0emm9Jtj RiDuBpCWr63s0qIMBMs6uA7WiR86Nj2OLZKxdxjxK5tQwjtWPgy7Y930lSF7TG9vgZJyyYbTPUyKp qNhW2Ua6yzlwbRWuoZrQyU2lBXygmzHy5TXRAe0Rka+X0qyfNJqvCwH8GGbej/kUSRULePgXUWtkE N1VoPqVRrySUL0/J6X8cKELQoEvhP+Ge+y3YrAIRAN2XxhcT7DnSd4eUgT0BNRTVarEvyRZD88FES jFbA8mrg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lOI4l-008Mnt-8c; Mon, 22 Mar 2021 10:46:38 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 1171E306BCA; Mon, 22 Mar 2021 11:46:22 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id ED1832BCFBDAA; Mon, 22 Mar 2021 11:46:21 +0100 (CET) Date: Mon, 22 Mar 2021 11:46:21 +0100 From: Peter Zijlstra To: "Kirill A. Shutemov" Cc: Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang Subject: Re: [PATCH v23 12/28] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY to _PAGE_COW Message-ID: References: <20210316151054.5405-1-yu-cheng.yu@intel.com> <20210316151054.5405-13-yu-cheng.yu@intel.com> <20210322101502.b5hdy3qgyh6hf3sr@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210322101502.b5hdy3qgyh6hf3sr@box> X-Stat-Signature: y4gcmizf7dix854z7tr8mxhuq76sj5b5 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: F10EA2000255 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616410065-300565 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 22, 2021 at 01:15:02PM +0300, Kirill A. Shutemov wrote: > On Tue, Mar 16, 2021 at 08:10:38AM -0700, Yu-cheng Yu wrote: > > + pte_t old_pte, new_pte; > > + > > + old_pte = READ_ONCE(*ptep); > > + do { > > + new_pte = pte_wrprotect(old_pte); > > + } while (!try_cmpxchg(&ptep->pte, &old_pte.pte, new_pte.pte)); > > I think this is wrong. You need to update old_pte on every loop iteration, > otherwise you can get in to endless loop. It is correct, please consider why the old argument is a pointer.