From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87ABFC433C1 for ; Fri, 19 Mar 2021 18:21:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 882C561961 for ; Fri, 19 Mar 2021 18:21:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 882C561961 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 210F36B0078; Fri, 19 Mar 2021 14:21:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E8166B007B; Fri, 19 Mar 2021 14:21:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 062C48D0001; Fri, 19 Mar 2021 14:21:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id E07BE6B0078 for ; Fri, 19 Mar 2021 14:21:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A54C298BB for ; Fri, 19 Mar 2021 18:21:35 +0000 (UTC) X-FDA: 77937441750.09.CBEDDC7 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf08.hostedemail.com (Postfix) with ESMTP id 16A0B801AE44 for ; Fri, 19 Mar 2021 18:21:24 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id a22-20020a17090aa516b02900c1215e9b33so7113725pjq.5 for ; Fri, 19 Mar 2021 11:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=79uKpKqH8yE9ALQi9JEApAMx1JELp/Qz4rJBRLestg4=; b=Z5GSLVHRbgWOht2H1kUZASS6SP7XLmmP6NuxjMuW4qXbGRfWfPsIoY7i6DbauIRt3c E4wZQXLU779XR0oFRrf+AsYi1nDnmunNpnZLomSwWjE4YVNc3n0CoBjoLjE6sKONoy5k 5qRc+XhskLKkawGHgHqqsl8NaUPxwmu+BZMHUAvimDFE8vwPI1sHhojlf1BXmQwgY90H Nv6FUgzcxe5nyJTEY0PfnI+UNbTFALUv8AHEvOhUJqegkvbpsyUbyEEgeHzvqlY3G3KR 5n0xiUehiowiSn3W8cMDr963yjq/S4M+5+iIwcF+1EbNHtE753nzIJHgXAG4WA1rvtHd +aHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=79uKpKqH8yE9ALQi9JEApAMx1JELp/Qz4rJBRLestg4=; b=EQPBQ5iuksRXqXv0JMel5zO6yzItc7lXyz62zhHRhI1ocvh01vZMTcG6maCKWIMCGk YrH/zl0RnYDUmnZEfXX+o5D+uHYhSHK5AHuVJtce2JY3YPLE4YiR+k8ToviXJ5Uj3LP+ NJX/BZeVPVBEwJogD0BUeRkLgdvzo7/mNZ5i4OWkIiIvfPCNeuj/hm7tX/ziedrFhnfU lYcIp9pG2cQxxNAmLS1KJrzb3Qgptni+pKWjNpmSBC2onfzk95lrxYMpWlo2xwN996iW 4S4gruDz/IfxEY4XdQPrxCso/3+E8V51XKv3Imu2JjeTgvwT9YARrAWthM13pUi0WitV +72w== X-Gm-Message-State: AOAM531byxXA5txk2Y2/vuOUhNruT+z9tMJLFb8dBROCr8vmQ7iNDHpE w2fe8GhFtTTGmf+Z74a6Bfs= X-Google-Smtp-Source: ABdhPJxbvucmu60oiEjVBF6kDGI6OoDlPVVu7FPQ7l1x3SCE6vAt7t/FUIzYxxn6Q1J/iofwLTdWlA== X-Received: by 2002:a17:902:d201:b029:e6:bba:52b3 with SMTP id t1-20020a170902d201b02900e60bba52b3mr15882020ply.51.1616178087504; Fri, 19 Mar 2021 11:21:27 -0700 (PDT) Received: from google.com ([2620:15c:211:201:2033:9813:e1ed:7060]) by smtp.gmail.com with ESMTPSA id q34sm5564426pgl.92.2021.03.19.11.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 11:21:26 -0700 (PDT) Date: Fri, 19 Mar 2021 11:21:24 -0700 From: Minchan Kim To: Dmitry Osipenko Cc: Greg Kroah-Hartman , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v4] mm: cma: support sysfs Message-ID: References: <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> <071c6681-f492-2c94-5686-30c30778f39d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <071c6681-f492-2c94-5686-30c30778f39d@gmail.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 16A0B801AE44 X-Stat-Signature: 3bhhwjxfcxf6xe4bgqbzzjxoe9w6xnys Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail-pj1-f48.google.com; client-ip=209.85.216.48 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616178084-791483 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 19, 2021 at 08:56:06PM +0300, Dmitry Osipenko wrote: > 19.03.2021 19:30, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > +static void cma_kobj_release(struct kobject *kobj) > > +{ > > + struct cma_kobject *cma_kobj =3D container_of(kobj, struct cma_kobj= ect, kobj); > > + > > + kfree(cma_kobj); > > +} >=20 > Oh, wait.. I think this kfree wrong since cma_kobj belongs to the array= . Oh, good spot. Let me use kzalloc.