From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B735FC433E0 for ; Fri, 19 Mar 2021 13:43:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5278C6023B for ; Fri, 19 Mar 2021 13:43:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5278C6023B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D5DBA8D0003; Fri, 19 Mar 2021 09:43:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0D846B007D; Fri, 19 Mar 2021 09:43:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD4C38D0003; Fri, 19 Mar 2021 09:43:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id A1ED66B007B for ; Fri, 19 Mar 2021 09:43:05 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6176E1801FA40 for ; Fri, 19 Mar 2021 13:43:05 +0000 (UTC) X-FDA: 77936739930.10.F4955AD Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP id ACB90C0007E9 for ; Fri, 19 Mar 2021 13:43:02 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 812E864F04; Fri, 19 Mar 2021 13:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616161380; bh=7mQCTG/AIZnXq4/oljSjBp3t2b8XcL14K/DhpsnZ5WY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hSI/v73kwjbmtzZbm0OIzh40eyB+o05loZRX372Uaji6cwRlyjMJLn72rtxgbJBxq eUefiXvrpnG1YIBMaXFd8jjR7gM64/lfJwU44yFXTc6ZJzcNMGyvOKMJQVFnCI4HBg WURVRSTINeA5Jzt1iOmKl6eB8ZQncs1OW1uxXcMc= Date: Fri, 19 Mar 2021 14:42:57 +0100 From: Greg Kroah-Hartman To: Dmitry Osipenko Cc: Minchan Kim , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v4] mm: cma: support sysfs Message-ID: References: <20210309062333.3216138-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: ACB90C0007E9 X-Stat-Signature: wyzzy3gwtz93y6wg8s8s464sck6eeigy Received-SPF: none (linuxfoundation.org>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616161382-937881 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 19, 2021 at 04:39:41PM +0300, Dmitry Osipenko wrote: > 19.03.2021 15:44, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > ... > >> #include > >> +#include > >> + > >> +struct cma_stat { > >> + spinlock_t lock; > >> + /* the number of CMA page successful allocations */ > >> + unsigned long nr_pages_succeeded; > >> + /* the number of CMA page allocation failures */ > >> + unsigned long nr_pages_failed; > >> + struct kobject kobj; > >> +}; > >> =20 > >> struct cma { > >> unsigned long base_pfn; > >> @@ -16,6 +26,9 @@ struct cma { > >> struct debugfs_u32_array dfs_bitmap; > >> #endif > >> char name[CMA_MAX_NAME]; > >> +#ifdef CONFIG_CMA_SYSFS > >> + struct cma_stat *stat; > >> +#endif >=20 > What is the point of allocating stat dynamically? Because static kobjects make me cry.