From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D30C433E0 for ; Thu, 18 Mar 2021 15:11:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0577364F18 for ; Thu, 18 Mar 2021 15:11:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0577364F18 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 940036B0075; Thu, 18 Mar 2021 11:11:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 918046B007B; Thu, 18 Mar 2021 11:11:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DFB48D0001; Thu, 18 Mar 2021 11:11:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 620F76B0075 for ; Thu, 18 Mar 2021 11:11:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DD903181AF5C3 for ; Thu, 18 Mar 2021 15:11:13 +0000 (UTC) X-FDA: 77933333226.11.20707B2 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf14.hostedemail.com (Postfix) with ESMTP id B56EDC000C69 for ; Thu, 18 Mar 2021 15:11:08 +0000 (UTC) Received: by mail-qk1-f179.google.com with SMTP id f124so2299899qkj.5 for ; Thu, 18 Mar 2021 08:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MWKeb3ggn5dIOWz1bbbP6KWW8zV+fgH0S33ydz73K40=; b=oJdI5+VQ77I/Xsg1UoAmzbVV5ykG+VEUECp6rHpE7DctVJwC1+GuLouFtJHobzV807 AU+XXyaXmY3ERZk4YUdcCUBTQZi00bTH6IO969As968zmtQQajcCLchwCRlLJAEqdvGk Eh9+4YumegO4ZYw/V0XI/cT4UeoYwpN+M6lGLfJWgcZWJHPH5Iz7ScmnLF9ixTM+7wnt XhpNnl/w70xhFLSBQQtuUYW7ElZKrKhYRqcITGJ52p46/OVRzsbeRq9csiZSEeAZ+ody 50npKbz7mpbTJktHOD9klIEP+CHoMLDkGSQ8BzoDiau7hvCxzJDFJ25HFjJ5gvo/3JWc kCJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MWKeb3ggn5dIOWz1bbbP6KWW8zV+fgH0S33ydz73K40=; b=MKsPKKLiRWVxCdTDg0Bo1wsaL8uHEHhgpPd0B97L/PRKL+QQCKe5TzFtaDOk0gUmh+ +9hsyvjVVvw70l0rv1zdZZo7lO5rY4B3+4w+9hGQdDuBoOe1iVKyoU6ZPN8w+x0tQVzd 7QLkPNfkBRCYWFfyXyZfAKc/cVO+yBWizxVYL+tGjDMn5IXa/aAANDL5GUL/s+KLza/l V1T2PftQ17ezgjHtIy2g05T39PnMUKI3+BY52mzDexx2FrC48mReRePzr+KvMqDUFB9t 1LOCNP8zuGfFGqlogvehUrrPgqU12QX3Vxbx2D/OHTd4I4/VkaOde5Z3RncNHSsSevoI Xg5Q== X-Gm-Message-State: AOAM533DDzqyf9IhyTeatZ9jAUcc1UpOr1G2pVWF756GqQS+NjYMnEh2 nhkdMJ5psonSnwUZOepRZELRzQ== X-Google-Smtp-Source: ABdhPJxhqnAVTwfTW8Epbjdo0C4aW3QFwIyK3i4NrEG6CH9VuGNPsG2pcq+LEoKaWGyg1CMD2uvseg== X-Received: by 2002:a37:a10a:: with SMTP id k10mr4665080qke.171.1616080267971; Thu, 18 Mar 2021 08:11:07 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:e46c]) by smtp.gmail.com with ESMTPSA id d84sm1910262qke.53.2021.03.18.08.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 08:11:07 -0700 (PDT) Date: Thu, 18 Mar 2021 11:11:06 -0400 From: Johannes Weiner To: Muchun Song Cc: guro@fb.com, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com Subject: Re: [PATCH v4 3/5] mm: memcontrol: change ug->dummy_page only if memcg changed Message-ID: References: <20210318110658.60892-1-songmuchun@bytedance.com> <20210318110658.60892-4-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210318110658.60892-4-songmuchun@bytedance.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B56EDC000C69 X-Stat-Signature: i9ixiezzsnc3gdae3twtqc16ctpckbmf Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail-qk1-f179.google.com; client-ip=209.85.222.179 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616080268-734742 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 18, 2021 at 07:06:56PM +0800, Muchun Song wrote: > Just like assignment to ug->memcg, we only need to update ug->dummy_page > if memcg changed. So move it to there. This is a very small optimization. > > Signed-off-by: Muchun Song Acked-by: Johannes Weiner