From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCB7C433DB for ; Thu, 18 Mar 2021 15:03:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 189B964F11 for ; Thu, 18 Mar 2021 15:03:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 189B964F11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63C9C6B0073; Thu, 18 Mar 2021 11:03:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EC7C6B0074; Thu, 18 Mar 2021 11:03:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48D3F8D0001; Thu, 18 Mar 2021 11:03:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 2E9C36B0073 for ; Thu, 18 Mar 2021 11:03:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D7CBB18081BB7 for ; Thu, 18 Mar 2021 15:03:31 +0000 (UTC) X-FDA: 77933313822.07.649AE18 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf01.hostedemail.com (Postfix) with ESMTP id 946695001538 for ; Thu, 18 Mar 2021 15:03:17 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id s7so2270354qkg.4 for ; Thu, 18 Mar 2021 08:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z7lTVVRuSUfjS6oFurvBuW+lqnBMNQb+/M9MCKQeJGA=; b=hAWWBQ5r7q2qGQHnUkSAaN9SgxOHXzxDQuWPR9UYpiwDv9bKlXuBl9O9bQwvhnecCX V9pMmBkWY/uctykn77aF8/spzsmXw8rM3L1lJxcvgPVmo/SS9Om1LTqmDdxw+UClUl+U PxAWoeJhP4OsOJtOJ3+na7BN9Glh4mTVNyUPNu/gGjoJ8vh5fbhD8H07IOHGxhH7LMjr /V8tIIGrAfHjCGBzUlMuMltFDshNKlOb9J2//RnV6fYCAyAd27Oo3Bu4BbmmqdwkJW4D sh9KvbypBkoy7kBfHZUEhCtnPsonmS0cioBYmureMdgxGY8s8YIfL0vdL0H+/uwAz82k 8e7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z7lTVVRuSUfjS6oFurvBuW+lqnBMNQb+/M9MCKQeJGA=; b=Xb1oWusUr0nFFNVlAa3B9hPutNJLQzPfFVhWAhYi91/Vbh6cKn+j4HJfGvo0bS9tei 8dWZYnqdNCLVwXExRISjFExB9S/IvfiKPvmgVjUGvQvqkcACjY5VnHJRHqQfSHC8bZ3n joR3evi/E3XcLj+wu/FpHimfplVC9GzQyDkDb46ZZShKGUaSttLPG+83ldo9g4kPZ7CN lUGkpJApZ1ouVFrcLPfHY4UaW0eBVYCbbV1WH9XfV6xWaLEUlk5aHTQ9nD0n57jc4kBx kX6hby27Relt6c21tYysZ2s1XEvYckKgwUhqZWp8Zj8c2HlRBvEi4NZiVjcqumpjHyrE o43g== X-Gm-Message-State: AOAM530StnMoZ4lwoH0Ksic/SVzNVX5EMifyztzb+YZfqgM6PWhYgYiN i5RXyoFQ4jo3yvSdQW+0qE0mEA== X-Google-Smtp-Source: ABdhPJyIgDLaHHCU8sW5eq1vsv7FTz+05aFOuJTSx/oJJ18ACJl8GOweg+N0HKmwfRR5GC3cJg4xuQ== X-Received: by 2002:a05:620a:641:: with SMTP id a1mr4568571qka.257.1616079792499; Thu, 18 Mar 2021 08:03:12 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:e46c]) by smtp.gmail.com with ESMTPSA id g2sm1626319qtu.0.2021.03.18.08.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 08:03:12 -0700 (PDT) Date: Thu, 18 Mar 2021 11:03:10 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Hugh Dickins , Roman Gushchin , Michal Hocko , Andrew Morton , Minchan Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Heiko Carstens Subject: Re: [PATCH] memcg: set page->private before calling swap_readpage Message-ID: References: <20210318015959.2986837-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210318015959.2986837-1-shakeelb@google.com> X-Stat-Signature: spbxn81mg78anfngkqz3cpdcywn88oic X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 946695001538 Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=mail-qk1-f173.google.com; client-ip=209.85.222.173 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616079797-812903 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000955, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 17, 2021 at 06:59:59PM -0700, Shakeel Butt wrote: > The function swap_readpage() (and other functions it call) extracts swap > entry from page->private. However for SWP_SYNCHRONOUS_IO, the kernel > skips the swapcache and thus we need to manually set the page->private > with the swap entry before calling swap_readpage(). > > Signed-off-by: Shakeel Butt > Reported-by: Heiko Carstens LGTM