From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33743C433DB for ; Fri, 12 Mar 2021 19:24:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D3CF64F84 for ; Fri, 12 Mar 2021 19:24:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D3CF64F84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CC4CD6B006C; Fri, 12 Mar 2021 14:24:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9B306B006E; Fri, 12 Mar 2021 14:24:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B62F66B0070; Fri, 12 Mar 2021 14:24:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 9D3206B006C for ; Fri, 12 Mar 2021 14:24:32 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 61A84612C for ; Fri, 12 Mar 2021 19:24:32 +0000 (UTC) X-FDA: 77912198784.26.96C7653 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf13.hostedemail.com (Postfix) with ESMTP id B5829E0011E6 for ; Fri, 12 Mar 2021 19:24:29 +0000 (UTC) Received: by mail-qt1-f176.google.com with SMTP id a11so4678147qto.2 for ; Fri, 12 Mar 2021 11:24:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pEeTkEyXCfwqMVGSwUe44009Y4fam47Rux0tIaathAw=; b=o+0Wr4xkcRXdqUXtgfCtTFILjSgiNCLOf8HVzZyATUpxMeDMS4pbm5pWF9BZSPUcNg RvjmjZ1+lbmuZA+hyUxHfwM+r+p6EpC9eXskkmQt/2MfyJ4ogrxpOp6uLaYUn4xLuy27 cEdDXBY0aRy0wDONyH/LTL2Xzc3gQQvG2fb6vc/7PBkbzH0nkit8+EW+8n98PLzySgo3 rcmEBLO+Za3DH4J5ruW3yl+uRWnrpPD9F00QWK7sk9vpulDHAOXWy4jhO6DtqaZtlsAA O5qI6TKdS4KhZXdBjd9Wgh0LQKBZQQ4G5nGMqYIO8j51x5qMHv2F0tCTm4D+Yz5xvaHk WjXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pEeTkEyXCfwqMVGSwUe44009Y4fam47Rux0tIaathAw=; b=P5i1FriFByqRamjRFBXXQ497ab1kB5UPefdVnO5i3c5o6HbPoMo/Z76Bv1dlKR3bsb 8orBJpGHWw2CC+ZCOF+EY3UCcQOxfmYgFf8pihVkRFO3KGqsdU7gHc0e00aH+7KIcz3D liFabiDO9mEkU4cha0hKScCTAR1NJ1YR7D+yUByg3KyHFIpVEvbR8NvMOD2HEzLv8A7E kM9KATdE9pXFwWHbF+KZGUVcjaLywCTzLjQ0zUmIVfPUTs2VAw288yC+DdDlnpTsfKdL u+hkICOFZpuTRuiOmSW+DWhLAkrURa1qi2vFSwf9s7upjCRXcZKzrtwbWmLw6YU0G8Jy z0ag== X-Gm-Message-State: AOAM532T9YH9CWBUU9aHPnj/0GBiSHnMhWEvcRxZffarDgvFgU+QTLNK m2hRmm6ja71jg2X7trqAVyWfEg== X-Google-Smtp-Source: ABdhPJyHpoXz+krFmX117IHeSWej/wRy9Y0LADvEsDmUM3LlxQIqK9L/gvpZAJGEpCNki6o+kZu1Ug== X-Received: by 2002:a05:622a:14f:: with SMTP id v15mr13552545qtw.212.1615577071277; Fri, 12 Mar 2021 11:24:31 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id j6sm5191840qkm.81.2021.03.12.11.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 11:24:30 -0800 (PST) Date: Fri, 12 Mar 2021 14:24:30 -0500 From: Johannes Weiner To: Muchun Song Cc: guro@fb.com, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com Subject: Re: [PATCH v3 4/4] mm: memcontrol: move PageMemcgKmem to the scope of CONFIG_MEMCG_KMEM Message-ID: References: <20210309100717.253-1-songmuchun@bytedance.com> <20210309100717.253-5-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210309100717.253-5-songmuchun@bytedance.com> X-Stat-Signature: 9is9dzdfhis9bhk5pc4qfansysprzwip X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B5829E0011E6 Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=mail-qt1-f176.google.com; client-ip=209.85.160.176 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615577069-566435 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 09, 2021 at 06:07:17PM +0800, Muchun Song wrote: > The page only can be marked as kmem when CONFIG_MEMCG_KMEM is enabled. > So move PageMemcgKmem() to the scope of the CONFIG_MEMCG_KMEM. > > As a bonus, on !CONFIG_MEMCG_KMEM build some code can be compiled out. > > Signed-off-by: Muchun Song Acked-by: Johannes Weiner