From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5309CC433DB for ; Thu, 11 Mar 2021 21:48:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CCF1164EF9 for ; Thu, 11 Mar 2021 21:48:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCF1164EF9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4EE828D0305; Thu, 11 Mar 2021 16:48:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 48D2F8D02B2; Thu, 11 Mar 2021 16:48:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3561F8D0305; Thu, 11 Mar 2021 16:48:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 192028D02B2 for ; Thu, 11 Mar 2021 16:48:41 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CC692181AF5C4 for ; Thu, 11 Mar 2021 21:48:40 +0000 (UTC) X-FDA: 77908933200.19.B1020E6 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf27.hostedemail.com (Postfix) with ESMTP id B188C8019151 for ; Thu, 11 Mar 2021 21:48:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B4FE1AC54; Thu, 11 Mar 2021 21:48:37 +0000 (UTC) Date: Thu, 11 Mar 2021 22:48:34 +0100 From: Oscar Salvador To: Dave Hansen Cc: Andrew Morton , David Hildenbrand , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Michal Hocko , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 3/4] x86/vmemmap: Handle unpopulated sub-pmd ranges Message-ID: References: <20210309214050.4674-1-osalvador@suse.de> <20210309214050.4674-4-osalvador@suse.de> <0c4132aa-5d59-c0ba-5cfc-4ac401feba04@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c4132aa-5d59-c0ba-5cfc-4ac401feba04@intel.com> X-Stat-Signature: grfdewxr4zfgdaefokotok9kk5qn4zbg X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B188C8019151 Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1615499314-227950 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 11, 2021 at 01:29:39PM -0800, Dave Hansen wrote: > On 3/9/21 1:40 PM, Oscar Salvador wrote: > > +static void __meminit vmemmap_use_new_sub_pmd(unsigned long start, unsigned long end) > > +{ > > + /* > > + * Could be our memmap page is filled with PAGE_UNUSED already from a > > + * previous remove. Make sure to reset it. > > + */ > > + vmemmap_use_sub_pmd(start); > > + > > + /* > > + * Mark with PAGE_UNUSED the unused parts of the new memmap range > > + */ > > + if (!IS_ALIGNED(start, PMD_SIZE)) > > + memset((void *)start, PAGE_UNUSED, > > + start - ALIGN_DOWN(start, PMD_SIZE)); > > + if (!IS_ALIGNED(end, PMD_SIZE)) > > + memset((void *)end, PAGE_UNUSED, > > + ALIGN(end, PMD_SIZE) - end); > > +} > > +#endif > > This is apparently under both CONFIG_SPARSEMEM_VMEMMAP and > CONFIG_MEMORY_HOTPLUG #ifdefs. It errors out at compile-time with this > config: https://sr71.net/~dave/intel/config-mmotm-20210311 It seems that mmotm still has v5. v6 (this one) fixed that up. I basically moved the code out of MEMORY_HOTPLUG #ifdefs. I could not reproduce your error on v6. -- Oscar Salvador SUSE L3