From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E11C433E0 for ; Thu, 11 Mar 2021 08:47:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 520CA64FA8 for ; Thu, 11 Mar 2021 08:47:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 520CA64FA8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D07978D0295; Thu, 11 Mar 2021 03:46:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDE388D028E; Thu, 11 Mar 2021 03:46:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA64A8D0295; Thu, 11 Mar 2021 03:46:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 9F7CF8D028E for ; Thu, 11 Mar 2021 03:46:59 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5C69A52AA for ; Thu, 11 Mar 2021 08:46:59 +0000 (UTC) X-FDA: 77906963358.19.9F8C606 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 3CFC2E4 for ; Thu, 11 Mar 2021 08:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=L2P1sESFUaV/AW0lkKatvnx8pKxtKng9weUi15MfMaU=; b=gBR8eV/IbSiscH5JXflpZdDHlL qXZjFCvww+N7QntlYCowl3IeE37q+IDEkBXAxykul4NiMQAW19F/sjBYh3mIXa0UshPeV29p4k4EJ Yxh2q43xfCKcQ0/DH0QF2tY0s5MrbYg8pELzhVxzsAEMMHzr79AmjLs2Eg3umsSUH6oDZefUO/Pa6 JW45InAPh5dp07yzhiUFaew3WEUyxqEvWmVCGJIOLgx1JlIy2RUk/z3gIyC+tt4kFQ7VKCs6C4mrR Xy7Xy6OIkFSg0FPFWXzeLZa0WxY0g/tYCZJBHymbix50HqitTL6iQXBWFYy0UctE1BatbdFnkRfck t5ifThQw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lKGxk-006tOG-55; Thu, 11 Mar 2021 08:46:35 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 1E2B63013E5; Thu, 11 Mar 2021 09:46:31 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 03A2520C99AA3; Thu, 11 Mar 2021 09:46:30 +0100 (CET) Date: Thu, 11 Mar 2021 09:46:30 +0100 From: Peter Zijlstra To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , "Paul E . McKenney" , Shakeel Butt , tglx@linutronix.de, john.ogness@linutronix.de, urezki@gmail.com, ast@fb.com, Eric Dumazet , Mina Almasry , Andrew Morton Subject: Re: [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use Message-ID: References: <20210311021321.127500-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210311021321.127500-1-mike.kravetz@oracle.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3CFC2E4 X-Stat-Signature: ewqzftfpzz9arhfnhwshbgda4tamm5qq Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615452415-902029 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 10, 2021 at 06:13:21PM -0800, Mike Kravetz wrote: > from irq context. Changing the check in the code from !in_task to > in_atomic would handle the situations when called with irqs disabled. It does not. local_irq_disable() does not change preempt_count().