From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17923C433DB for ; Wed, 10 Mar 2021 21:58:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3FF9E64FC4 for ; Wed, 10 Mar 2021 21:58:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FF9E64FC4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A268F8D0217; Wed, 10 Mar 2021 16:58:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D6338D01ED; Wed, 10 Mar 2021 16:58:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89FA08D0217; Wed, 10 Mar 2021 16:58:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 718CD8D01ED for ; Wed, 10 Mar 2021 16:58:22 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 39A66180ACEEC for ; Wed, 10 Mar 2021 21:58:22 +0000 (UTC) X-FDA: 77905328844.30.761674C Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf28.hostedemail.com (Postfix) with ESMTP id BC6E42000385 for ; Wed, 10 Mar 2021 21:58:22 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5306EAD87; Wed, 10 Mar 2021 21:58:20 +0000 (UTC) Date: Wed, 10 Mar 2021 22:58:17 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] x86/vmemmap: Handle unpopulated sub-pmd ranges Message-ID: References: <20210309174113.5597-1-osalvador@suse.de> <20210309174113.5597-4-osalvador@suse.de> <3471fe0e-d8f4-c8fe-2096-8d9c8b1ab5bc@redhat.com> <20210310174953.GA16289@linux> <1814c21c-b822-0ec6-c16d-92424d00663a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1814c21c-b822-0ec6-c16d-92424d00663a@redhat.com> X-Stat-Signature: ietdcbsin7wtcix9z1ys1gebtww768qg X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BC6E42000385 Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1615413502-125375 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 10, 2021 at 06:58:26PM +0100, David Hildenbrand wrote: > Thinking again, I guess it might be a good idea to factor out the core > functions into common code. For the optimization part, it might make sense > too pass some "state" structure that contains e.g., "unused_pmd_start". Yeah, that really sounds like a good thing to do. > > Then we don't have diverging implementations of essentially the same thing. > > Of course, we can do that on top of this series - unifying both > implementations. I would rather do it on top of this series, not because I am lazy, but rather fairly busy and I will not be able to spend much time on it anytime soon. Once this series gets merged, I commit to have a look into that. Thanks! -- Oscar Salvador SUSE L3