From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EAE5C433E0 for ; Wed, 10 Mar 2021 15:59:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0781164F9B for ; Wed, 10 Mar 2021 15:59:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0781164F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 91D4E8D01C3; Wed, 10 Mar 2021 10:59:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F3A28D01A6; Wed, 10 Mar 2021 10:59:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BF7E8D01C3; Wed, 10 Mar 2021 10:59:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 612BD8D01A6 for ; Wed, 10 Mar 2021 10:59:40 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8B762181200EA for ; Wed, 10 Mar 2021 15:59:39 +0000 (UTC) X-FDA: 77904424878.25.8782AE3 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf27.hostedemail.com (Postfix) with ESMTP id A52CD801915F for ; Wed, 10 Mar 2021 15:59:35 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id z5so8695943plg.3 for ; Wed, 10 Mar 2021 07:59:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XYIw53FG6Pi0idyEbOGAM+kfG1SQqpJslcWfjDqB6js=; b=prYQIQ3qyXWCVibRtNvRq4flpOmaMd4lkcnSgz/w7bz6BKppSS0icpG1u485cofcxh l6GchQXDHIrUAS8oQUK55YNP3CeIQtaA6ZUGvtzehNMplVm2wt5zNf9nG2Osy6bhY9MC D/izinGXARDF/6KJv9HJ8k0h23vy9PBKh5N88D7D42lbhQngCpsUqVQmpvcdgzfQEyw5 83yGT0xVrOVCbmQyXJxSbP553TQ0OwMmMAzUGXdLB6brA9hIsRNQv9MCbCFANc08hoRC IsExRfEvwiRtA9yHu8cgAbFBsLuUMvN8KQpKffzhU+PX/d2cm0vg0s05HP1H6R5Gk3mI MOfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=XYIw53FG6Pi0idyEbOGAM+kfG1SQqpJslcWfjDqB6js=; b=DwhrD78M7GNk29D6jvFd1D6sDbSDo1ZAS36lzoKMw+0WjdVO2EZh1iT5rOZsOryzDL +BbzDe+oxR8j1fAoGo3Ow09rRxnMc6OlKz7+TtE51ijNOy7uE7ej7WFF1zgRd2ByMIRG K0N/Z6hIQj0mnpmaTiCTdzQgpMyS/tONpPg78/j533rPtV9XfA/ASfo29vYoX8Pmb2pE +24nkZ2esCFgYpDYtgb2tAK5ur+Ju/jd5TyoB/I0K4Ff3rKabHdh7vGCPsrR9YgsTMZ/ vCNgvLyJO17fTH7V6aCiLZSehS8tp5QX6vuIIzQiEL0+RliwtkwVoeS87tmcAHGOIjWk qOUQ== X-Gm-Message-State: AOAM530yhlPml3PfRHQzE0ccgjhGHvJi0HofOk09M82+50SmXcsepIZs tg76BS7VqPeR9k1i+itgKo0= X-Google-Smtp-Source: ABdhPJyoegNIOLarzPhAC3f6wVIE5ZPCpUJZiCanxiVr5Qw4WCeU0M8Sur02hLDMi1tBXT3I8ePCRg== X-Received: by 2002:a17:902:d2c7:b029:e6:34e2:7a83 with SMTP id n7-20020a170902d2c7b02900e634e27a83mr3759493plc.60.1615391977985; Wed, 10 Mar 2021 07:59:37 -0800 (PST) Received: from google.com ([2620:15c:211:201:64cb:74c7:f2c:e5e0]) by smtp.gmail.com with ESMTPSA id c193sm17971105pfc.180.2021.03.10.07.59.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 07:59:36 -0800 (PST) Date: Wed, 10 Mar 2021 07:59:34 -0800 From: Minchan Kim To: Michal Hocko Cc: Andrew Morton , linux-mm , LKML , John Dias , David Hildenbrand , Jason Baron Subject: Re: [PATCH v2] mm: page_alloc: dump migrate-failed pages Message-ID: References: <20210308202047.1903802-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A52CD801915F X-Stat-Signature: 3fd8gokah5uggukj1asi8rswczt4ce8r Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mail-pl1-f177.google.com; client-ip=209.85.214.177 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615391975-610399 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 10, 2021 at 02:04:55PM +0100, Michal Hocko wrote: < snip > > > > Also are all those CONFIG_DYNAMIC_DEBUG* ifdefs necessary? Can we > > > simply enable DYNAMIC_DEBUG for page_alloc as I've suggested above? > > > > They are different usecases. > > > > With DYNAMIC_DEBUG_MODULE with CONFIG_DYNAMIC_DEBUG_CORE, > > it works for only specific compile flags as you suggested. > > (CONFIG_DYNAMIC_DEBUG_CORE is requirement to work DYNAMIC_DEBUG_MODULE. > > > > With CONFIG_DYNAMIC_DEBUG, user could enable/disable every dynamic > > debug places without needing DYNAMIC_DEBUG_MODULE flags for source > > files. > > > > Both usecase makes sense to me. > > Well, this is more of a question for dynamic debugging maintainers. But > it would be really great to reduce the ifdefery as much as possible. I don't understand why this is something particular case which is okay to lose either way to make dyndbg dynamic.