From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57318C433DB for ; Wed, 10 Mar 2021 17:07:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 066DD64F9A for ; Wed, 10 Mar 2021 17:07:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 066DD64F9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 988068D01DF; Wed, 10 Mar 2021 12:06:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 910338D01D5; Wed, 10 Mar 2021 12:06:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73C2E8D01DF; Wed, 10 Mar 2021 12:06:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 538C88D01D5 for ; Wed, 10 Mar 2021 12:06:59 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 174B9180ACEF0 for ; Wed, 10 Mar 2021 17:06:59 +0000 (UTC) X-FDA: 77904594558.27.651EE4C Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf13.hostedemail.com (Postfix) with ESMTP id DBC10E000645 for ; Wed, 10 Mar 2021 17:06:50 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so7840999pjv.1 for ; Wed, 10 Mar 2021 09:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TfEm/y7pEQMr6MXjjU5bRH5tGGOCo24jcAcUw3mQM4s=; b=J8abThtMfxLAw9eH0YlC39eu8FGF7dH6sZt718K5+YhCCZy93/gSBWX7M+fIM7DWLa GWQwxTOkLGTL8cd958P0pBPh6vXMmO9AnVKXyF8EH/OCdPNJyWyZocVk+PmoRpGror5r DFzs8s7ZyXS42Ng/2yRaDkbLOrONFs9Xc2kjq0Nfof0LW+xC7Bj88jP1EH4N7IFUgtwq cAskTeWfYexhsik70qKo19NxwDLWLudHXXHNnvsEn8vTRKMCu2vEj55Ijw2jHPR6ZoMq GI8oruf7g41Wx0c6VBcfGcVxhXVsfBXkWifpJksav3KLiCjGVMGm49ANYJRkpHKZb0gm QCtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=TfEm/y7pEQMr6MXjjU5bRH5tGGOCo24jcAcUw3mQM4s=; b=mrQ+GM2mLEHe4PKwtG00AwXq0NeBqHkzUXaRpGhuUmAPgd3864XwaXiuoiVG+5UzIm XB248MAEOh3/ucLus8tunuZJl7JwoO2Hz6CowoaByrYUt3qupkoBo+Dt0KQT2cdSQDlI 8XB59ZN+A+QuY+DJYKSEYKjmX4C8WuUlazXkrXXe29kW2Y+p/z7enQNDJJfYp7zWbLv6 AJrR2qFu5akt9JaKZMlGbWdS9D6fAzi8OuCxuzF4PgmAdvfn2DHw/WhipxrzF8pNmAn5 fUslGjHfWCJN5BEC0UmEC/bKYm/K3TTd1jQ+8C9TMmEwBftd4fWkZgTPgILv+sLuzYrA XIhA== X-Gm-Message-State: AOAM532GqDYk4+Heic2x/887c410pZnvAbUkyxXEr3qJVeVaL15i0UWm aUI3h3W49WOg1v0o1JI7G0g= X-Google-Smtp-Source: ABdhPJwCWRueY/ClQ9By+RMJ0jAAvHVZvk6Jo9yiDh5JYuCFUDKZftr/Fb0E8TWYxiq/4YZfFygOmg== X-Received: by 2002:a17:90b:305:: with SMTP id ay5mr4529677pjb.74.1615396011239; Wed, 10 Mar 2021 09:06:51 -0800 (PST) Received: from google.com ([2620:15c:211:201:64cb:74c7:f2c:e5e0]) by smtp.gmail.com with ESMTPSA id d8sm113990pfq.27.2021.03.10.09.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 09:06:50 -0800 (PST) Date: Wed, 10 Mar 2021 09:06:48 -0800 From: Minchan Kim To: Michal Hocko Cc: Andrew Morton , linux-mm , LKML , John Dias , David Hildenbrand , Jason Baron Subject: Re: [PATCH v2] mm: page_alloc: dump migrate-failed pages Message-ID: References: <20210308202047.1903802-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: kcjtnbm5phso181ee7uqpr35n7iopy45 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DBC10E000645 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=mail-pj1-f44.google.com; client-ip=209.85.216.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615396010-912561 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 10, 2021 at 05:46:56PM +0100, Michal Hocko wrote: > On Wed 10-03-21 08:05:36, Minchan Kim wrote: > > On Wed, Mar 10, 2021 at 02:07:05PM +0100, Michal Hocko wrote: > [...] > > > The is a lot of churn indeed. Have you considered adding $FOO_lglvl > > > variants for those so that you can use them for your particular case > > > without affecting most of existing users? Something similar we have > > > discussed in other email thread regarding lru_add_drain_all? > > > > I thought that way but didn't try since it couldn't make them > > atomic(For example, other printk place in other context will > > affect by the $FOO_lglvl). > > I do not follow. I meant something like the following (likely incomplete > but you should get an idea). Oh, I thought you wanted to override loglevel temporally. old_lvl = save_printk_lvl(new level); dump_page(); restore_printk_lvl(old_lvl); > > diff --git a/include/linux/page_owner.h b/include/linux/page_owner.h > index 3468794f83d2..71b402eb8f78 100644 > --- a/include/linux/page_owner.h > +++ b/include/linux/page_owner.h > @@ -14,7 +14,7 @@ extern void __set_page_owner(struct page *page, > extern void __split_page_owner(struct page *page, unsigned int nr); > extern void __copy_page_owner(struct page *oldpage, struct page *newpage); > extern void __set_page_owner_migrate_reason(struct page *page, int reason); > -extern void __dump_page_owner(struct page *page); > +extern void __dump_page_owner(struct page *page, const char *loglvl); > extern void pagetypeinfo_showmixedcount_print(struct seq_file *m, > pg_data_t *pgdat, struct zone *zone); > > @@ -46,10 +46,10 @@ static inline void set_page_owner_migrate_reason(struct page *page, int reason) > if (static_branch_unlikely(&page_owner_inited)) > __set_page_owner_migrate_reason(page, reason); > } > -static inline void dump_page_owner(struct page *page) > +static inline void dump_page_owner(struct page *page, const char *loglvl) > { > if (static_branch_unlikely(&page_owner_inited)) > - __dump_page_owner(page); > + __dump_page_owner(page, loglvl); > } > #else > static inline void reset_page_owner(struct page *page, unsigned int order) > @@ -69,7 +69,7 @@ static inline void copy_page_owner(struct page *oldpage, struct page *newpage) > static inline void set_page_owner_migrate_reason(struct page *page, int reason) > { > } > -static inline void dump_page_owner(struct page *page) > +static inline void dump_page_owner(struct page *page, const char *loglvl) > { > } > #endif /* CONFIG_PAGE_OWNER */ > diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c > index 9f8117c7cfdd..1b13135d9916 100644 > --- a/kernel/stacktrace.c > +++ b/kernel/stacktrace.c > @@ -14,6 +14,18 @@ > #include > #include > > +void __stack_trace_print(const unsigned long *entries, unsigned int nr_entries, > + int spacesconst, char *loglvl) > +{ > + unsigned int i; > + > + if (WARN_ON(!entries)) > + return; > + > + for (i = 0; i < nr_entries; i++) > + printk("%s%*c%pS\n", loglvl, 1 + spaces, ' ', (void *)entries[i]); > +} That's exactly I did with introducing pr_loglevel. I wanted to address *all places* to use dump_page and stack_trace_print since some folks might ask me to fix all the broken place all at once. I'm getting tired with such hassle. void dump_page(const char *log_lvl, struct page *page, const char *reason) { __dump_page(log_lvl, page, reason); dump_page_owner(log_lvl, page); } EXPORT_SYMBOL(dump_page); /** * pr_loglevel - Print an loglevel message * @level: loglevel * @fmt: format string * @...: arguments for the format string * * This macro expands to a printk with @loglevel. It uses pr_fmt() to * generate the format string. */ #define pr_loglevel(level, fmt, ...) \ printk("%s" pr_fmt(fmt), level, ##__VA_ARGS__) void __dump_page(const char *log_lvl, struct page *page, const char *reason) { .. .. if (page_poisoned) { pr_loglevel(log_lvl, "page:%px is uninitialized and poisoned", page); goto hex_only; } .. } static inline void dump_page_owner(const char *log_lvl, struct page *page) { if (static_branch_unlikely(&page_owner_inited)) __dump_page_owner(log_lvl, page); } void stack_trace_print(const char *log_lvl, const unsigned long *entries, unsigned int nr_entries, int spaces) { unsigned int i; if (WARN_ON(!entries)) return; for (i = 0; i < nr_entries; i++) pr_loglevel(log_lvl, "%*c%pS\n", 1 + spaces, ' ', (void *)entries[i]); } EXPORT_SYMBOL_GPL(stack_trace_print);