From: Michal Hocko <mhocko@suse.com>
To: Roman Gushchin <guro@fb.com>
Cc: Shakeel Butt <shakeelb@google.com>,
Vasily Averin <vvs@virtuozzo.com>,
Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 1/9] memcg: accounting for allocations called with disabled BH
Date: Wed, 10 Mar 2021 10:42:29 +0100 [thread overview]
Message-ID: <YEiUhWjsC6HbYFpT@dhcp22.suse.cz> (raw)
In-Reply-To: <YEfYFIlRH0+0XWwT@carbon.dhcp.thefacebook.com>
On Tue 09-03-21 12:18:28, Roman Gushchin wrote:
> On Tue, Mar 09, 2021 at 11:39:41AM -0800, Shakeel Butt wrote:
> > On Tue, Mar 9, 2021 at 12:04 AM Vasily Averin <vvs@virtuozzo.com> wrote:
> > >
> > > in_interrupt() check in memcg_kmem_bypass() is incorrect because
> > > it does not allow to account memory allocation called from task context
> > > with disabled BH, i.e. inside spin_lock_bh()/spin_unlock_bh() sections
> > >
> > > Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> >
> > In that file in_interrupt() is used at other places too. Should we
> > change those too?
>
> Yes, it seems so. Let me prepare a fix (it seems like most of them were
> introduced by me).
Does this affect any existing in-tree users?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-03-10 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 8:03 Vasily Averin
2021-03-09 14:57 ` Michal Hocko
2021-03-10 9:11 ` Vasily Averin
2021-03-10 9:40 ` Michal Hocko
2021-03-09 19:39 ` Shakeel Butt
2021-03-09 20:18 ` Roman Gushchin
2021-03-10 9:21 ` Vasily Averin
2021-03-10 9:42 ` Michal Hocko [this message]
2021-03-10 19:09 ` Roman Gushchin
2021-03-10 9:17 ` Vasily Averin
2021-03-09 20:39 ` Roman Gushchin
2021-03-10 9:26 ` Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEiUhWjsC6HbYFpT@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox