From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B9AC433E0 for ; Tue, 9 Mar 2021 21:27:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A8C2F6527D for ; Tue, 9 Mar 2021 21:27:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8C2F6527D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 497F38D002D; Tue, 9 Mar 2021 16:27:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 447D18D000F; Tue, 9 Mar 2021 16:27:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2C58D002D; Tue, 9 Mar 2021 16:27:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 0EE078D000F for ; Tue, 9 Mar 2021 16:27:55 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B8CCC180CC1B3 for ; Tue, 9 Mar 2021 21:27:54 +0000 (UTC) X-FDA: 77901623268.03.96DFAEF Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf10.hostedemail.com (Postfix) with ESMTP id 1AB31407F8F8 for ; Tue, 9 Mar 2021 21:27:50 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3F49BAFF9; Tue, 9 Mar 2021 21:27:53 +0000 (UTC) Date: Tue, 9 Mar 2021 22:27:50 +0100 From: Oscar Salvador To: Dave Hansen Cc: Andrew Morton , David Hildenbrand , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/4] x86/vmemmap: Drop handling of 1GB vmemmap ranges Message-ID: References: <20210309174113.5597-1-osalvador@suse.de> <20210309174113.5597-3-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1AB31407F8F8 X-Stat-Signature: fjon69dmaoefaygf4fa98rdjpsmptisb Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1615325270-735125 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 09, 2021 at 10:34:51AM -0800, Dave Hansen wrote: > On 3/9/21 9:41 AM, Oscar Salvador wrote: > > We never get to allocate 1GB pages when mapping the vmemmap range. > > Drop the dead code both for the aligned and unaligned cases and leave > > only the direct map handling. > > I was hoping to seem some more meat in this changelog, possibly some of > what David Hildenbrand said in the v4 thread about this patch. > Basically, we don't have code to allocate 1G mappings because it isn't > clear that it would be worth the complexity, and it might also waste memory. > > I'm fine with the code, but I would appreciate a beefed-up changelog: > > Acked-by: Dave Hansen Since I had to do another pass to fix up some compilaton errors, I added a bit more of explanation in that regard. Thanks! -- Oscar Salvador SUSE L3