From: Oscar Salvador <osalvador@suse.de>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] x86/vmemmap: Drop handling of 1GB vmemmap ranges
Date: Tue, 9 Mar 2021 22:27:50 +0100 [thread overview]
Message-ID: <YEfoVqVglWUbepvW@localhost.localdomain> (raw)
In-Reply-To: <a701a162-d581-42e9-bae5-7c43741bbf7b@intel.com>
On Tue, Mar 09, 2021 at 10:34:51AM -0800, Dave Hansen wrote:
> On 3/9/21 9:41 AM, Oscar Salvador wrote:
> > We never get to allocate 1GB pages when mapping the vmemmap range.
> > Drop the dead code both for the aligned and unaligned cases and leave
> > only the direct map handling.
>
> I was hoping to seem some more meat in this changelog, possibly some of
> what David Hildenbrand said in the v4 thread about this patch.
> Basically, we don't have code to allocate 1G mappings because it isn't
> clear that it would be worth the complexity, and it might also waste memory.
>
> I'm fine with the code, but I would appreciate a beefed-up changelog:
>
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
Since I had to do another pass to fix up some compilaton errors,
I added a bit more of explanation in that regard.
Thanks!
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-03-09 21:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 17:41 [PATCH v5 0/4] Cleanup and fixups for vmemmap handling Oscar Salvador
2021-03-09 17:41 ` [PATCH v5 1/4] x86/vmemmap: Drop handling of 4K unaligned vmemmap range Oscar Salvador
2021-03-09 17:41 ` [PATCH v5 2/4] x86/vmemmap: Drop handling of 1GB vmemmap ranges Oscar Salvador
2021-03-09 18:34 ` Dave Hansen
2021-03-09 21:27 ` Oscar Salvador [this message]
2021-03-09 17:41 ` [PATCH v5 3/4] x86/vmemmap: Handle unpopulated sub-pmd ranges Oscar Salvador
2021-03-09 17:52 ` David Hildenbrand
2021-03-10 17:49 ` Oscar Salvador
2021-03-10 17:58 ` David Hildenbrand
2021-03-10 21:58 ` Oscar Salvador
2021-03-11 16:38 ` David Hildenbrand
2021-03-09 18:39 ` Dave Hansen
2021-03-09 17:41 ` [PATCH v5 4/4] x86/vmemmap: Optimize for consecutive sections in partial populated PMDs Oscar Salvador
2021-03-09 18:50 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEfoVqVglWUbepvW@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox