From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5823EC433DB for ; Tue, 9 Mar 2021 08:28:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0885E65237 for ; Tue, 9 Mar 2021 08:28:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0885E65237 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 800BB8D00C7; Tue, 9 Mar 2021 03:28:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B16A8D007F; Tue, 9 Mar 2021 03:28:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 650CD8D00C7; Tue, 9 Mar 2021 03:28:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 492938D007F for ; Tue, 9 Mar 2021 03:28:28 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0AB275836 for ; Tue, 9 Mar 2021 08:28:28 +0000 (UTC) X-FDA: 77899659096.27.DE982AE Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf18.hostedemail.com (Postfix) with ESMTP id 27D852000390 for ; Tue, 9 Mar 2021 08:28:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615278506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3x2XIxgfjhorUHBLN/3kYdSw0pyeuC2U9t99e69VR1w=; b=jmaB5EvS92fVBGydJx9tEuTD4FFNFj7e1/KPP/oloRMuYh2bIpLMnh9RfULVCVLroGmG3Z SEZDDURwZkUKThd6R7QG8bnL1U309iJtXXI2GUdJWlN+/eisoY2CmIN6/Lxt5/UrITScle ux1yizLdAs64IycXDmP2S61KfU+JyxI= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 617CEAC24; Tue, 9 Mar 2021 08:28:26 +0000 (UTC) Date: Tue, 9 Mar 2021 09:28:25 +0100 From: Michal Hocko To: "Singh, Balbir" Cc: Zhou Guanghui , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hannes@cmpxchg.org, hughd@google.com, kirill.shutemov@linux.intel.com, npiggin@gmail.com, ziy@nvidia.com, wangkefeng.wang@huawei.com, guohanjun@huawei.com, dingtianhong@huawei.com, chenweilong@huawei.com, rui.xiang@huawei.com Subject: Re: [PATCH v2 1/2] mm/memcg: rename mem_cgroup_split_huge_fixup to split_page_memcg Message-ID: References: <20210304074053.65527-1-zhouguanghui1@huawei.com> <20210304074053.65527-2-zhouguanghui1@huawei.com> <3ad50842-881f-eb88-a14d-0b6c70ce33d2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ad50842-881f-eb88-a14d-0b6c70ce33d2@gmail.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 27D852000390 X-Stat-Signature: oet537rttkaob44ru1f4zhr5483esrfh Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615278508-214519 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 09-03-21 09:37:29, Balbir Singh wrote: > On 4/3/21 6:40 pm, Zhou Guanghui wrote: [...] > > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > /* > > - * Because page_memcg(head) is not set on compound tails, set it now. > > + * Because page_memcg(head) is not set on tails, set it now. > > */ > > -void mem_cgroup_split_huge_fixup(struct page *head) > > +void split_page_memcg(struct page *head, unsigned int nr) > > { > > Do we need input validation on nr? Can nr be aribtrary or can we enforce > > VM_BUG_ON(!is_power_of_2(nr)); In practice this will be power of 2 but why should we bother to sanitze that? -- Michal Hocko SUSE Labs