From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 234FDC433E0 for ; Mon, 8 Mar 2021 22:30:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B1E4B65275 for ; Mon, 8 Mar 2021 22:29:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1E4B65275 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 180158D0081; Mon, 8 Mar 2021 17:29:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 130CE8D007F; Mon, 8 Mar 2021 17:29:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEBBA8D0081; Mon, 8 Mar 2021 17:29:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id CEDE58D007F for ; Mon, 8 Mar 2021 17:29:58 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8999B824999B for ; Mon, 8 Mar 2021 22:29:58 +0000 (UTC) X-FDA: 77898150876.16.63C2E54 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf11.hostedemail.com (Postfix) with ESMTP id 040332000392 for ; Mon, 8 Mar 2021 22:29:53 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id a188so8154818pfb.4 for ; Mon, 08 Mar 2021 14:29:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Sh5lfCQe/1CSXBegypH5sfoEf89f8bD5kkTOkHnpdnw=; b=D7Lg6Gqfum3Yoo0KBIU2pzN4yxEjJCWB8cwDzoLeeJEVI3cHiC9kREuZMHGlpzQU0N uoptM6any9yo7t6XfGdG0uS0HGWUMzdKVQSGxmFimzrj9hjmWmrKk2kDSCJkl+ZqpvZ8 3lrpZRtpS9+n5PPqUrxopGKXYMKIie6biESEZKwjA8MpVLqNsw+2V1iL5V/KmAmXNhyo IXjfL9Mo/gUENLkKEvGoAoYmyBhLS5W7ExEjJgLJSMPVe7fGYtMlech3yWgnLCRo+Nk0 Nvrsn+6W7E26DqIAY8KJz3fsSJXKNVfymoawolfBBpDBixmLzTh37TB+sjsiwrDmPOmM KhFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=Sh5lfCQe/1CSXBegypH5sfoEf89f8bD5kkTOkHnpdnw=; b=fWAtjvM1Jlq2lyWbXu7D9ZokEElj6Pzy7ls5oE5lECbdq2IznyWdH5Vg+0lfL3Ppwu xfalTXz27EULQmn/fknM27MhwXxmMwbnqikKB9SMPljWGKNHkLh3wQOBkvF3YJp5QQmZ R65IzmRPthx/bqtPQGzPzLfUh+nZJ//2QwfWtxMEPknowgmgSBely+POehiKnt8wuZcO oZYhFvcfL0FmYzsZJKHwi7/K4YkVITQCZRhpjtt4FddI6DWAYfX8e3pKhE7Jrd5yMg8N RYQYuTYgcLeKtW9lY1Lc3aEOuxM4k80vPoZ445pR/BAz3A5q8fHy/kNlPS2JfNSP/JuH T4hg== X-Gm-Message-State: AOAM531jl1QSpj1bNdIVMzhL6Qy9XIJq1EQ79GBur8/CXkSWWph5zqbq tdjFe4BZs1CahNtJ5b/6T+g= X-Google-Smtp-Source: ABdhPJxeocRilqyTmKL1i8h7ADYciQ2bbVMZ/l4r1ThOWuSVgqveoHZh7JKVSQcDo3eXjC1OEtqP7A== X-Received: by 2002:a62:62c2:0:b029:1ee:1e3f:1b68 with SMTP id w185-20020a6262c20000b02901ee1e3f1b68mr22388338pfb.25.1615242597146; Mon, 08 Mar 2021 14:29:57 -0800 (PST) Received: from google.com ([2620:15c:211:201:4ccc:acdd:25da:14d1]) by smtp.gmail.com with ESMTPSA id h23sm11074745pfn.118.2021.03.08.14.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 14:29:56 -0800 (PST) Date: Mon, 8 Mar 2021 14:29:53 -0800 From: Minchan Kim To: kernel test robot Cc: Andrew Morton , kbuild-all@01.org, Linux Memory Management List , LKML , John Dias , Michal Hocko , David Hildenbrand , Jason Baron Subject: Re: [PATCH v2] mm: page_alloc: dump migrate-failed pages Message-ID: References: <20210308202047.1903802-1-minchan@kernel.org> <202103090555.LtLPf1Ho-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202103090555.LtLPf1Ho-lkp@intel.com> X-Stat-Signature: t4isj7wqybyjkp9jrit3bhpotog3jk4n X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 040332000392 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail-pf1-f171.google.com; client-ip=209.85.210.171 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615242593-741545 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 09, 2021 at 05:29:30AM +0800, kernel test robot wrote: > Hi Minchan, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on hnaz-linux-mm/master] > > url: https://github.com/0day-ci/linux/commits/Minchan-Kim/mm-page_alloc-dump-migrate-failed-pages/20210309-042205 > base: https://github.com/hnaz/linux-mm master > config: m68k-allmodconfig (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/3c635af37b862e9c601ee8d5818f7da9cd3e2e57 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Minchan-Kim/mm-page_alloc-dump-migrate-failed-pages/20210309-042205 > git checkout 3c635af37b862e9c601ee8d5818f7da9cd3e2e57 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] > 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) > | ^~ > include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' > 78 | # define unlikely(x) __builtin_expect(!!(x), 0) > | ^ > include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' > 143 | BUG_ON(!virt_addr_valid(buf)); > | ^~~~~~ > include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' > 143 | BUG_ON(!virt_addr_valid(buf)); > | ^~~~~~~~~~~~~~~ > In file included from arch/m68k/include/asm/page.h:60, > from arch/m68k/include/asm/thread_info.h:6, > from include/linux/thread_info.h:38, > from include/asm-generic/preempt.h:5, > from ./arch/m68k/include/generated/asm/preempt.h:1, > from include/linux/preempt.h:78, > from include/linux/spinlock.h:51, > from include/linux/mmzone.h:8, > from include/linux/gfp.h:6, > from include/linux/mm.h:10, > from mm/page_alloc.c:19: I am not sure this is triggered by the patch since I could see the warn with reverting the patch.