From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46786C433DB for ; Fri, 5 Mar 2021 21:00:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 869C96509B for ; Fri, 5 Mar 2021 21:00:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 869C96509B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D693E6B0006; Fri, 5 Mar 2021 16:00:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D197C6B006C; Fri, 5 Mar 2021 16:00:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6AF06B006E; Fri, 5 Mar 2021 16:00:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 968336B0006 for ; Fri, 5 Mar 2021 16:00:22 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 54B156103 for ; Fri, 5 Mar 2021 21:00:22 +0000 (UTC) X-FDA: 77887038684.04.3A3714A Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf16.hostedemail.com (Postfix) with ESMTP id DA01D80192FB for ; Fri, 5 Mar 2021 21:00:20 +0000 (UTC) Received: by mail-qk1-f170.google.com with SMTP id f124so3419100qkj.5 for ; Fri, 05 Mar 2021 13:00:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=La3mwDa8nISUh2U9bi9oHzPu358czH3TeQ0ByYgJZqY=; b=VfhA/pXDD661QUgX1Mxa4DhK6hKrLISfubA84eRcP5m7HrACNGN9aEnYTpgLPqDTKl g4TbBNYRDsU/94H2jOc7T/WxPyFqm19l9G7+Q1geXVCnQcSU5+0ssJYshieCtlZBKv8G ZhfXtpPkowYLxrCPZDBq+iHGWe+2Ke52zeeoRbeMAElVHx7F1isMeyzGcS7h/D6oaDkV Ro/dMjTsOIUEVp7J0fkdOfo9OM7pFGQuyPmXZK2etHIsJqi+AAuIWwkhelx/s2kSoHn5 0GHaF5UMUWdWwHNA8bAi9C2HW1FxI9M8Ef6GARBBntVKOnNojeQRWUUzzV0DCeMyIcnc o4Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=La3mwDa8nISUh2U9bi9oHzPu358czH3TeQ0ByYgJZqY=; b=lbd3cGg+0nzK/Y8hvIbLC7OsEsMS84QrnNORvZXzAK5cC3Jp4cREDEpfkg69v3RVXn iCfag5YRPZ1e4mp9XiOWqaYLI9gBY0jAXAPZVafK27HAFNd3zGPV9B3qzYYCgEBzyMKG 3LCEHz7pZSKWshOoJnCOVCp4ZdLvhr3ph4Yhi6GvRD9d0a1gc1xzkUq55mSck/vzbx3H hJ/0ZV+EJDP8HOK0vwZ4Akx10L+24kfpQ2tfNAJwbL4GUi9Z04r7sWAnvw5odJjsb3M8 WfrMyKMmuM6I3cGpRRbgvPC95Fsd9rbKz4hrhL6sczHCZbyx64BfCJn7IxejjiJRHdvV idTQ== X-Gm-Message-State: AOAM532Eh///BdzDp6IFGGyzk7yz28uTGAQx/XBIuBlmel7UT+tHlmFN vSuGETO5N/ZYCqsOmCpH9TkdEQ== X-Google-Smtp-Source: ABdhPJxzOw3dJnmPVcIA9UuDAQ5evSE+9f2gbj+kUUGfQGp8XckRO4m6bZqcEJymjnerKacRpyQ5iA== X-Received: by 2002:a05:620a:108f:: with SMTP id g15mr11227500qkk.298.1614978020436; Fri, 05 Mar 2021 13:00:20 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id h75sm2653603qke.80.2021.03.05.13.00.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 13:00:19 -0800 (PST) Date: Fri, 5 Mar 2021 16:00:19 -0500 From: Johannes Weiner To: Shakeel Butt Cc: Hugh Dickins , Roman Gushchin , Michal Hocko , Andrew Morton , Cgroups , Linux MM , LKML Subject: Re: [PATCH v3] memcg: charge before adding to swapcache on swapin Message-ID: References: <20210304014229.521351-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DA01D80192FB X-Stat-Signature: ayhudzs79h8madbe5qienqze96rbpdcz Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail-qk1-f170.google.com; client-ip=209.85.222.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614978020-291739 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 05, 2021 at 08:42:00AM -0800, Shakeel Butt wrote: > On Fri, Mar 5, 2021 at 8:25 AM Johannes Weiner wrote: > > > [...] > > I'd also rename cgroup_memory_noswap to cgroup_swapaccount - to match > > the commandline and (hopefully) make a bit clearer what it effects. > > Do we really need to keep supporting "swapaccount=0"? Is swap > page_counter really a performance issue for systems with memcg and > swap? To me, deprecating "swapaccount=0" simplifies already > complicated code. Now that you mention it, it's probably really not worth it. I'll replace my cleanup patch with a removal patch that eliminates everything behind swapaccount= except for a deprecation warning...