From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23372C433DB for ; Thu, 4 Mar 2021 16:59:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F42C64F5F for ; Thu, 4 Mar 2021 16:59:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F42C64F5F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD3786B0005; Thu, 4 Mar 2021 11:58:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C82BA6B0008; Thu, 4 Mar 2021 11:58:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4A526B000D; Thu, 4 Mar 2021 11:58:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 976386B0005 for ; Thu, 4 Mar 2021 11:58:59 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 48B0E180AE811 for ; Thu, 4 Mar 2021 16:58:59 +0000 (UTC) X-FDA: 77882801598.02.BC0A2A0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP id A5855C0001EE for ; Thu, 4 Mar 2021 16:58:52 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9743664F59; Thu, 4 Mar 2021 16:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614877132; bh=ogPCAqUrJsPTWID/+dxg64jg17NrKa1OqVqf+iKrOZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NTZ3MuTBdv2veyQJULk1auCEomEWtDBdbyrLSq0BDydjsVqcw1S5s+cUazQWv2KOF mvdM+ix6BlFX6MGTXuAtyLWIQdwB6iog+zJeKWIY8ssps30imD+UnKwNIRqL27k+8V xoczlHPXSUEmp3BpnZu2FKYuD3aUjNtwiNZRf1Ro= Date: Thu, 4 Mar 2021 17:58:49 +0100 From: Greg Kroah-Hartman To: Anthony Iliopoulos Cc: Jens Axboe , Andrew Morton , Matthew Wilcox , stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH STABLE 5.10 5.11] swap: fix swapfile page to sector mapping Message-ID: References: <20210304150824.29878-1-ailiop@suse.com> <20210304150824.29878-5-ailiop@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 98peb9nzh9fzwh8b5rht9o7xmun5zraq X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A5855C0001EE Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614877132-321539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 04, 2021 at 05:30:00PM +0100, Anthony Iliopoulos wrote: > On Thu, Mar 04, 2021 at 04:16:26PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 04, 2021 at 04:08:24PM +0100, Anthony Iliopoulos wrote: > > > commit caf6912f3f4af7232340d500a4a2008f81b93f14 upstream. > > > > No, this does not look like that commit. > > > > Why can I not just take caf6912f3f4a ("swap: fix swapfile read/write > > offset") directly for 5.10 and 5.11? WHat has changed to prevent that? > > You're right of course, the upstream fix applies even on v5.4 so you > could just take it directly for those branches if this is preferable. But, that commit says it fixes 48d15436fde6 ("mm: remove get_swap_bio"), which is NOT what you are saying here in these patches. So which is it? Is there a problem in 5.11 and older kernels (48d15436fde6 ("mm: remove get_swap_bio") showed up in 5.12-rc1), that requires this fix, or is there nothing needed to be backported? As a note, I've been running swapfiles on 5.11 and earlier just fine for a very long time now, so is this really an issue? confused, greg k-h