From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D8B1C433DB for ; Thu, 4 Mar 2021 10:41:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACA9264F3A for ; Thu, 4 Mar 2021 10:41:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACA9264F3A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 317C76B0005; Thu, 4 Mar 2021 05:41:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C8DC6B0006; Thu, 4 Mar 2021 05:41:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 191246B0007; Thu, 4 Mar 2021 05:41:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id 002EC6B0005 for ; Thu, 4 Mar 2021 05:41:10 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BC76B68A1 for ; Thu, 4 Mar 2021 10:41:10 +0000 (UTC) X-FDA: 77881849500.05.03BDE35 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf19.hostedemail.com (Postfix) with ESMTP id C079D90009F0 for ; Thu, 4 Mar 2021 10:41:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E779DAAC5; Thu, 4 Mar 2021 10:41:08 +0000 (UTC) Date: Thu, 4 Mar 2021 11:41:06 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Mike Kravetz , Muchun Song , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm: Make alloc_contig_range handle free hugetlb pages Message-ID: References: <20210222135137.25717-1-osalvador@suse.de> <20210222135137.25717-2-osalvador@suse.de> <3f071dd4-3181-f4e0-fd56-1a70f6ac72fe@redhat.com> <4ede47fd-d01e-6d9c-288a-2ec97b5392af@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ede47fd-d01e-6d9c-288a-2ec97b5392af@redhat.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C079D90009F0 X-Stat-Signature: 84xtdn4do8whkct1nmp3d6qtr1n5pmxb Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1614854469-311906 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 04, 2021 at 11:32:29AM +0100, David Hildenbrand wrote: > I think this is now the second fatal error we can have (-EINTR, -ENOMEM), > thus the current interface (return "NULL" on fatal errros) no longer works > properly. > > No strong opinion about fixing this up on top - could be it's cleaner to > just do it right away. Ok, I see. Then I will start working on that in v4. Any more feedback to either patch#1 or patch#2? Thanks! -- Oscar Salvador SUSE L3