From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A879C433E0 for ; Mon, 15 Mar 2021 00:52:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 993FD64E1F for ; Mon, 15 Mar 2021 00:52:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 993FD64E1F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E98F76B006C; Sun, 14 Mar 2021 20:52:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E71426B006E; Sun, 14 Mar 2021 20:52:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D101A6B0070; Sun, 14 Mar 2021 20:52:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id B9CE76B006C for ; Sun, 14 Mar 2021 20:52:34 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7EDA21E14 for ; Mon, 15 Mar 2021 00:52:34 +0000 (UTC) X-FDA: 77920283028.11.9FB5692 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 17589C0007C2 for ; Mon, 15 Mar 2021 00:52:33 +0000 (UTC) Received: by mail-il1-f172.google.com with SMTP id e7so7840469ile.7 for ; Sun, 14 Mar 2021 17:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Zc50leSX2oieymemRjcX1In4Wa04eq4VV3W1lZ9TsKU=; b=giFIm+IxQarWD5opEWon9FvSYpKP+CsgV1c3/qcHH14QnszSL3GG7RZb19uknDZl9m QkeWCQeHkk3joLKBKaYcuwQUBgVbkeZ5DF9dGu68YTfFSIiZwPpBh5hGmPvZOnduRFjr URmeEdq4q1IFZw7X6tfcOXYw6qBg0wikhjrcoDk1lRbgYEsTMzVEuOnmt6m+rq9mxDI/ CU9mH92LL8u2jhe4wxHeVpusoC1k0WgdbzI8bpXsowYbMHfZJct5yIIU6ThnvuYoHyeR vZQVeFe04ZFxbOCb2l5AJoT9Tpagi4PV01N55yWGxmyhfkKCZ2vgRmA/GiyTQEuhqzfl HnTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Zc50leSX2oieymemRjcX1In4Wa04eq4VV3W1lZ9TsKU=; b=I72E6OrFzqiZY7EwVFbI0KgMcDvqeqJKTNacsaaOBvICoDOVDXn/MUu9sPMW9ScXOt CEh1vKlpKl8/R4qWBPVMkthgSMdtUnQX2YLAgepyjqqE9ISmoVtMORRrhDM6l5RtKzYp 1oSiKPnNtSvcurqVz83Wh28WgDwaoiok2I7/uL9mgDkC3nNSvHZPC78qahdFll9wR4Aj 60c+IWx0CUX2ZLPqxsGRwi9Ht7bo/pzz6EUDXOAZWw2HBBJTYDRp0KjttC+DdLk4vKkD 5tc4iPDhvdEwY88wVgezE1MPh9PqeTLQIRRYy/fwNQlD56ZX1/0/Euu/pD4bpJM9/hea 7kZw== X-Gm-Message-State: AOAM532KT8GgmHzawr+Ddmm14TkgHRd8CRZrtbHBh+PLwby16ukRKBCR 0EObrWKGcEnNRItEX+fx0YSFvw== X-Google-Smtp-Source: ABdhPJxGO1gE3oyXjD8B7ZlEPhyrulhBec6YpXJQLlrbYpp9OhyiGd7pL/PNtz4PHfIa2qUmiO2vrA== X-Received: by 2002:a05:6e02:f90:: with SMTP id v16mr9694973ilo.294.1615769553344; Sun, 14 Mar 2021 17:52:33 -0700 (PDT) Received: from google.com ([2620:15c:183:200:4d84:eb70:5c32:32b8]) by smtp.gmail.com with ESMTPSA id c18sm7091908ild.37.2021.03.14.17.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Mar 2021 17:52:32 -0700 (PDT) Date: Sun, 14 Mar 2021 18:52:28 -0600 From: Yu Zhao To: Zi Yan Cc: linux-mm@kvack.org, Alex Shi , Andrew Morton , Dave Hansen , Hillf Danton , Johannes Weiner , Joonsoo Kim , Matthew Wilcox , Mel Gorman , Michal Hocko , Roman Gushchin , Vlastimil Babka , Wei Yang , Yang Shi , Ying Huang , linux-kernel@vger.kernel.org, page-reclaim@google.com Subject: Re: [PATCH v1 00/14] Multigenerational LRU Message-ID: References: <20210313075747.3781593-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: zojfgtyid4gkxaac4d5irjuwjr9amb83 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 17589C0007C2 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail-il1-f172.google.com; client-ip=209.85.166.172 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615769553-521732 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 14, 2021 at 06:48:17PM -0400, Zi Yan wrote: > On 13 Mar 2021, at 2:57, Yu Zhao wrote: > > Problems > > ======== > > 31.03% page_vma_mapped_walk > > 25.59% lzo1x_1_do_compress > > 4.63% do_raw_spin_lock > > 3.89% vma_interval_tree_iter_next > > 3.33% vma_interval_tree_subtree_search > > Solutions > > ========= > > 49.36% lzo1x_1_do_compress > > 4.54% page_vma_mapped_walk > > 4.45% memset_erms > > 3.47% walk_pte_range > > 2.88% zram_bvec_rw > > Is this profile from a system with this patchset applied or not? > Do you mind sharing some profiling data with before and after applying > the patchset? So it would be easier to see the improvement brought by > this patchset. I've snipped everything else to make the context more clear. These two kswapd profiles were collected under roughly the same memory pressure. In other words, kswapd reclaimed (compressed) about the same number of pages and therefore spent about the same amount of CPU time in lzo1x_1_do_compress() in each profile. The percentages of lzo1x_1_do_compress() are different because the total CPU usage are different. Dividing the second percentage by the first, we know we have roughly cut kswapd CPU usage by half. > Are there any performance numbers for specific application (before and > after applying the patches) you can show to demonstrate the improvement? The kswapd profiles are from Chrome OS, i.e., laptops running the v5.11 kernel and the Chrome browser. And we've also collected benchmarks from various workloads on servers and phones running older kernel versions too. Do you have a platform in mind? I'd be happy to share the data with you. Or if you have some workloads/benchmarks, I could collect some numbers from them too.