From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E16C433E0 for ; Fri, 26 Feb 2021 14:33:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EC0A64EED for ; Fri, 26 Feb 2021 14:33:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EC0A64EED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 797446B006E; Fri, 26 Feb 2021 09:33:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 746EC6B0072; Fri, 26 Feb 2021 09:33:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C29B6B0073; Fri, 26 Feb 2021 09:33:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 4318D6B006E for ; Fri, 26 Feb 2021 09:33:41 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F19DA6121 for ; Fri, 26 Feb 2021 14:33:40 +0000 (UTC) X-FDA: 77860662600.10.AE7B34A Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf23.hostedemail.com (Postfix) with ESMTP id 34921A0004D5 for ; Fri, 26 Feb 2021 14:33:38 +0000 (UTC) Received: by mail-wr1-f51.google.com with SMTP id r3so8770695wro.9 for ; Fri, 26 Feb 2021 06:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IhezNL16J7Th24xbSsx4YTV98HHNpYtn/0HBhefr0V4=; b=eslLXHut7tNA3RhWZmCcUY1v+p6KPXdk9Fi5tCTXMsDAPV/2mJjIC8LHuceGvSbA6K oxcCxlWgyq/Kzqlnzwm54bww0IFxJIg/I2c8u1i1g2Jt0SnA/9d1zY+nGODBXlC+j3WA S9tw3Dzt6Jq/2NN5KM/HE7b+O8S2QQOae8nBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IhezNL16J7Th24xbSsx4YTV98HHNpYtn/0HBhefr0V4=; b=VTZCB9iF5ZOn93i7ieh8fSt7Lvq4ePrgIzW1FamWpst0Wa53G6ZiT8U2P67MMM/6wZ q43CUKf3vDDkAu6CNjte0XfmAywN1+hzabSx4n4Y5TAGcOMdDKHQlVidPhWfqE3PhzyI qg3kkuWhgM4kfNySysQobS7WEH1V6RewbAUrmCHjyF7/FGagvdVFjNU0ZFdRhfYxCwDD rWNV8cm8mQ/i4IUTnYjbh0AivEHAFQe/ZLwwckDzS01Vw2re14+qtfVRUiWXSf3nOo2c d3Cw7/GIkI8rz+ewvu/oiCJVM7Gfh5b6nyicvUot9NDT6dAiHSM7Z5uc64g65ulsH6pL 6z2w== X-Gm-Message-State: AOAM533dSyLd8FGKiH4WYSzk4KIoc6sH96WQUniiRYAdtRgf1QDV8j6B 1mm8bIRbBWIdDVQ+QrBQJ2DO9Q== X-Google-Smtp-Source: ABdhPJwDK3CF3SWBwEUCcV2yoITN/VX/sNO223Q6WaZadO5gz8/IYFES7//jVGgasK4kXjrj+ZXMHw== X-Received: by 2002:a05:6000:18a3:: with SMTP id b3mr3551877wri.373.1614350017275; Fri, 26 Feb 2021 06:33:37 -0800 (PST) Received: from localhost ([2620:10d:c093:400::4:87b5]) by smtp.gmail.com with ESMTPSA id l15sm6422733wru.38.2021.02.26.06.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Feb 2021 06:33:37 -0800 (PST) Date: Fri, 26 Feb 2021 14:33:36 +0000 From: Chris Down To: Yang Shi Cc: hannes@cmpxchg.org, mhocko@suse.com, guro@fb.com, shakeelb@google.com, akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] doc: memcontrol: add description for oom_kill Message-ID: References: <20210226021254.3980-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210226021254.3980-1-shy828301@gmail.com> User-Agent: Mutt/2.0.5 (da5e3282) (2021-01-21) X-Stat-Signature: 15gbftn8fq8gz59ug771jyeqwz9s68is X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 34921A0004D5 Received-SPF: none (chrisdown.name>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail-wr1-f51.google.com; client-ip=209.85.221.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614350018-265497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yang Shi writes: >When debugging an oom issue, I found the oom_kill counter of memcg is >confusing. At the first glance without checking document, I thought it >just counts for memcg oom, but it turns out it counts both global and >memcg oom. > >The cgroup v2 documents it, but the description is missed for cgroup v1. > >Signed-off-by: Yang Shi Thanks. Acked-by: Chris Down >--- > Documentation/admin-guide/cgroup-v1/memory.rst | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst >index 0936412e044e..44d5429636e2 100644 >--- a/Documentation/admin-guide/cgroup-v1/memory.rst >+++ b/Documentation/admin-guide/cgroup-v1/memory.rst >@@ -851,6 +851,9 @@ At reading, current status of OOM is shown. > (if 1, oom-killer is disabled) > - under_oom 0 or 1 > (if 1, the memory cgroup is under OOM, tasks may be stopped.) >+ - oom_kill integer counter >+ The number of processes belonging to this cgroup killed by any >+ kind of OOM killer. > > 11. Memory Pressure > =================== >-- >2.26.2 > >