From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C364EC433E0 for ; Fri, 26 Feb 2021 13:15:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 449EF64EE2 for ; Fri, 26 Feb 2021 13:14:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 449EF64EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8B3466B0005; Fri, 26 Feb 2021 08:14:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8637A6B0006; Fri, 26 Feb 2021 08:14:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7512E6B006C; Fri, 26 Feb 2021 08:14:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 5C8746B0005 for ; Fri, 26 Feb 2021 08:14:58 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2DDA412E5 for ; Fri, 26 Feb 2021 13:14:58 +0000 (UTC) X-FDA: 77860464276.06.76A0A38 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf23.hostedemail.com (Postfix) with ESMTP id 59CC9A0000FF for ; Fri, 26 Feb 2021 13:14:57 +0000 (UTC) Received: by mail-wm1-f44.google.com with SMTP id o16so7769118wmh.0 for ; Fri, 26 Feb 2021 05:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XxDrSAz+s0u9GghMJmZiJqB1we4OdhhnM7uHXW+NNPE=; b=ktc1OuuclGHmKXvMLlLD6jYnuTewLQk7HEJiXkEJ5+Rj8HE0Xm2Ym75TsHFXjMBTCc z415izJUnuxOB9AejmcZK0UuVd7gzPLIfDljK4sg7yVLVYwaytbFUFNHftoyNGkEiR91 N2pf6b2h+7lJzLhkiAQGEL4oSTlDNLG7sgC4M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XxDrSAz+s0u9GghMJmZiJqB1we4OdhhnM7uHXW+NNPE=; b=tAXvKvDjjs2AfftT1hxGEq8lrk2JvpfxzBdggysngvsCG+RLdaE/GNaRUEddzNueer 7tOwKmTEhDsC9/zNMtHRejtjm5TSwmR7iW+eCoAaF06NUa7j5iQTwE7N6x3HM5BSizno zUEbDLFE5ct/irUHghfVEwFLanDmlGy+m6wnj0rlOQf6SXFRJmT6vEx2SBQagypI96LX tZfvAVY4TCL2yH3G7a2nDu9BqTw3ZyTJkNECg67o+RI3H7xku/IyjLVJhCDQ8g6IwrLR 7dzWLhhPTDtL1x8gjNbvWfnJHJIap6a/HiwJ0qMVMa5EgNPHaErpeNjHLiY8uovTdAtV n1Ag== X-Gm-Message-State: AOAM531WhDvWoVhxbrBarUYPGAU19Sx42OuVB6m/kadb7hc6AHjtdHbS 0SN5ZSSG0+u4Kys0yLo07BNwlw== X-Google-Smtp-Source: ABdhPJx11ViKkHeTCGdq24CUxuZuIoHqBbIapPfsx41pNzZU0pPcPNM6MKdfoXlH0CeMaH26vgT3tQ== X-Received: by 2002:a1c:f20f:: with SMTP id s15mr2796384wmc.35.1614345296506; Fri, 26 Feb 2021 05:14:56 -0800 (PST) Received: from localhost ([2620:10d:c093:400::4:87b5]) by smtp.gmail.com with ESMTPSA id p18sm1584342wro.18.2021.02.26.05.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Feb 2021 05:14:56 -0800 (PST) Date: Fri, 26 Feb 2021 13:14:55 +0000 From: Chris Down To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] ia64: Depend on non-static printk for cmpxchg debug Message-ID: References: <20210226130029.GC2723601@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210226130029.GC2723601@casper.infradead.org> User-Agent: Mutt/2.0.5 (da5e3282) (2021-01-21) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 59CC9A0000FF X-Stat-Signature: utpn3xjbzrxuj4jgruzc5azxb941go68 Received-SPF: none (chrisdown.name>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail-wm1-f44.google.com; client-ip=209.85.128.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614345297-560304 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox writes: >Why not just fix it? > >diff --git a/arch/ia64/include/uapi/asm/cmpxchg.h b/arch/ia64/include/uapi/asm/cmpxchg.h >index 5d90307fd6e0..d955a8e3ebde 100644 >--- a/arch/ia64/include/uapi/asm/cmpxchg.h >+++ b/arch/ia64/include/uapi/asm/cmpxchg.h >@@ -139,7 +139,7 @@ extern long ia64_cmpxchg_called_with_bad_pointer(void); > do { \ > if (_cmpxchg_bugcheck_count-- <= 0) { \ > void *ip; \ >- extern int printk(const char *fmt, ...); \ >+ int printk(const char *fmt, ...); \ > ip = (void *) ia64_getreg(_IA64_REG_IP); \ > printk("CMPXCHG_BUGCHECK: stuck at %p on word %p\n", ip, (v));\ > break; \ I must confess I have no idea of the history of why it was `extern int` in the first place -- my fear was somehow we use cmpxchg.h from a different context. Do you have any idea? :-)