From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFF0C433E0 for ; Thu, 25 Feb 2021 04:33:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E0F764ECE for ; Thu, 25 Feb 2021 04:33:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E0F764ECE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C08636B0006; Wed, 24 Feb 2021 23:32:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB78E6B006C; Wed, 24 Feb 2021 23:32:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7F056B006E; Wed, 24 Feb 2021 23:32:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 8E75C6B0006 for ; Wed, 24 Feb 2021 23:32:59 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5204A8167361 for ; Thu, 25 Feb 2021 04:32:59 +0000 (UTC) X-FDA: 77855520078.10.271A3FB Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 46DE180192C6 for ; Thu, 25 Feb 2021 04:32:47 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id d11so2501464plo.8 for ; Wed, 24 Feb 2021 20:32:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ksjOCtJ0nuu5aqjShvr266w7TXx5g4TaGEaQoeTbXfo=; b=ip4GM9wxAb9xv375Nqpbu1+mSvZw2nCzmYBxVyqCJXSx0HEbk1bCThuCIXdwzIJlB3 PsOnD71/w9p7LkOKrskeYQCM5m1n8IXa7n5erFZ2HwdhNCv/DZZVoC59GwvYHKyLoq0P NvJltsXOGhy1FXlpbwVQrUGVWx6xzKB6PqCyS9IK6XGm7eWPotUMQafT7R0aZKw8JXzA wuBz0cxWznshnnNuEGj1zwuqREAkQC56RNzxMm11M0685r80nx0Rr7noxzFKXXvVX8m4 wQYg+pXz9B0lPmt7ARZUQDewhrkXshAzHIeruNTAgXJIApUCixVLrYJaH7ba23B+Zk0m b8dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ksjOCtJ0nuu5aqjShvr266w7TXx5g4TaGEaQoeTbXfo=; b=kgmt/9rgFBnZCGIkMYFzn49vBeUrij4den/TOONYZwbC1DRZgvQqVjyhXa/+L0Wnx9 WSWIWO2dkz366j+Cq1OpriCeVUoMrmF4mhr3Tdq5UBbr+RvIrnChSPu99TDfK6FYluzT dvuaf5ak8bPXuzIWh5eigSATXC0DjXkzqouR+cmCgJ2jhltwX9CUfON6q1paq0LdFeSN JQitIO19iVwOEhLn6qBNlm8SCQA5rj0Yrg+3UZlmiUtmlfu7QljWUIPop6D5EG1+uyuC PAmXi73JxItmwFWRa5AoGoyUOrHB54q/Et87Z83zFQynP0N9HBdKvSkcvYczVtdAzaNV LMaA== X-Gm-Message-State: AOAM5332Q8QHzDqwceWGowwg+WxrawNeJ9Uz0jpQcFTCX7r3R+NiQgsg 0hntZssHPfTVqr2o2fZEFoY= X-Google-Smtp-Source: ABdhPJyPwVMcqUaFUrEW3dUmCarbud+mGcEnTBHX8+oDBeJeF3sugARwq0y2DK88gTOvxadtZ9wh4w== X-Received: by 2002:a17:90a:7e0a:: with SMTP id i10mr1354443pjl.152.1614227577882; Wed, 24 Feb 2021 20:32:57 -0800 (PST) Received: from google.com ([2620:15c:202:201:552:720f:2933:5745]) by smtp.gmail.com with ESMTPSA id z16sm3978894pgj.51.2021.02.24.20.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 20:32:56 -0800 (PST) Date: Wed, 24 Feb 2021 20:32:54 -0800 From: Dmitry Torokhov To: Chris Ye Cc: Chris Ye , linux-mm@kvack.org, linux-kernel@vger.kernel.org, trivial@kernel.org, kernel-team@android.com Subject: Re: [PATCH] Input: Add "Share" button to Microsoft Xbox One controller. Message-ID: References: <20210225040032.684590-1-lzye@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225040032.684590-1-lzye@google.com> X-Stat-Signature: dxd3j9hwjzn965rwjwuxak45debknxcs X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 46DE180192C6 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail-pl1-f172.google.com; client-ip=209.85.214.172 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614227567-201646 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Chris, On Thu, Feb 25, 2021 at 04:00:32AM +0000, Chris Ye wrote: > Add "Share" button input capability and input event mapping for > Microsoft Xbox One controller. > Fixed Microsoft Xbox One controller share button not working under USB > connection. > > Signed-off-by: Chris Ye > --- > drivers/input/joystick/xpad.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > index 9f0d07dcbf06..08c3e93ccb2f 100644 > --- a/drivers/input/joystick/xpad.c > +++ b/drivers/input/joystick/xpad.c > @@ -368,6 +368,14 @@ static const signed short xpad360_btn[] = { /* buttons for x360 controller */ > -1 > }; > > +static const signed short xpad_xboxone_btn[] = { > + /* buttons for xbox one controller */ > + BTN_TL, BTN_TR, /* Button LB/RB */ > + BTN_MODE, /* The big X button */ > + KEY_RECORD, /* The share button */ If I understand this correctly, not all Xbox One controllers have this new key. Is it possible to determine if it is present and only set capability for controllers that actually have it? Also, I am unsure if KEY_RECORD is the best keycode for this. It might, but does your controller supports bluetooth? What HID usage code does it send for this key? Thanks. -- Dmitry