From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E571C433DB for ; Wed, 24 Feb 2021 20:41:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9ED6264E09 for ; Wed, 24 Feb 2021 20:41:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ED6264E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 173926B0005; Wed, 24 Feb 2021 15:41:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FD426B0006; Wed, 24 Feb 2021 15:41:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 039D46B006C; Wed, 24 Feb 2021 15:41:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id E1DEB6B0005 for ; Wed, 24 Feb 2021 15:41:46 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id ABEFD184FFF16 for ; Wed, 24 Feb 2021 20:41:46 +0000 (UTC) X-FDA: 77854332612.07.16F6913 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf03.hostedemail.com (Postfix) with ESMTP id 42A63C0007D0 for ; Wed, 24 Feb 2021 20:41:43 +0000 (UTC) Received: by mail-qk1-f174.google.com with SMTP id w19so3530718qki.13 for ; Wed, 24 Feb 2021 12:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EwNM4IQrP65m3pBxQdPq3PIkStWcpBTasxWsf7+C0lo=; b=oynA0tAUXRRCGRxkmQGoFtzMRLvf+22xVNOkpXfaZ3ShiECJzsBik78xQsBCe2C7Ey uv/GVxd8ChE9O5nHMvqVZBh+PuvvYDYAENDW5HjbHyecOl9ca+i361mperXkFpE/ckHp AbJGwXquplMfFHdrnYcGkVAYrgUneo/hCd91ApPj9Fe/mDlLz3fNjPoou6lbl+UPqc26 LoT5jV/vczsQTsBXcNmR1HX7Xqu3ITA//sVu5lz8AM1TIivwA9pWY1IrRD+of6J0s4lE SRKdT2CGdxuUGNRCrXK5YBk4EyH3UAVXqS/agvlVNAUqVFt2Q9cT27TzExcL7mR0aJFt je4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EwNM4IQrP65m3pBxQdPq3PIkStWcpBTasxWsf7+C0lo=; b=QNp3DIOE8TPGwLhrJXWbmsEBoc2uo7SLRoMX96j7SIBwN8xYE2A6yCJoN0qblHoEcp /7IrXqb6+Xo8h8WUbhh1j3FwlmgyFQAjFpWaZU1oCJKOoI8Po0rcgMIjWaDuNO4/ZiSx DYudwn5ebc4CVszCxWahU2jJigenDAR1LaxDcsrjUx/9DXLSb+J5Q8dp+OoQX0rCl8e8 XUqQpGBqIHhJy+eFALY+2RAlOFrlvlhqPb3GzquTx0uNxaugEjwrIeGAPvOL1Iaqbce2 sfUtkt8O1wzrdu01fKQugACY5uyrTvWm8Tb+/cAwVRftYXGvFtDtjlrT3mskqNh2k68d +S+Q== X-Gm-Message-State: AOAM531a3tXr4rbXYBdKBQjfm0y1Vo0f+7mYZP84Iy49ZK88zBlcb36z 0YO0u/XxHT/hVODJexj6bqD2yg== X-Google-Smtp-Source: ABdhPJzPS1yWCPSlG7/+kI7/ZUfr3RkdEDSt24AmwG/AErCzG1jrWZb7GS3fFAgUS97mURwqQfPsCw== X-Received: by 2002:a37:4d09:: with SMTP id a9mr17091263qkb.469.1614199305734; Wed, 24 Feb 2021 12:41:45 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id l128sm2315474qkf.68.2021.02.24.12.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 12:41:45 -0800 (PST) Date: Wed, 24 Feb 2021 15:41:44 -0500 From: Johannes Weiner To: Shakeel Butt Cc: Roman Gushchin , Michal Hocko , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: cleanup root memcg checks Message-ID: References: <20210223205625.2792891-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223205625.2792891-1-shakeelb@google.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 42A63C0007D0 X-Stat-Signature: nd3dzgwr6t8pm6jq58uck1z3ntoe7dbe Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-qk1-f174.google.com; client-ip=209.85.222.174 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614199303-717382 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 23, 2021 at 12:56:25PM -0800, Shakeel Butt wrote: > Replace the implicit checking of root memcg with explicit root memcg > checking i.e. !css->parent with mem_cgroup_is_root(). > > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner