From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 729ADC433DB for ; Wed, 3 Mar 2021 15:46:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E009264EE1 for ; Wed, 3 Mar 2021 15:46:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E009264EE1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5746D8D0176; Wed, 3 Mar 2021 10:46:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 524BC8D0157; Wed, 3 Mar 2021 10:46:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EBA38D0176; Wed, 3 Mar 2021 10:46:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 25AF58D0157 for ; Wed, 3 Mar 2021 10:46:57 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D0074182BD9F5 for ; Wed, 3 Mar 2021 15:46:56 +0000 (UTC) X-FDA: 77878991232.22.D340CA6 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf12.hostedemail.com (Postfix) with ESMTP id 3B9C73E9 for ; Wed, 3 Mar 2021 15:46:53 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614786413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eItB/OW8zK7jJR07Cs8xBdphkt5Qij7fbxg+T8AEzVY=; b=OtxuuN/BZeM+elMePOkzXDWBWt7q3ekdCmcm02GVM/N5R1vw/RnlY8InHlfW38IhIkZyNu RgwX1a9YCMU8RH2L8owf6kj+0GiIKSHm+TgOpk80edUWLkVQ+WTsoSDSvMupAhh58Ickgg BH+94Gwn1ZUj3EvgtRAAYYkxLM2hJbk= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CB641AD29; Wed, 3 Mar 2021 15:46:51 +0000 (UTC) Date: Wed, 3 Mar 2021 16:46:45 +0100 From: Anthony Iliopoulos To: Jens Axboe Cc: Linux Memory Management List , "linux-block@vger.kernel.org" , Christoph Hellwig , akpm@linux-foundation.org Subject: Re: [PATCH] swap: fix swapfile read/write offset Message-ID: References: <6f9da9c6-c6c5-08fe-95ea-940954456c40@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f9da9c6-c6c5-08fe-95ea-940954456c40@kernel.dk> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3B9C73E9 X-Stat-Signature: pqs5xn8sx5r6ga53qjixr7d9mfxi4m4k Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614786413-997480 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 02, 2021 at 03:36:19PM -0700, Jens Axboe wrote: > We're not factoring in the start of the file for where to write and > read the swapfile, which leads to very unfortunate side effects of > writing where we should not be... > > Fixes: 48d15436fde6 ("mm: remove get_swap_bio") Presumably the usage of swap_page_sector was already affecting swap on blockdevs that implement rw_page (currently brd, zram, btt, pmem), so it may worth adding: Fixes: dd6bd0d9c7db ("swap: use bdev_read_page() / bdev_write_page()") Cc: # v3.16+ for backporting, since it also affects stable.