From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB10C433E0 for ; Sat, 13 Feb 2021 14:29:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C39EF64D9E for ; Sat, 13 Feb 2021 14:29:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C39EF64D9E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4B9AE8D00C7; Sat, 13 Feb 2021 09:29:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 46A038D0060; Sat, 13 Feb 2021 09:29:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 380578D00C7; Sat, 13 Feb 2021 09:29:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1EDDA8D0060 for ; Sat, 13 Feb 2021 09:29:55 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DD26E18211CC9 for ; Sat, 13 Feb 2021 14:29:54 +0000 (UTC) X-FDA: 77813478708.30.key79_11175cd2762a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id B1D871814249B for ; Sat, 13 Feb 2021 14:29:54 +0000 (UTC) X-HE-Tag: key79_11175cd2762a X-Filterd-Recvd-Size: 5972 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Sat, 13 Feb 2021 14:29:54 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id i20so1385780edv.2 for ; Sat, 13 Feb 2021 06:29:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rTxtMdVJlP9rsr73q6o4Ig86cmaWLwUYLEI8zvZ8vqo=; b=AG82L/a1iC2O1thCjf1hd/Tjl+qX7Xz4vWwDGo+UpxtcHK3kEdpcYMm1muQS5/RmLt fkhgMx1YzsQfXZRHnP9xVqMlFUWA9MiDAmrw9omQ/tarr+i2bcHAzbl3YAJv8NWKUnuL T0PkK8+nxXw/3vDiizOfrxzxZYqjFrQhghB2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rTxtMdVJlP9rsr73q6o4Ig86cmaWLwUYLEI8zvZ8vqo=; b=kW6u9rBi2HCLEarPNo+whSeWLWq7FVeBf8WnDskg76N2DYFuIn0z19jFemLENUZc1E P/DqPn3Du963AXkPCHCgYdOpWOoP59D4PETdB97qsuMtZL4Za77AR/dMJEk5CCgqczMB duWeQGdESW/d4714YWItqjHHmQIGYA+B0yrcIf2xnzO1NrtNk6s3erSlgrjDQN329r1X BLuaSnHs0TVeqW0oBRDUhk0CeuLQAOUCTTTd/7CaTyE1kFdNtcWVn6+URJrUvZDbbJqU lI184YsC/6jd0WM8YsUHRHEU5zM01BLpU4EhITlwM+LagsHBjAW92gO8xbN9xXL+WpIw 1N/Q== X-Gm-Message-State: AOAM533SDIxU2VBPSMWfQj3mnZeByFTaYtQiaKKG5+ryZfACgdZ2EuZw Sv26vPxW883f6bh0IWqsfgBTQg== X-Google-Smtp-Source: ABdhPJzDiqgczcrO1AvXQYyABmmxlw1Ft3CDx6mn/G4u7MnoNWg8fxKriIPFONCPTUTR4blVaQUC7A== X-Received: by 2002:a05:6402:5252:: with SMTP id t18mr7860985edd.49.1613226592950; Sat, 13 Feb 2021 06:29:52 -0800 (PST) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id qx8sm7650289ejb.48.2021.02.13.06.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Feb 2021 06:29:52 -0800 (PST) Date: Sat, 13 Feb 2021 14:29:52 +0000 From: Chris Down To: kernel test robot Cc: linux-kernel@vger.kernel.org, kbuild-all@lists.01.org, Petr Mladek , Sergey Senozhatsky , John Ogness , Johannes Weiner , Andrew Morton , Linux Memory Management List , Steven Rostedt , Greg Kroah-Hartman , Kees Cook Subject: Re: [PATCH v4] printk: Userspace format enumeration support Message-ID: References: <202102130158.8qvFdZvE-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <202102130158.8qvFdZvE-lkp@intel.com> User-Agent: Mutt/2.0.5 (da5e3282) (2021-01-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: kernel test robot writes: >Hi Chris, > >Thank you for the patch! Yet something to improve: I'm pretty sure !CONFIG_PRINTK && CONFIG_IA64_DEBUG_CMPXCHG has been broken like this long before this change. With !CONFIG_PRINTK, printk() is static in the header, but ia64's cmpxchg.h with CONFIG_IA64_DEBUG_CMPXCHG doesn't take this into account before trying to use it as extern. CONFIG_IA64_DEBUG_CMPXCHG should be dependent on CONFIG_PRINTK. I'll send a separate patch for that, no reason to put it in this series. Not sure why LKP only caught it now though. Here's how it is even on the parent commit LKP applied this patch to: % git checkout bff4c8b4b0b9bcc31917d3b0f1a01a7573a1f473^ Previous HEAD position was bff4c8b4b0b9 printk: Userspace format enumeration support HEAD is now at 1fa67f8391ac module: mark TRIM_UNUSED_KSYMS as BROKEN on powerpc % COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 /tmp/make.cross ARCH=ia64 -s Compiler will be installed in /home/cdown/0day make W=1 CROSS_COMPILE=/home/cdown/0day/gcc-9.3.0-nolibc/ia64-linux/bin/ia64-linux- --jobs=32 ARCH=ia64 -s In file included from ./include/linux/kernel.h:16, from ./include/asm-generic/bug.h:20, from ./arch/ia64/include/asm/bug.h:17, from ./include/linux/bug.h:5, from ./include/linux/page-flags.h:10, from kernel/bounds.c:10: ./include/linux/printk.h:219:5: error: static declaration of 'printk' follows non-static declaration 219 | int printk(const char *s, ...) | ^~~~~~ In file included from ./arch/ia64/include/uapi/asm/intrinsics.h:22, from ./arch/ia64/include/asm/intrinsics.h:11, from ./arch/ia64/include/asm/bitops.h:19, from ./include/linux/bitops.h:32, from ./include/linux/kernel.h:11, from ./include/asm-generic/bug.h:20, from ./arch/ia64/include/asm/bug.h:17, from ./include/linux/bug.h:5, from ./include/linux/page-flags.h:10, from kernel/bounds.c:10: ./arch/ia64/include/uapi/asm/cmpxchg.h:142:14: note: previous declaration of 'printk' was here 142 | extern int printk(const char *fmt, ...); \ | ^~~~~~ ./arch/ia64/include/asm/bitops.h:309:3: note: in expansion of macro 'CMPXCHG_BUGCHECK' 309 | CMPXCHG_BUGCHECK(m); | ^~~~~~~~~~~~~~~~ make[1]: *** [scripts/Makefile.build:117: kernel/bounds.s] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1206: prepare0] Error 2