From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5753C433DB for ; Thu, 11 Feb 2021 10:45:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 437A464E2A for ; Thu, 11 Feb 2021 10:45:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 437A464E2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C4C916B00BA; Thu, 11 Feb 2021 05:45:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C25706B00BB; Thu, 11 Feb 2021 05:45:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3F0D6B00BC; Thu, 11 Feb 2021 05:45:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 9B4B36B00BA for ; Thu, 11 Feb 2021 05:45:09 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 68FAD180AD807 for ; Thu, 11 Feb 2021 10:45:09 +0000 (UTC) X-FDA: 77805654738.25.F7FF662 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf17.hostedemail.com (Postfix) with ESMTP id D5A23407F8DC for ; Thu, 11 Feb 2021 10:45:07 +0000 (UTC) IronPort-SDR: RNrC8UkYSyeKWMS1znE+0Hx8dAz8pcRDQ+8YP2Np4mdz4AFJy2FMRN+SULFALXE6Qehy0bQ0JZ 2+8U/eNTd/wQ== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="178713042" X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="178713042" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 02:45:06 -0800 IronPort-SDR: 21dSgq7fa0xJwBvXYfTapFKJGSh0Tc3D33IoipvYh/sLjy43jrZEMuApjWhr66BpN+VV4TdutS aIpvPY6zocKA== X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="510779032" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 02:45:01 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lA9Sz-004CZq-Nr; Thu, 11 Feb 2021 12:44:57 +0200 Date: Thu, 11 Feb 2021 12:44:57 +0200 From: Andy Shevchenko To: Timur Tabi Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Vlastimil Babka , Matthew Wilcox , akpm@linux-foundation.org, Linus Torvalds , roman.fietze@magna.com, Kees Cook , John Ogness , akinobu.mita@gmail.com, glider@google.com, Andrey Konovalov , Marco Elver , Rasmus Villemoes , Pavel Machek , Tetsuo Handa , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/3][v3] add support for never printing hashed addresses Message-ID: References: <20210210213453.1504219-1-timur@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210213453.1504219-1-timur@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D5A23407F8DC X-Stat-Signature: q37m5daaqrmrjqbind8ih834b854fk1g Received-SPF: none (linux.intel.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mga11.intel.com; client-ip=192.55.52.93 X-HE-DKIM-Result: none/none X-HE-Tag: 1613040307-271394 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 10, 2021 at 03:34:50PM -0600, Timur Tabi wrote: > [The list of email addresses on CC: is getting quite lengthy, > so I hope I've included everyone.] > > Although hashing addresses printed via printk does make the > kernel more secure, it interferes with debugging, especially > with some functions like print_hex_dump() which always uses > hashed addresses. > > To avoid having to choose between %p and %px, it's easier to > add a kernel command line that treats all %p as %px. This > encourages developers to use %p more without making debugging > more difficult. > > Patches #1 and #2 upgrade the kselftest framework so that > it can report on tests that were skipped outright. This > is needed for the test_printf module which will now skip > %p hashing tests if hashing is disabled. > > Patch #2 upgrades the printf library to check the command > line. It also updates test_printf(). Side note to the future contributions. > Full series: > > Acked-by: Marco Elver That's what you usually add to each patch in the series individually. You may use simple oneliner for this, i.e. `git filter-branch --msg-filter ...` -- With Best Regards, Andy Shevchenko