From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 857EEC433E0 for ; Wed, 10 Feb 2021 15:59:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F7C364D79 for ; Wed, 10 Feb 2021 15:59:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F7C364D79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 959566B006E; Wed, 10 Feb 2021 10:59:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93EE76B0070; Wed, 10 Feb 2021 10:59:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81DA26B0072; Wed, 10 Feb 2021 10:59:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 6C8B56B006E for ; Wed, 10 Feb 2021 10:59:20 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 358D11C9B5 for ; Wed, 10 Feb 2021 15:59:20 +0000 (UTC) X-FDA: 77802817680.06.pear68_0a06be827611 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 0356710062889 for ; Wed, 10 Feb 2021 15:59:19 +0000 (UTC) X-HE-Tag: pear68_0a06be827611 X-Filterd-Recvd-Size: 4180 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Feb 2021 15:59:19 +0000 (UTC) Received: by mail-pg1-f178.google.com with SMTP id t11so1494165pgu.8 for ; Wed, 10 Feb 2021 07:59:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RAtFVgzHhLfyixwTlntvq13DCjkeX6xQPOokD6zZ59o=; b=eNbRweMnAvSvlJagkl41Ph0xJKzfdSp0f8fnnQpHRm+GpXtd30L0rk41sjjaq4Is0c V2AhuuF0MtAlk5tHjNDnqfChmmV2+tFHch88/05gzeKz0N0VxVNni21x4S5tKp0UaoA+ /XWb7PG+lhHAmc4M1oxA3Uy2mdD8jxDTWbhk991dBz217RkPYddl6fzSm+ECR9dCqU0+ QqcAWp5Qwp5rYvOYw1oLx9efsTa94jdaMSxCf7x4LgxKVF99sbrJNscv7Bjawpx32ud5 15OcrmyWWeIPVKVUuWKFlZNIovt8bNVU2fEo/PsHkwssUJ6uol0hQd3z3ki+XTNpJXvH PwfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=RAtFVgzHhLfyixwTlntvq13DCjkeX6xQPOokD6zZ59o=; b=fcaSLHB31j9d9lp0Hvcx/GUoPy9bgNRrvapujpAwz6F/hJj4nA4c4hyb/+lLK8NNgt dYAJBb7cNAoaJDNbRw//t6omz9S+3WGCWj65+nBoTB8f5tsxnZK6pcj81G+tKGhVSnWA yJHW2AwhRcAe6cvMmI5saYKivDvioH1/DnUDVIogfK5wdcMXlCNeMP4lRYuhmCl5Wcw8 3Rej2MAMnzRO1WEu2YQK/Ka4incHdXJ9qYQP91h3ci9baJUqLAOL6mg3o+DUIMdxlxrm oVd0G2/aqndGX0fHaeJGzsC4mJwOPoh/KORC93bmdpE4DhiULhUHGrFzW9jJRaE+q+5u Zekw== X-Gm-Message-State: AOAM533TTMwfp80ag7u9T4LHYf6v2XZDCkrMAxYEEOrU7lWoR7OvCE+7 IT2ljfWtqG7jOSLhcaT7AcM= X-Google-Smtp-Source: ABdhPJwAu19LKeDwjjzO0jCx3QFJ6wmEbRWuzKHKjyHpFzetsD2LeVVswnKzvtX3fLr50am8eqrgkA== X-Received: by 2002:a62:d0c5:0:b029:1d8:61e0:c5ae with SMTP id p188-20020a62d0c50000b02901d861e0c5aemr3662084pfg.52.1612972758275; Wed, 10 Feb 2021 07:59:18 -0800 (PST) Received: from google.com ([2620:15c:211:201:e5b0:be96:1dfb:a1f6]) by smtp.gmail.com with ESMTPSA id o124sm2998887pfg.108.2021.02.10.07.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 07:59:17 -0800 (PST) Date: Wed, 10 Feb 2021 07:59:15 -0800 From: Minchan Kim To: John Hubbard Cc: Andrew Morton , willy@infradead.org, gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, LKML , linux-mm Subject: Re: [PATCH v3] mm: cma: support sysfs Message-ID: References: <20210210075509.3788729-1-minchan@kernel.org> <070ca72a-c99f-a2a7-c460-0a823cc262f4@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <070ca72a-c99f-a2a7-c460-0a823cc262f4@nvidia.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 10, 2021 at 12:05:48AM -0800, John Hubbard wrote: > On 2/9/21 11:55 PM, Minchan Kim wrote: > > Since CMA is getting used more widely, it's more important to > > keep monitoring CMA statistics for system health since it's > > directly related to user experience. > > > > This patch introduces sysfs statistics for CMA, in order to provide > > some basic monitoring of the CMA allocator. > > > > * the number of CMA page allocation attempts > > * the number of CMA page allocation failures > > > > These two values allow the user to calcuate the allocation > > failure rate for each CMA area. > > > > e.g.) > > /sys/kernel/mm/cma/WIFI/cma_alloc_pages_[attempts|fails] > > /sys/kernel/mm/cma/SENSOR/cma_alloc_pages_[attempts|fails] > > /sys/kernel/mm/cma/BLUETOOTH/cma_alloc_pages_[attempts|fails] > > > > Signed-off-by: Minchan Kim > > --- > > Looks good. > > Reviewed-by: John Hubbard Thanks for reviewing, John and Greg!