From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A757C433DB for ; Mon, 8 Feb 2021 11:04:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9560964E0B for ; Mon, 8 Feb 2021 11:04:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9560964E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 93D3B6B0072; Mon, 8 Feb 2021 06:04:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EE976B0073; Mon, 8 Feb 2021 06:04:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DD8C6B0074; Mon, 8 Feb 2021 06:04:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 65C2C6B0072 for ; Mon, 8 Feb 2021 06:04:11 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 21F6D181AEF1E for ; Mon, 8 Feb 2021 11:04:11 +0000 (UTC) X-FDA: 77794816302.10.shelf83_2214aaa275fe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id F1EAD16A4A9 for ; Mon, 8 Feb 2021 11:04:10 +0000 (UTC) X-HE-Tag: shelf83_2214aaa275fe X-Filterd-Recvd-Size: 5944 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 11:04:10 +0000 (UTC) Received: by mail-wr1-f51.google.com with SMTP id b3so16535297wrj.5 for ; Mon, 08 Feb 2021 03:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pufLM1lgk30Z0xNUrr/sKibBHabmfyHL7QD1WY1Y8VI=; b=iniQAbHQgxYyxXrODcz5H25no50robM+BRmtay9TDQp3GkR61GWi+tMIeRE+l+BwlF htSJGAWcO4ZhGi6H1KpZalqoHbgu5gAGQq3qBOVFj6ypipvAtSIdeGz+dGj/WkvMZR/z RKJP/FCxsrt1uxui0UJE5ztr8C4ajgkvawLkrsOMZh7qChLKx6SANqyWJLT135jItsVz ketpYksjvR1NBhuFuJqgrPfEBK//yDMhN8H9ieg3Aol/Q5zo0xGwRWypit1E7FR8ak33 W9/Oyz5zbfACKhHz/qYEkII58OB/MGQBH/fhhsax7nl0HD4e0yDXcZX0qmEq9f1uVwHE Ex/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pufLM1lgk30Z0xNUrr/sKibBHabmfyHL7QD1WY1Y8VI=; b=q1oXsW1ts9tCyMsClK8e9fMEzQU6kNsUoyM25792gMzdGdo2gUj779oV8hu6B6f+lE GCD1Qd23xtYDKujFZGgjCwrUpGtLEi/ifPLWyseHFr9Tn4CtlbaMCLPaRNtV3NO6/Ym4 PPpf3XWWwI9rrooBrYYJrqAkyR0r1Q8HRjtK1GjtNOoyNLb18VdiFGwGapW0gwEsESz3 +nsvRHl923mJGwvTN0FzZi0L7nS2GnebYmZ68e3jBCMvTKzDoin4nUxD2lA86jnHFX+n FDbLI3aA+vu5DCR03tykldo9kKJGLMr5l5lus+uvsbbdgvHdF+mkAEyjFM3IFFOMyv7d fB2g== X-Gm-Message-State: AOAM531LZYJF0DljZSTSMgKitYru2e+GE7vwWRaGelb4XPrVFcsvWE2K 9Sj2RCttuPLE/A1ZOuFW5gPKgg== X-Google-Smtp-Source: ABdhPJxsmyLQVX4sWX2FYBfjZz5gROTDQRFioLFhFldnjYhL3QwGKQjxhinXI80+MX13RPN0toHgaQ== X-Received: by 2002:a05:6000:192:: with SMTP id p18mr19149327wrx.69.1612782249203; Mon, 08 Feb 2021 03:04:09 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:497f:76ef:2e62:d028]) by smtp.gmail.com with ESMTPSA id x82sm14752706wmg.31.2021.02.08.03.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 03:04:08 -0800 (PST) Date: Mon, 8 Feb 2021 12:04:02 +0100 From: Marco Elver To: Andrey Konovalov Cc: Andrew Morton , Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 mm 11/13] kasan: inline HW_TAGS helper functions Message-ID: References: <2c94a2af0657f2b95b9337232339ff5ffa643ab5.1612546384.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c94a2af0657f2b95b9337232339ff5ffa643ab5.1612546384.git.andreyknvl@google.com> User-Agent: Mutt/2.0.2 (2020-11-20) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 05, 2021 at 06:34PM +0100, Andrey Konovalov wrote: > Mark all static functions in common.c and kasan.h that are used for > hardware tag-based KASAN as inline to avoid unnecessary function calls. > > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > mm/kasan/common.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 7ffb1e6de2ef..7b53291dafa1 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -279,7 +279,8 @@ void __kasan_poison_object_data(struct kmem_cache *cache, void *object) > * based on objects indexes, so that objects that are next to each other > * get different tags. > */ > -static u8 assign_tag(struct kmem_cache *cache, const void *object, bool init) > +static inline u8 assign_tag(struct kmem_cache *cache, > + const void *object, bool init) > { > if (IS_ENABLED(CONFIG_KASAN_GENERIC)) > return 0xff; > @@ -321,8 +322,8 @@ void * __must_check __kasan_init_slab_obj(struct kmem_cache *cache, > return (void *)object; > } > > -static bool ____kasan_slab_free(struct kmem_cache *cache, void *object, > - unsigned long ip, bool quarantine) > +static inline bool ____kasan_slab_free(struct kmem_cache *cache, > + void *object, unsigned long ip, bool quarantine) > { > u8 tag; > void *tagged_object; > @@ -366,7 +367,7 @@ bool __kasan_slab_free(struct kmem_cache *cache, void *object, unsigned long ip) > return ____kasan_slab_free(cache, object, ip, true); > } > > -static bool ____kasan_kfree_large(void *ptr, unsigned long ip) > +static inline bool ____kasan_kfree_large(void *ptr, unsigned long ip) > { > if (ptr != page_address(virt_to_head_page(ptr))) { > kasan_report_invalid_free(ptr, ip); > @@ -461,8 +462,8 @@ void * __must_check __kasan_slab_alloc(struct kmem_cache *cache, > return tagged_object; > } > > -static void *____kasan_kmalloc(struct kmem_cache *cache, const void *object, > - size_t size, gfp_t flags) > +static inline void *____kasan_kmalloc(struct kmem_cache *cache, > + const void *object, size_t size, gfp_t flags) > { > unsigned long redzone_start; > unsigned long redzone_end; > -- > 2.30.0.365.g02bc693789-goog >