From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F5EC433E0 for ; Thu, 18 Feb 2021 15:45:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D317F64E4B for ; Thu, 18 Feb 2021 15:45:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D317F64E4B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 384A76B006E; Thu, 18 Feb 2021 10:45:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 335266B0070; Thu, 18 Feb 2021 10:45:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FABD6B0071; Thu, 18 Feb 2021 10:45:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 0B2506B006E for ; Thu, 18 Feb 2021 10:45:16 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C39E1611A for ; Thu, 18 Feb 2021 15:45:15 +0000 (UTC) X-FDA: 77831812590.24.salt58_1d096fe27656 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id A55841A4A0 for ; Thu, 18 Feb 2021 15:45:15 +0000 (UTC) X-HE-Tag: salt58_1d096fe27656 X-Filterd-Recvd-Size: 3655 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Feb 2021 15:45:14 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1613663113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kndRiznQhLZKdWjvHBON40ykfoLHDXlmWt2IkZM5PBU=; b=c/Ju6GZd7mODmFOw0RU+s3Te8Rj6FISqx3vLAeSpNv+lm8vJob7on1EyKZCeD86O5KSxzW B5wEAEdwPrXvyqEfYIg2Wgaug4Q3XAByoUNxJ7AZsk+bfOKK8GorHWXhGXQMDv5p9QMlNK JsjZGrpqYhvgKCMZjE/nCTSfaAkF2lY= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 52075ADDB; Thu, 18 Feb 2021 15:45:13 +0000 (UTC) Date: Thu, 18 Feb 2021 16:45:11 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Johannes Weiner Cc: Andrew Morton , Tejun Heo , Michal Hocko , Roman Gushchin , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v3 4/8] cgroup: rstat: support cgroup1 Message-ID: References: <20210209163304.77088-1-hannes@cmpxchg.org> <20210209163304.77088-5-hannes@cmpxchg.org> <20210217174232.GA19239@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xS+is/W892RytHV4" Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --xS+is/W892RytHV4 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 17, 2021 at 03:52:59PM -0500, Johannes Weiner wrote: > It's possible, but I don't think worth the trouble. You're right. I gave it a deeper look and what would be saved on data, would be paid in code complexity. > In this case, we're talking about a relatively small data structure > and the overhead is per mountpoint. IIUC, it is per each mountpoint's number of cgroups. But I still accept the argument above. Furthermore, this can be changed later. > The default root group has statically preallocated percpu data before > and after this patch. See cgroup.c: I stand corrected, the comment is still valid. Therefore, Reviewed-by: Michal Koutn=FD --xS+is/W892RytHV4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEEoQaUCWq8F2Id1tNia1+riC5qSgFAmAui4cACgkQia1+riC5 qSiJ4w/8DUxQueOw6E/q3wd6I9lRyh4brtboIOu0xAz+2INf5BsbykFQJEEIoAA+ nsM+ICp+et0ABUMFGA34a3+vX0dOb2IkF84foWIIqnR683/gjF+tiQJrmbZBztBP R5MnPRKG/R2JtJer/q4SFDGtBblFUr78Y56k7mO2lbXCeHvkAJLMit6VfQZAmS6R BWbTTWJQov5DWTA0gtfWM5vXIe0sFkiJKz2oi6xHiKBIuUrISGGrpMzlxOP0abpU Gm1/IVaspHWJ0LB6XFjU0KnjpW1WJVQKEmg5pecEL5M5V01Bc0sA+s2F/XDq/beZ 8MUdVgw+le4omSkvi3rjpX5Pk006SEJfOYpB+/m9fRA23yC1zYLLPvoimHHGS7Ir QMLkVfozsOWqMpTSdWO9eKIFFt1FL7S4kaR5cWxI4gbvJDR89t9Q6do16+jP4FGM mWb47ipEwi/52Ib6YxYosV9MIqpSpfa6bQYkCHdj4mRoot+HwfWthOnV3PKUaGzT XWJVh9UWac6rydWCi5j0L865dZrDMeGT8xYmOx1Dm7AfrDyNXpJGoTb+n4rn+nw9 lGETsYGzcIhRDU2vILI5MaROqjfn2ZU1bIKQRUCmhpYqF5Fa3Ejglzdy2MM/hfd3 SIx50o61u3w6k10SzaS3mjPu6ROBhtLTXhU2e+pmfY84qJLRdW0= =H1Nj -----END PGP SIGNATURE----- --xS+is/W892RytHV4--