From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35AA4C433DB for ; Wed, 17 Feb 2021 21:22:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D965964E58 for ; Wed, 17 Feb 2021 21:22:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D965964E58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3FC576B0006; Wed, 17 Feb 2021 16:22:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AE006B006C; Wed, 17 Feb 2021 16:22:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24DA46B006E; Wed, 17 Feb 2021 16:22:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 0E6A36B0006 for ; Wed, 17 Feb 2021 16:22:10 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CD460183D88CE for ; Wed, 17 Feb 2021 21:22:09 +0000 (UTC) X-FDA: 77829032778.16.0E460DF Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf06.hostedemail.com (Postfix) with ESMTP id 02922C000C44 for ; Wed, 17 Feb 2021 21:22:09 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id k22so21022pll.6 for ; Wed, 17 Feb 2021 13:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sQzaNxAid9QvqVYhihsfh2vWMCoJ27PcKGw8kt1g66I=; b=p0QwrOctwd52hexap6KCKB3coo8XhqEMui5DoM+5kapBOCgvyAp7ekJdpeCpkuv7IO Kyq/cmtvDejQPhs7UFTwVYQGBE1U+C4HUmKE7W4yGgYjjD5Wv4ozQ7D+kSnc5LrVYTeW NvA45IpZf95mwZtcplJBAMyAqh2ftR73lmDJka9nasDdXC2zXNSRlklCdPXnZPoLUVrg 4VTC1SsTKN4i88U4NYVKpB8ikdmEKhy2ZOLoMyyQFCrbBjzSTISK2fAdTTn0tGMC692s Ik9IHq3dovW92AIGU47FexYjZGQyAAwP5VTWHbyxBq2BdjDtKjXIzIF+LlwyQulVCA0N 0a/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=sQzaNxAid9QvqVYhihsfh2vWMCoJ27PcKGw8kt1g66I=; b=Oxg7qGSGDYq/0ot35gkny7ujIqY5HKe8huZNFT55KbqykOkaymAHbEcID2K40FlawV elfooy0d6FUjL7OJsWziym/rOU/J+9dd/aX0F/Tb2oLLPY3IT4D+khbgClKxizTDPt2o hpWZv5AUKeWPobZzTVrMpqo8IwQMTaTBNhGxbrYxwwqTHrspRnzacm/MRHkw9bMkgJll UwlfA0rfuS8N3kudP/QR8VxmVNANBrTtgK01wOtY4zSNBk2Hi2pqYkE5lR+PAjrwRn88 CmBl3IT1i//1EKKWW+eDsQd69WnzQ2RFlVhetYzn76B2gU75E2cKWOTcwYle8yjRQP/o /dHQ== X-Gm-Message-State: AOAM532+7bcnVxdK+PqjwVjbwmjtyEMbFK8HUPEpqGvHmNBSKKGbX0vE lPsdHdYis8Emx146xPtkV1Y= X-Google-Smtp-Source: ABdhPJyneviUq4ugz6XKjWdZ8xrW7jmT9QscfAaiU+m4gfcMOT7KkVass8VqD3YPzLbVH6LFh50zCA== X-Received: by 2002:a17:902:f54e:b029:e3:5af0:d98f with SMTP id h14-20020a170902f54eb02900e35af0d98fmr920942plf.5.1613596928463; Wed, 17 Feb 2021 13:22:08 -0800 (PST) Received: from google.com ([2620:15c:211:201:157d:8a19:5427:ea9e]) by smtp.gmail.com with ESMTPSA id 184sm3475254pgi.92.2021.02.17.13.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 13:22:07 -0800 (PST) Date: Wed, 17 Feb 2021 13:22:05 -0800 From: Minchan Kim To: Matthew Wilcox Cc: Michal Hocko , Andrew Morton , linux-mm , LKML , cgoldswo@codeaurora.org, linux-fsdevel@vger.kernel.org, david@redhat.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, joaodias@google.com Subject: Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily Message-ID: References: <20210216170348.1513483-1-minchan@kernel.org> <20210217211143.GN2858050@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210217211143.GN2858050@casper.infradead.org> X-Stat-Signature: f7azpzxozj6mraq3dbwry8gdu6yx8cc9 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 02922C000C44 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail-pl1-f181.google.com; client-ip=209.85.214.181 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613596929-823429 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 17, 2021 at 09:11:43PM +0000, Matthew Wilcox wrote: > On Wed, Feb 17, 2021 at 12:51:25PM -0800, Minchan Kim wrote: > > I'd like to avoid atomic operation if we could. > > Why do you think that the spinlock is better? > Michal suggested atomic_inc in writeside and atomic_read in readside. I wanted to avoid atomic operation in readside path. You are suggesting atomic for writeside and just read(not atomic_read) in readside?