From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9D3BC433DB for ; Wed, 3 Feb 2021 19:30:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2AC4A64F72 for ; Wed, 3 Feb 2021 19:30:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AC4A64F72 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B17F6B0005; Wed, 3 Feb 2021 14:30:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 744A66B006C; Wed, 3 Feb 2021 14:30:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6035F6B006E; Wed, 3 Feb 2021 14:30:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 472A86B0005 for ; Wed, 3 Feb 2021 14:30:34 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0E7A41EE6 for ; Wed, 3 Feb 2021 19:30:34 +0000 (UTC) X-FDA: 77777948388.10.crook90_2d131bd275d6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id D390316A0AE for ; Wed, 3 Feb 2021 19:30:33 +0000 (UTC) X-HE-Tag: crook90_2d131bd275d6 X-Filterd-Recvd-Size: 3142 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 3 Feb 2021 19:30:32 +0000 (UTC) IronPort-SDR: ruwVj59X6QijJzSZI9FiHvydZ+PNi7wf+cPyJHzq6sjME2CsF1yvhI1fIdg8VA6Zhcf+wH+mMH CRZdbJegnxJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="180332028" X-IronPort-AV: E=Sophos;i="5.79,399,1602572400"; d="scan'208";a="180332028" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 11:30:31 -0800 IronPort-SDR: rk+x0kdRJQ2cymIKplWCGUcSjS3JrXe3MwBpXeb8yoLu7a7kPaAwIFvRxBkTgfW8d4dCqcFn6k bIbIw7/7T1ZA== X-IronPort-AV: E=Sophos;i="5.79,399,1602572400"; d="scan'208";a="406761288" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 11:30:27 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l7Nr6-001iCt-9m; Wed, 03 Feb 2021 21:30:24 +0200 Date: Wed, 3 Feb 2021 21:30:24 +0200 From: Andy Shevchenko To: Timur Tabi Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , linux-kernel@vger.kernel.org, vbabka@suse.cz, linux-mm@kvack.org, willy@infradead.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, roman.fietze@magna.com, keescook@chromium.org, john.ogness@linutronix.de, Rasmus Villemoes , akinobu.mita@gmail.com Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed Message-ID: References: <20210202213633.755469-1-timur@kernel.org> <19c1c17e-d0b3-326e-97ec-a4ec1ebee749@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19c1c17e-d0b3-326e-97ec-a4ec1ebee749@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 03, 2021 at 12:58:41PM -0600, Timur Tabi wrote: > On 2/3/21 7:31 AM, Petr Mladek wrote: > > Also please make sure that lib/test_printf.c will work with > > the new option. > > As you suspected, it doesn't work: > > [ 206.966478] test_printf: loaded. > [ 206.966528] test_printf: plain 'p' does not appear to be hashed > [ 206.966740] test_printf: failed 1 out of 388 tests > > What should I do about this? > > On one hand, it is working as expected: %p is not hashed, and that should be > a warning. > > On the other hand, maybe test_printf should be aware of the command line > parameter and test to make sure that %p is NOT hashed? test_printf.c should be altered accordingly to avoid any failed test cases. I.o.w. you need to have some kind of conditional there: if (kernel_cmdline_parameter_foo) expect bar else expect baz -- With Best Regards, Andy Shevchenko