From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 054F6C433E6 for ; Wed, 3 Feb 2021 13:34:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 875ED64F7E for ; Wed, 3 Feb 2021 13:34:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 875ED64F7E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 232306B0071; Wed, 3 Feb 2021 08:34:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 207A46B0072; Wed, 3 Feb 2021 08:34:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D0726B0073; Wed, 3 Feb 2021 08:34:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id E77CD6B0071 for ; Wed, 3 Feb 2021 08:34:20 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AF773180AD811 for ; Wed, 3 Feb 2021 13:34:20 +0000 (UTC) X-FDA: 77777050680.22.2B408A7 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf08.hostedemail.com (Postfix) with ESMTP id 8628180191F0 for ; Wed, 3 Feb 2021 13:31:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1612359075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HJ/pOW2pVk+Tk6918Gy0+OyDDO46X5OQzgxUWG5pahc=; b=Id4M97LAkFluqXd6g9khC8yoH8+lZ0VBZqKPxCmsDtby8vls8jzpteun+HVfxu4EwgDYbs KohQVf3k5CD2DM9gPdYREx3L/gl01GdeDdzFPIUxmAi0rpY73no3tpcWmuKOlU/ipHKBQ1 +Yu3fGsysMAaXToKiWUf4pfiUZJIInU= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B5945B048; Wed, 3 Feb 2021 13:31:15 +0000 (UTC) Date: Wed, 3 Feb 2021 14:31:14 +0100 From: Petr Mladek To: Timur Tabi Cc: Steven Rostedt , Sergey Senozhatsky , linux-kernel@vger.kernel.org, vbabka@suse.cz, linux-mm@kvack.org, willy@infradead.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, roman.fietze@magna.com, keescook@chromium.org, john.ogness@linutronix.de, Andy Shevchenko , Rasmus Villemoes , akinobu.mita@gmail.com Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed Message-ID: References: <20210202213633.755469-1-timur@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8628180191F0 X-Stat-Signature: jhxm149h91ee4za6bugzjkjz6zor9nrw Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612359075-793544 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 2021-02-03 10:54:24, Petr Mladek wrote: > On Tue 2021-02-02 15:36:33, Timur Tabi wrote: > > If the make-printk-non-secret command-line parameter is set, then > > printk("%p") will print addresses as unhashed. This is useful for > > debugging purposes. > > > > A large warning message is displayed if this option is enabled, > > because unhashed addresses, while useful for debugging, exposes > > kernel addresses which can be a security risk. > > > > Signed-off-by: Timur Tabi > > --- > > lib/vsprintf.c | 34 ++++++++++++++++++++++++++++++++-- > > 1 file changed, 32 insertions(+), 2 deletions(-) > > Please, add also entry into > Documentation/admin-guide/kernel-parameters.txt. Adding Andy and Rasmus into CC. They are official vsprintf co-maintainers and reviewers (MAINTAINERS file). Also please make sure that lib/test_printf.c will work with the new option. Best Regards, Petr