From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1D75C433DB for ; Wed, 3 Feb 2021 12:14:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 49EA964F96 for ; Wed, 3 Feb 2021 12:14:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49EA964F96 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E1C56B0078; Wed, 3 Feb 2021 07:14:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96AEC6B007B; Wed, 3 Feb 2021 07:14:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 830F16B007D; Wed, 3 Feb 2021 07:14:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 693F16B0078 for ; Wed, 3 Feb 2021 07:14:08 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 312D18249980 for ; Wed, 3 Feb 2021 12:14:08 +0000 (UTC) X-FDA: 77776848576.07.26587B2 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf03.hostedemail.com (Postfix) with ESMTP id CA5D5C0001E4 for ; Wed, 3 Feb 2021 12:14:06 +0000 (UTC) Received: by mail-wm1-f41.google.com with SMTP id i9so4999672wmq.1 for ; Wed, 03 Feb 2021 04:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zSxY3nTKxJ1IPmcAhiUV2gxjS9POrRlqCu2+Tg/s2dQ=; b=jxovcCp23NxnX5Hp49LaYRb7dreVWiKfVkDKjHEssP9w0PKSQpvZzGDyuAe3Nv9vBl n/0Gv9uKM8/arUY5onnt0c2g3+1Rk/9E3TYsErSz2wwgOTZRi9mv5Nf+5d2RrTp6Z/6u DrHfChk0bxGbkDyS363tn+zSsrraNtnqAkyDNttztwQJzuGihNA52YRlvODyGcKaG4cB do5sX1ZQlLvTfu5Zcfl1hdmLXSHUW8KhjoR5Ue/V62RN/x6B5VmOo5T1WWldXNl1kkNV BH8ykIAcyRL/oDrmwJGOvu/7S2JA7QFHLanUYNTEv+l9wMkiW8P1csHIHjA0np34altC VRQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zSxY3nTKxJ1IPmcAhiUV2gxjS9POrRlqCu2+Tg/s2dQ=; b=nzTGKhfh0mLEIe7FaVIof1mUk49medNhbkWEYi9WeD269JuOEXWOyePk9oM/+zNbbu JlwEFXZrtYHLREywXSSdnOOiy52wI59HPVWMXbZC9lNpxpF8fPIU2FbNu1Jvw8XkZ5og kzsv+hofdH5MaOne0FDe3XyBkKYJnU06FhRcCP+kAQRQlAbpa7KIxvrODkF9gFpJV9rl GnY/+Hfwcsfr3AlJgViRpOcwWslY0w4CZr41Ka1XAMEw+RdrUkr+vUEzS1JaR9S6Lo9o GhCncZDueCbnlVhTAOcGbFqTWCFehLOJTVoYY+7QF67XT6fwZryy7Twp6XWptVtoP6zS k/dg== X-Gm-Message-State: AOAM5328mdXVjIrWb5bNINTiuQ+PcFJazBsCG9HoqEco96vUaRu5I0H5 e0gEn8EZ9vnAvpDe+LBeMy64Ag== X-Google-Smtp-Source: ABdhPJzHUcn98nIsrejDzYN9IFJdoqS9rkwCww87febSamOfAt2gIdft3snfHT97RjWrS9lEd4rMTQ== X-Received: by 2002:a7b:c5d6:: with SMTP id n22mr2512430wmk.70.1612354445997; Wed, 03 Feb 2021 04:14:05 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:b1de:c7d:30ce:1840]) by smtp.gmail.com with ESMTPSA id t17sm2566202wmi.46.2021.02.03.04.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 04:14:05 -0800 (PST) Date: Wed, 3 Feb 2021 13:13:59 +0100 From: Marco Elver To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/12] kasan: unify large kfree checks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.2 (2020-11-20) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CA5D5C0001E4 X-Stat-Signature: n896jq9bork49kj7xw996gyb1rt6oqzc Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-wm1-f41.google.com; client-ip=209.85.128.41 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612354446-229763 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 01, 2021 at 08:43PM +0100, Andrey Konovalov wrote: > Unify checks in kasan_kfree_large() and in kasan_slab_free_mempool() > for large allocations as it's done for small kfree() allocations. > > With this change, kasan_slab_free_mempool() starts checking that the > first byte of the memory that's being freed is accessible. > > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > include/linux/kasan.h | 16 ++++++++-------- > mm/kasan/common.c | 36 ++++++++++++++++++++++++++---------- > 2 files changed, 34 insertions(+), 18 deletions(-) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 2d5de4092185..d53ea3c047bc 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -200,6 +200,13 @@ static __always_inline bool kasan_slab_free(struct kmem_cache *s, void *object) > return false; > } > > +void __kasan_kfree_large(void *ptr, unsigned long ip); > +static __always_inline void kasan_kfree_large(void *ptr) > +{ > + if (kasan_enabled()) > + __kasan_kfree_large(ptr, _RET_IP_); > +} > + > void __kasan_slab_free_mempool(void *ptr, unsigned long ip); > static __always_inline void kasan_slab_free_mempool(void *ptr) > { > @@ -247,13 +254,6 @@ static __always_inline void * __must_check kasan_krealloc(const void *object, > return (void *)object; > } > > -void __kasan_kfree_large(void *ptr, unsigned long ip); > -static __always_inline void kasan_kfree_large(void *ptr) > -{ > - if (kasan_enabled()) > - __kasan_kfree_large(ptr, _RET_IP_); > -} > - > /* > * Unlike kasan_check_read/write(), kasan_check_byte() is performed even for > * the hardware tag-based mode that doesn't rely on compiler instrumentation. > @@ -302,6 +302,7 @@ static inline bool kasan_slab_free(struct kmem_cache *s, void *object) > { > return false; > } > +static inline void kasan_kfree_large(void *ptr) {} > static inline void kasan_slab_free_mempool(void *ptr) {} > static inline void *kasan_slab_alloc(struct kmem_cache *s, void *object, > gfp_t flags) > @@ -322,7 +323,6 @@ static inline void *kasan_krealloc(const void *object, size_t new_size, > { > return (void *)object; > } > -static inline void kasan_kfree_large(void *ptr) {} > static inline bool kasan_check_byte(const void *address) > { > return true; > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 086bb77292b6..9c64a00bbf9c 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -364,6 +364,31 @@ bool __kasan_slab_free(struct kmem_cache *cache, void *object, unsigned long ip) > return ____kasan_slab_free(cache, object, ip, true); > } > > +static bool ____kasan_kfree_large(void *ptr, unsigned long ip) > +{ > + if (ptr != page_address(virt_to_head_page(ptr))) { > + kasan_report_invalid_free(ptr, ip); > + return true; > + } > + > + if (!kasan_byte_accessible(ptr)) { > + kasan_report_invalid_free(ptr, ip); > + return true; > + } > + > + /* > + * The object will be poisoned by kasan_free_pages() or > + * kasan_slab_free_mempool(). > + */ > + > + return false; > +} > + > +void __kasan_kfree_large(void *ptr, unsigned long ip) > +{ > + ____kasan_kfree_large(ptr, ip); > +} > + > void __kasan_slab_free_mempool(void *ptr, unsigned long ip) > { > struct page *page; > @@ -377,10 +402,8 @@ void __kasan_slab_free_mempool(void *ptr, unsigned long ip) > * KMALLOC_MAX_SIZE, and kmalloc falls back onto page_alloc. > */ > if (unlikely(!PageSlab(page))) { > - if (ptr != page_address(page)) { > - kasan_report_invalid_free(ptr, ip); > + if (____kasan_kfree_large(ptr, ip)) > return; > - } > kasan_poison(ptr, page_size(page), KASAN_FREE_PAGE); > } else { > ____kasan_slab_free(page->slab_cache, ptr, ip, false); > @@ -539,13 +562,6 @@ void * __must_check __kasan_krealloc(const void *object, size_t size, gfp_t flag > return ____kasan_kmalloc(page->slab_cache, object, size, flags); > } > > -void __kasan_kfree_large(void *ptr, unsigned long ip) > -{ > - if (ptr != page_address(virt_to_head_page(ptr))) > - kasan_report_invalid_free(ptr, ip); > - /* The object will be poisoned by kasan_free_pages(). */ > -} > - > bool __kasan_check_byte(const void *address, unsigned long ip) > { > if (!kasan_byte_accessible(address)) { > -- > 2.30.0.365.g02bc693789-goog >