From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21614C433DB for ; Mon, 1 Feb 2021 18:44:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8714664EA3 for ; Mon, 1 Feb 2021 18:43:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8714664EA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B9BAE6B0083; Mon, 1 Feb 2021 13:43:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4D3A6B0085; Mon, 1 Feb 2021 13:43:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A43B76B0087; Mon, 1 Feb 2021 13:43:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 8A3AF6B0083 for ; Mon, 1 Feb 2021 13:43:58 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4CB911EE6 for ; Mon, 1 Feb 2021 18:43:58 +0000 (UTC) X-FDA: 77770573356.01.jam93_3e0ebbe275c4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 2EFA210046481 for ; Mon, 1 Feb 2021 18:43:58 +0000 (UTC) X-HE-Tag: jam93_3e0ebbe275c4 X-Filterd-Recvd-Size: 3615 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 18:43:57 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id u11so10492714plg.13 for ; Mon, 01 Feb 2021 10:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PlNBxyGKqX8rTM2Nlq0u1yNj1djA6ZOFZTkUZoytNjs=; b=QREHAf9bNTRvpxtgMZRmhnoM7P6JXcSJGy1pcjXJAKa+fp/F0ZOe1WCZhRF5Y0evjx oHbpoDpmNUyAViOTzPc7HuvKseKotQ4oEcpbXyJEr3+QMHgVqgnBSn1HwYwC2wbbyCvD OlYvTeMquNE0ijxO/2GZ4/OacMaCoieBxqrKlX3UEjJTh6UMHp1vgJJ5D0PPmjhZfQ/w POWk3ZdGCWw2AYjp2v58a99oIYfZvgVf/6fHmXx5wxg6CsLkqAec067ZmYZDCIiqrcWo Aa+v9CU2fwugTuteccp14nFxdPKraNhCagMy0TnZCKYteB6zlkl3wgtH4VoPF/euYphU SQTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=PlNBxyGKqX8rTM2Nlq0u1yNj1djA6ZOFZTkUZoytNjs=; b=XqcMozVZTc/Q84Vkgyc2fkjUoGzJ+6puXbjEyJRisakg5hI1+B4GOw659n/rBga+Ll EwXgMe68l1YQLnkBJDQ6htxJBDeF2JtiIrHfiS+xttp4es3JTsd9o1L4N3P4w6ycSa8x Pu6tqbckjBhe/HPJGKWqyFXBhybdJCgv3Hvcb/qzgbXR/P6a2/mJWXNYMgbofwRgzWdZ nNzow35MKwNRAqy6QKLZfXcT/PgjynL2Q5+crqZnGMnobdZBGwr5XOfzVC1mQfIIAZjZ w38OYLxY/P3SSgv5YUvqYU3lp/atEyTb9kotopwsCsfGF6wf++wunV+BHkaNXb6GRGpI 1dZw== X-Gm-Message-State: AOAM530T1GKW0lAltvNEkSJslcDza50ovrlqNaj730Ihz+m+ctMceH8e o9IGA4LqGmf5D1lbBCtnTd0= X-Google-Smtp-Source: ABdhPJz1TyrNkqlPnmv8BbCuwBEvggzs5mlSYRBRBLn1ZMYBh1z3OpXg9PdaPI8nF7dLMqEbq/2rlA== X-Received: by 2002:a17:902:a401:b029:dc:3e1d:234a with SMTP id p1-20020a170902a401b02900dc3e1d234amr18798296plq.48.1612205036799; Mon, 01 Feb 2021 10:43:56 -0800 (PST) Received: from google.com ([2620:15c:211:201:540a:d3ca:9e74:48ac]) by smtp.gmail.com with ESMTPSA id y75sm18543200pfg.119.2021.02.01.10.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 10:43:55 -0800 (PST) Date: Mon, 1 Feb 2021 10:43:52 -0800 From: Minchan Kim To: Georgi Djakov Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_io: Use pr_alert_ratelimited for swap read/write errors Message-ID: References: <20210201142055.29068-1-georgi.djakov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210201142055.29068-1-georgi.djakov@linaro.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 01, 2021 at 04:20:55PM +0200, Georgi Djakov wrote: > If there are errors during swap read or write, they can easily fill > the log buffer and remove any previous messages that might be useful > for debugging, especially on systems that rely for logging only on > the kernel ring-buffer. > > For example, on a systems using zram as swap, we are more likely to > see any page allocation errors preceding the swap write errors if the > alerts are ratelimited. > > Signed-off-by: Georgi Djakov Acked-by: Minchan Kim