From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Miaohe Lin <linmiaohe@huawei.com>,
Christoph Lameter <cl@linux.com>,
penberg@kernel.org, David Rientjes <rientjes@google.com>,
iamjoonsoo.kim@lge.com, Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp
Date: Mon, 1 Feb 2021 18:20:15 +0200 [thread overview]
Message-ID: <YBgqP78VEoE9G8Yf@smile.fi.intel.com> (raw)
In-Reply-To: <YBgpavcZD4VXZri6@smile.fi.intel.com>
On Mon, Feb 01, 2021 at 06:16:42PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 01, 2021 at 09:49:59PM +0800, Yafang Shao wrote:
> > On Mon, Feb 1, 2021 at 9:27 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Mon, Feb 01, 2021 at 07:56:10PM +0800, Yafang Shao wrote:
...
> > The existing one should be more important than the added one.
> > But the order of output will not match with the value for page->flags.
> > E.g.
> > flags=0x17ffffc0010200(slab|head,Node 0,Zone 2,Lastcpupid 0x1fffff)
> > It may be strange to compare the value with the string.
>
> More I'm looking at it, more I'm thinking it should have different specifiers
> for each group of desired flags to be printed.
>
> So, you leave %pGp as is and then add another letter to add more details, so
> user will choose what and in which order they want.
>
> For example, let's assume %pGp == %pGpf and P is a new specifier for what you
> are initially adding here:
>
> %pGpfP => referenced|uptodate|lru|active|private,Node 0,Zone 2
> %pGpPf => Node 0,Zone 2,referenced|uptodate|lru|active|private
>
> and so on.
And I agree with Matthew about format, but it doesn't oppose my suggestion
above.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-01 16:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 11:56 [PATCH v2 0/3] mm, " Yafang Shao
2021-02-01 11:56 ` [PATCH v2 1/3] mm, slub: use pGp to print page flags Yafang Shao
2021-02-01 11:56 ` [PATCH v2 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-02-01 11:56 ` [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-01 13:05 ` Joe Perches
2021-02-01 13:27 ` Yafang Shao
2021-02-01 13:23 ` David Hildenbrand
2021-02-01 13:32 ` David Hildenbrand
2021-02-01 13:34 ` Andy Shevchenko
2021-02-01 13:52 ` Yafang Shao
2021-02-01 16:03 ` Andy Shevchenko
2021-02-01 13:27 ` Andy Shevchenko
2021-02-01 13:49 ` Yafang Shao
2021-02-01 16:16 ` Andy Shevchenko
2021-02-01 16:20 ` Andy Shevchenko [this message]
2021-02-02 13:25 ` Yafang Shao
2021-02-01 14:15 ` Matthew Wilcox
2021-02-01 14:44 ` Yafang Shao
2021-02-01 18:51 ` Joe Perches
2021-02-01 18:59 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBgqP78VEoE9G8Yf@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=laoar.shao@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox