From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F0EEC433DB for ; Wed, 27 Jan 2021 17:02:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A11164DA5 for ; Wed, 27 Jan 2021 17:02:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A11164DA5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 018116B006E; Wed, 27 Jan 2021 12:02:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE36A6B0070; Wed, 27 Jan 2021 12:02:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5CFC6B0071; Wed, 27 Jan 2021 12:02:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id B7F096B006E for ; Wed, 27 Jan 2021 12:02:16 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 39499362B for ; Wed, 27 Jan 2021 17:02:16 +0000 (UTC) X-FDA: 77752173072.16.ray39_5f0c22327598 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id ABD5A100E54AE for ; Wed, 27 Jan 2021 17:01:58 +0000 (UTC) X-HE-Tag: ray39_5f0c22327598 X-Filterd-Recvd-Size: 4796 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 17:01:57 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id u4so1738888pjn.4 for ; Wed, 27 Jan 2021 09:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vtepp4TZmVRvIbUVDYOarm58wBYnXPgnDjuNfeHxdtc=; b=ZgCmQUbVt9Ht+2dI0uE93whJgeLCVOUmzWeIxNqpjxtqOaXNdmeEG9qipZ+10Zc/zb 2ybd+rCe/aNVN1vdCzKEWqFPK2rZqH5xbiiVqcPZBP1LJ64fthGKYk/aY28E8LMyNGa7 O/CdUhpXmnqjZRkAyuyI4GCyYTLffo5wZ/w+kAnBY6xn2Rl6Dfqks4BORPwcft5+30Df ZPTtAqnDJk/jTl4v4qhc0YoKAtnw668EeAmVKTge0o+wlLxy4YKKJNwXgX5TsHCDIAC/ J0hj3JMCo5O7zkYwV2RRbZLdDWtMLcJdF/CmfkkvaWN4VgItvp9rSUFi5nLIwzemZFmM WylA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=vtepp4TZmVRvIbUVDYOarm58wBYnXPgnDjuNfeHxdtc=; b=LG57zHjLbTOzdSBCh/1FxaS7OSzhPgnAMECma3aInatdzQ7API063uFov63e7Er7bW PYdeV6e5Ho3fG0w5mHHmq565VHGLVyTgSoSTpADzmrX9HvVlVFgCCIindFNFu9sjCxJn ELSy2dfnGyLi+munUyAlvjkUAavkwEK6NdhflOuyvXIpmKewdhdEW18vSjsmsI1MkYiP 3kC/7nzvNDL/Y2U6sNoWKcYFmxTkWQiy+JlGThij7JcTK+LClALnivuA6lHwKudceHbO tvtA4bVdfB8TlTTs/hZvJNqhKFYd8iL+ITAO87eZXLImo7LtsL61GueMPbpM5w7sudWE vaLQ== X-Gm-Message-State: AOAM5336udz+uN858DQkASYL9zVYR08PW8V5aZj8wXU2tgi9ckxLpjPz lAHzojmTyROFh0q78XGY484= X-Google-Smtp-Source: ABdhPJzmHhfUFA/75Zv/UDnqfz6FCOjqg2rT0LuDRrn5TaPMOXPDx/ORUyPSivMQuwCqJtUASFgh8g== X-Received: by 2002:a17:902:b206:b029:dc:1f41:962d with SMTP id t6-20020a170902b206b02900dc1f41962dmr12522286plr.28.1611766916993; Wed, 27 Jan 2021 09:01:56 -0800 (PST) Received: from google.com ([2620:15c:211:201:9dd5:b47b:bb84:dede]) by smtp.gmail.com with ESMTPSA id q197sm2937750pfc.155.2021.01.27.09.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 09:01:55 -0800 (PST) Date: Wed, 27 Jan 2021 09:01:52 -0800 From: Minchan Kim To: Matthew Wilcox Cc: Chris Goldsworthy , viro@zeniv.linux.org.uk, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Laura Abbott Subject: Re: [PATCH v4] fs/buffer.c: Revoke LRU when trying to drop buffers Message-ID: References: <20210127025922.GS308988@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127025922.GS308988@casper.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 27, 2021 at 02:59:22AM +0000, Matthew Wilcox wrote: > On Tue, Jan 26, 2021 at 02:59:17PM -0800, Minchan Kim wrote: > > The release buffer_head in LRU is great improvement for migration > > point of view. > > > > A question: > > > > Can't we invalidate(e.g., invalidate_bh_lrus) bh_lru in migrate_prep or > > elsewhere when migration found the failure and is about to retry? > > > > Migration has done such a way for other per-cpu stuffs for a long time, > > which would be more consistent with others and might be faster sometimes > > with reducing IPI calls for page. > > Should lru_add_drain_all() also handle draining the buffer lru for all > callers? A quick survey ... > > invalidate_bdev() already calls invalidate_bh_lrus() > compact_nodes() would probably benefit from the BH LRU being invalidated > POSIX_FADV_DONTNEED would benefit if the underlying filesystem uses BHs > check_and_migrate_cma_pages() would benefit > khugepaged_do_scan() doesn't need it today > scan_get_next_rmap_item() looks like it only works on anon pages (?) so > doesn't need it > mem_cgroup_force_empty() probably needs it > mem_cgroup_move_charge() ditto > memfd_wait_for_pins() doesn't need it > shake_page() might benefit > offline_pages() would benefit > alloc_contig_range() would benefit > > Seems like most would benefit and a few won't care. I think I'd lean > towards having lru_add_drain_all() call invalidate_bh_lrus(), just to > simplify things. Fair enough.