From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D39A1C433E0 for ; Tue, 26 Jan 2021 22:14:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4396320674 for ; Tue, 26 Jan 2021 22:14:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4396320674 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 627388D0118; Tue, 26 Jan 2021 17:14:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D7538D00F8; Tue, 26 Jan 2021 17:14:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C6A28D0118; Tue, 26 Jan 2021 17:14:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 37E4C8D00F8 for ; Tue, 26 Jan 2021 17:14:44 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EB35E8249980 for ; Tue, 26 Jan 2021 22:14:43 +0000 (UTC) X-FDA: 77749331646.02.women91_2c00bd527591 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id D1DEE10097AA2 for ; Tue, 26 Jan 2021 22:14:43 +0000 (UTC) X-HE-Tag: women91_2c00bd527591 X-Filterd-Recvd-Size: 4289 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 22:14:43 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id p72so36934965iod.12 for ; Tue, 26 Jan 2021 14:14:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ekn1N2bwuzZRoWAtKJs99FQ8E0MbiDKLziersW7caRE=; b=IVxDhTJujLfkfoIIHKc5PJhCnxU1zxb6K0BO2zVXx3XO2okWVsdslArZoUQ/Bs3yFl 6RS2cJemdD1ghGFEvfhtopOsBrcSQld/kZQ5U29amm+fUc4KihggM+sNuwH8+bF0neHi mzmTnTV9tUz+N/WtcT5IaAm3S9619FGUvdyQdn7w/8QfYhYAnf9maE/fdwqlDFoYpmjM uvW1vYLZZfzVCQBUXpf34KAVPNjYJNJTDXDgaAhFAdicE3YE8uT9V8Aztn+YPawfHaeP wt8f8ImLqz2aILOjIB/YSeWgvQATSGm/iOKAXoyK69R7JhXmPkjiMlwlghLvMKUYjaWj 6u6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ekn1N2bwuzZRoWAtKJs99FQ8E0MbiDKLziersW7caRE=; b=WpOR/ZsMwY75HPRgjm35A5KT9BIAGefROdHtdr5tNLOQBwVBO58EjChLK9iVTmtLGy SVcfp4VDqgs00ogfmLSr+uP8mffKBKyRXcbVYIv9AruvHJZIYM0+9kL97vFmftJlZPax h5fqQXSf4iLZLSr1I0qSbvQAn0Gd0usb7zl5hDRxNghrv5/mci/cfX88F/WA+BE9B10T dG4fyRX1mJXrxqSQhij8hS2oIHBmIoiD0lshAwhxVOMv+zFerJcagLu1Iy6lsbcK9VsN lJLGX5xyDJDRpsrOp8Se0P5u/x+OibDOwRWpLL7OcdZrSzIX7gphY1dP6JjQVHwG7RII MIBg== X-Gm-Message-State: AOAM532zaTVWSsD+6cnRHLhoDkYaq9Giw+LwvXxXZPTqjzfjv93PkcLy xLdv0k2l/cgmN9GByqQzRjYuag== X-Google-Smtp-Source: ABdhPJx9Qh13rzQgMYKQ04fWd8ka0XyNGIEtj7npA85zTJkIxdNfE0dZentJ6fMXENctTjswu/i+Mw== X-Received: by 2002:a05:6e02:1b8b:: with SMTP id h11mr6409894ili.32.1611699282533; Tue, 26 Jan 2021 14:14:42 -0800 (PST) Received: from google.com ([2620:15c:183:200:697e:4b38:5872:adfe]) by smtp.gmail.com with ESMTPSA id e9sm13859463ilc.73.2021.01.26.14.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 14:14:41 -0800 (PST) Date: Tue, 26 Jan 2021 15:14:38 -0700 From: Yu Zhao To: Matthew Wilcox Cc: Andrew Morton , Hugh Dickins , Alex Shi , Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/10] mm: don't pass "enum lru_list" to lru list addition functions Message-ID: References: <20210122220600.906146-1-yuzhao@google.com> <20210122220600.906146-4-yuzhao@google.com> <20210126220111.GO308988@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126220111.GO308988@casper.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 26, 2021 at 10:01:11PM +0000, Matthew Wilcox wrote: > On Fri, Jan 22, 2021 at 03:05:53PM -0700, Yu Zhao wrote: > > +++ b/mm/swap.c > > @@ -231,7 +231,7 @@ static void pagevec_move_tail_fn(struct page *page, struct lruvec *lruvec) > > if (!PageUnevictable(page)) { > > del_page_from_lru_list(page, lruvec, page_lru(page)); > > ClearPageActive(page); > > - add_page_to_lru_list_tail(page, lruvec, page_lru(page)); > > + add_page_to_lru_list_tail(page, lruvec); > > __count_vm_events(PGROTATED, thp_nr_pages(page)); > > } > > Is it profitable to do ... > > - del_page_from_lru_list(page, lruvec, page_lru(page)); > + enum lru_list lru = page_lru(page); > + del_page_from_lru_list(page, lruvec, lru); > ClearPageActive(page); > - add_page_to_lru_list_tail(page, lruvec, page_lru(page)); > + lru &= ~LRU_ACTIVE; > + add_page_to_lru_list_tail(page, lruvec, lru); Ok, now we want to trade readability for size. Sure, I'll see how much we could squeeze.