From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C196FC433E0 for ; Tue, 26 Jan 2021 19:27:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B8D322A84 for ; Tue, 26 Jan 2021 19:27:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B8D322A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B184E8D0111; Tue, 26 Jan 2021 14:27:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACA418D00F8; Tue, 26 Jan 2021 14:27:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B7A48D0111; Tue, 26 Jan 2021 14:27:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 8300C8D00F8 for ; Tue, 26 Jan 2021 14:27:42 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4A1C7180AD838 for ; Tue, 26 Jan 2021 19:27:42 +0000 (UTC) X-FDA: 77748910764.26.love69_23132b427590 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 2797F1804B640 for ; Tue, 26 Jan 2021 19:27:42 +0000 (UTC) X-HE-Tag: love69_23132b427590 X-Filterd-Recvd-Size: 4084 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 19:27:40 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id gx1so2847555pjb.1 for ; Tue, 26 Jan 2021 11:27:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yle40tWleCzEixF2mwBGtJ3uB7QHbvhm1AXLk8kwIl8=; b=ZlkSubWPggrXH8a/wycob6mIua6+s0/ZdLTa5t2I6px+/S/tLG/+v+PoRWMqckd3Ni BJPh3o/DGMgDVUOglR6ENIVaJNdQqM/oKdsLbLHeXoYepAEFk5B8rcmSfC1hnzOUUrYq VZ9Y1ym2Eh0F6YGyspyf/MN3K5cy+uFnmjrrLGVtji/T8W4ly5ZjxCKfgAg14sOQl0L0 uitV75YtyLO9mIJlv+RkIeftrpjh0vOQSBo4JQdKFGVUGSxee0vAnYHEz0aji5wTN7u4 LREA6AJs9iDrayFk5sObqrTAYVNLBwJfb1lZLEEIuR/B9/4tOCzqc4uk9dFaGg1XYaSM McmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=yle40tWleCzEixF2mwBGtJ3uB7QHbvhm1AXLk8kwIl8=; b=LijQabn1u47hB4Ff21WXKFzvinwvQalcYCafTKLftUonEAsEr4QYTnBLlIOYJodUlI yafahjiN41KGvjLYw0EZIXgMXf8Cj626jM5UsdCWf1Qlpms8Sq54+atPQ4MIc9q4+Lje G0iFo9U/eEiO9AFWNaKLO5DdEb6TJ65+v/rCnLLZjINoKKQiIt0u1SFIiT3ir40LM0ic 1Dm6ioQjylZQWkGioAlv/EGNFOhHRBIfTQjvuAzHe5TwRakHlQTCGAMHOmYAHTsY1uKX 6yYcS8Wpjnto/5YjGrmTklVZ0v+cbXsupDPf5UfLzJOnMb39IS9aGryhhiZRqjQEHdb8 tqdQ== X-Gm-Message-State: AOAM533N6SMDV+Tpb4r0l9hyWBVXqPgxrzHkfSWNciIS61ukDObJap1r pMCmT2OWyVhGt7vIsijaq0k= X-Google-Smtp-Source: ABdhPJy5XocxQ8cgnEM5TwBXCFWhCBkaorP2EB5WKTN9SCc+sxCX2AoMx3hY+M6rFYi7ZiCnMRZYdg== X-Received: by 2002:a17:90a:5793:: with SMTP id g19mr1418129pji.32.1611689259525; Tue, 26 Jan 2021 11:27:39 -0800 (PST) Received: from google.com ([2620:15c:211:201:9dd5:b47b:bb84:dede]) by smtp.gmail.com with ESMTPSA id w184sm20605882pgb.71.2021.01.26.11.27.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 11:27:38 -0800 (PST) Date: Tue, 26 Jan 2021 11:27:35 -0800 From: Minchan Kim To: Christoph Hellwig Cc: Andrew Morton , linux-mm , LKML , hyesoo.yu@samsung.com, david@redhat.com, mhocko@suse.com, surenb@google.com, pullip.cho@samsung.com, joaodias@google.com, hridya@google.com, john.stultz@linaro.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps Message-ID: References: <20210121175502.274391-1-minchan@kernel.org> <20210121175502.274391-5-minchan@kernel.org> <20210126070744.GA1244507@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126070744.GA1244507@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 26, 2021 at 07:07:44AM +0000, Christoph Hellwig wrote: > > +config DMABUF_HEAPS_CHUNK > > + bool "DMA-BUF CHUNK Heap" > > + depends on DMABUF_HEAPS && DMA_CMA > > + help > > + Choose this option to enable dma-buf CHUNK heap. This heap is backed > > + by the Contiguous Memory Allocator (CMA) and allocates the buffers that > > + are arranged into a list of fixed size chunks taken from CMA. > > Overly long line, which in text flowing text is really, really annoying. > > Many more later. Remember that > 80 chars are only allowed if they > significantly improve readability. Let me make it shorter than 80 chars in next revision. Thanks for the reivew, Christoph.