From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C4CC433E0 for ; Fri, 5 Feb 2021 21:32:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 77CB464FB2 for ; Fri, 5 Feb 2021 21:32:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77CB464FB2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E255F6B0006; Fri, 5 Feb 2021 16:32:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD5DF6B006C; Fri, 5 Feb 2021 16:32:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC5076B006E; Fri, 5 Feb 2021 16:32:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id B3FA96B0006 for ; Fri, 5 Feb 2021 16:32:43 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7D0ED3634 for ; Fri, 5 Feb 2021 21:32:43 +0000 (UTC) X-FDA: 77785513806.16.vest36_4c0a11c275e8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 5E042100E690C for ; Fri, 5 Feb 2021 21:32:43 +0000 (UTC) X-HE-Tag: vest36_4c0a11c275e8 X-Filterd-Recvd-Size: 5243 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Fri, 5 Feb 2021 21:32:42 +0000 (UTC) Received: from mail-oo1-f70.google.com ([209.85.161.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l88iX-0002UZ-BQ for linux-mm@kvack.org; Fri, 05 Feb 2021 21:32:41 +0000 Received: by mail-oo1-f70.google.com with SMTP id r10so4312339ooh.3 for ; Fri, 05 Feb 2021 13:32:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CEv7KXRFEUe4RabAT7u4Z8pYuWuDZpwIcUXyT5w5004=; b=D8+AafyzpTV0b8ZODF2VN9UOkQa6Rn4dTNldjDu1xdWiH+4CvD70YTji5X1z5oK+u6 HLNnk2TirdIlQYpjFA+r/79gJ1GTzYGCuUWVI2yPzKLbv9PgmHZ3TPsQ3Aghlddmqy3p IX2b/jOGGHLR5P4pMEJui96pKEqexBq/MZZO6n+JGNX3ABO+WWSMcrOUMNokJxJG5fSG qDyv3vFbZL0jSJErC2whetWreCyzdmQq7I81gHLefhu9ri0dcYXChNBxxlNiPoZwd+TY sFi1lMoPRdK+L+nEsnp3KgP/HRbK0zkoAQn9LZHyqY00hG7WvOJdBYXfwxEBls5omyIy WXfA== X-Gm-Message-State: AOAM532iP0UTUSJT44TY5xsyjB+CQY59zsBonU/s0NeKipcWe8Ma2cgj alutoeWGtfmXomF2gRJDaJjlwgPuo9AYcaVlBk67isxkoxVCYxVZrSdE0nk29wsVjXjSpNYdq94 U1tG/CgSg6iSfyukSEIvIGc4TZrQu X-Received: by 2002:a9d:640e:: with SMTP id h14mr4936429otl.198.1612560760284; Fri, 05 Feb 2021 13:32:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwHmyw8xcHOH58QlRlJy8oBPLSHbIgkypwOLDZRy4/OKOBQPzyOfGREhmnboaGpyxGE+SGHRg== X-Received: by 2002:a9d:640e:: with SMTP id h14mr4936420otl.198.1612560760071; Fri, 05 Feb 2021 13:32:40 -0800 (PST) Received: from localhost ([2605:a601:ac0f:820:2b7:eb67:ff8d:8b15]) by smtp.gmail.com with ESMTPSA id l133sm1997908oia.37.2021.02.05.13.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 13:32:39 -0800 (PST) Date: Fri, 5 Feb 2021 15:32:38 -0600 From: Seth Forshee To: Andrew Morton Cc: Hugh Dickins , Chris Down , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tmpfs: Don't use 64-bit inodes by defulat with 32-bit ino_t Message-ID: References: <20210205202159.505612-1-seth.forshee@canonical.com> <20210205124157.c9d855a373362d7bf3d811a7@linux-foundation.org> <20210205132313.95ce9fd932ca96667fd5db83@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210205132313.95ce9fd932ca96667fd5db83@linux-foundation.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 05, 2021 at 01:23:13PM -0800, Andrew Morton wrote: > On Fri, 5 Feb 2021 14:55:43 -0600 Seth Forshee wrote: > > > On Fri, Feb 05, 2021 at 12:41:57PM -0800, Andrew Morton wrote: > > > On Fri, 5 Feb 2021 14:21:59 -0600 Seth Forshee wrote: > > > > > > > Currently there seems to be an assumption in tmpfs that 64-bit > > > > architectures also have a 64-bit ino_t. This is not true; s390 at > > > > least has a 32-bit ino_t. With CONFIG_TMPFS_INODE64=y tmpfs > > > > mounts will get 64-bit inode numbers and display "inode64" in the > > > > mount options, but passing the "inode64" mount option will fail. > > > > This leads to the following behavior: > > > > > > > > # mkdir mnt > > > > # mount -t tmpfs nodev mnt > > > > # mount -o remount,rw mnt > > > > mount: /home/ubuntu/mnt: mount point not mounted or bad option. > > > > > > > > As mount sees "inode64" in the mount options and thus passes it > > > > in the options for the remount. > > > > > > > > Ideally CONFIG_TMPFS_INODE64 would depend on sizeof(ino_t) < 8, > > > > but I don't think it's possible to test for this (potentially > > > > CONFIG_ARCH_HAS_64BIT_INO_T or similar could be added, but I'm > > > > not sure whether or not that is wanted). So fix this by simply > > > > refusing to honor the CONFIG_TMPFS_INODE64 setting when > > > > sizeof(ino_t) < 8. > > > > > > How about changing s390 Kconfig so that CONFIG_TMPFS_INODE64 is not enabled? > > > > I did do that for our config. I see the s390 defconfig has it enabled, > > so I will send a patch for that too. But the fact that it can be > > configured that way and that the code behaves badly still seems > > problematic. > > I meant > > --- a/fs/Kconfig~a > +++ a/fs/Kconfig > @@ -203,7 +203,7 @@ config TMPFS_XATTR > > config TMPFS_INODE64 > bool "Use 64-bit ino_t by default in tmpfs" > - depends on TMPFS && 64BIT > + depends on TMPFS && 64BIT && !S390 > default n > help > tmpfs has historically used only inode numbers as wide as an unsigned > _ Ah. s390 does appear to be the only architecture that doesn't use unsigned long for ino_t, so that seems good to me. I can send a patch if you want, but seems like you've already got one ... Seth