From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5951AC433DB for ; Fri, 5 Feb 2021 08:36:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D53E564FBE for ; Fri, 5 Feb 2021 08:36:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D53E564FBE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 37D836B006E; Fri, 5 Feb 2021 03:36:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 309406B0070; Fri, 5 Feb 2021 03:36:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F6EC6B0071; Fri, 5 Feb 2021 03:36:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 069C26B006E for ; Fri, 5 Feb 2021 03:36:47 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CC8633635 for ; Fri, 5 Feb 2021 08:36:46 +0000 (UTC) X-FDA: 77783558412.07.blood47_2f0f997275e3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id B162A1803F9A4 for ; Fri, 5 Feb 2021 08:36:46 +0000 (UTC) X-HE-Tag: blood47_2f0f997275e3 X-Filterd-Recvd-Size: 3248 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Fri, 5 Feb 2021 08:36:46 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1612514205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TPEtPSJTJFr+uqHAFw8+/pwPBdso+nWGktyWxW/+4Bk=; b=RyIyP8hptBgLl6GItYcCzNcgE23w04gkI+vhzyGupcf+vAkfOBL3NGDJoMkbwLULc7ZOIn KgXw1u/bFSbp2L2QMKEeMyfURJzyEQieaBdVVcZe5DvlRVdsYV0BXNd/oZSCCN5ElKdFKQ SsPnoVS4Z5uDTEN2uywLQ/P8ZTj2OaA= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1D250ACBA; Fri, 5 Feb 2021 08:36:45 +0000 (UTC) Date: Fri, 5 Feb 2021 09:36:44 +0100 From: Michal Hocko To: Muchun Song Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: remove rcu_read_lock from get_mem_cgroup_from_page Message-ID: References: <20210205062719.74431-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210205062719.74431-1-songmuchun@bytedance.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 05-02-21 14:27:19, Muchun Song wrote: > The get_mem_cgroup_from_page() is called under page lock, so the page > memcg cannot be changed under us. Where is the page lock enforced? > Also, css_get is enough because page > has a reference to the memcg. tryget used to be there to guard against offlined memcg but we have concluded this is impossible in this path. tryget stayed there to catch some unexpected cases IIRC. > If we really want to make the get_mem_cgroup_from_page() suitable for > arbitrary page, we should use page_memcg_rcu() instead of page_memcg() > and call it after rcu_read_lock(). What is the primary motivation to change this code? is the overhead of tryget/RCU something that needs optimizing? > Signed-off-by: Muchun Song > --- > mm/memcontrol.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 87f01bc05d1f..6c7f1ea3955e 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1063,16 +1063,15 @@ EXPORT_SYMBOL(get_mem_cgroup_from_mm); > */ > struct mem_cgroup *get_mem_cgroup_from_page(struct page *page) > { > - struct mem_cgroup *memcg = page_memcg(page); > + struct mem_cgroup *memcg; > > if (mem_cgroup_disabled()) > return NULL; > > - rcu_read_lock(); > /* Page should not get uncharged and freed memcg under us. */ > - if (!memcg || WARN_ON_ONCE(!css_tryget(&memcg->css))) > - memcg = root_mem_cgroup; > - rcu_read_unlock(); > + memcg = page_memcg(page) ? : root_mem_cgroup; > + css_get(&memcg->css); > + > return memcg; > } > EXPORT_SYMBOL(get_mem_cgroup_from_page); > -- > 2.11.0 -- Michal Hocko SUSE Labs