From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,BIGNUM_EMAILS, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8795FC433DB for ; Fri, 22 Jan 2021 11:11:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ECDE62246B for ; Fri, 22 Jan 2021 11:11:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECDE62246B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3CE976B000A; Fri, 22 Jan 2021 06:11:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37D326B000C; Fri, 22 Jan 2021 06:11:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26DB16B000D; Fri, 22 Jan 2021 06:11:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id 132936B000A for ; Fri, 22 Jan 2021 06:11:54 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CED09181AF5EA for ; Fri, 22 Jan 2021 11:11:53 +0000 (UTC) X-FDA: 77733146106.28.walk13_5305a822756b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id AD87B6D6E for ; Fri, 22 Jan 2021 11:11:53 +0000 (UTC) X-HE-Tag: walk13_5305a822756b X-Filterd-Recvd-Size: 4789 Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 Jan 2021 11:11:52 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10MB4uaV084083; Fri, 22 Jan 2021 11:11:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=qulSlAoeOq3Wt4yM/gnYZC1A/VjkVrXYePHqx9f1dYc=; b=P0csxUXKHtmi+6J6agFyF8eGsLjXcnh6KfJWpa+bvvka6sXq/KPRtR9B8Dc2JvBISg2t 85uQPKA66b3doXtnQp7t6uwF06nl9jf7dvRyD919GGEqBDd/9qbpCaoqB9np6FpNg7tp zuW4Za7o2ZhHqtlaoC6jmZTV/sTtNSonreApispJ8vihMyMrLlr4WfEQHW8KMtmZI+jM oijfkDmvnl+rsynKepEkKZvWhvtLSx79QhPLF22isvja+6Z8NM2a7vBHSddPf9W3SrfL s76BLSR4np4VDmZfqXMWcSnd/EPV2SFYwjLc0CM9mIJRs1SZOed4+pbw/oZikeEYWPYg 5w== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 3668qrkkpm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 Jan 2021 11:11:43 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10MB4uOL195119; Fri, 22 Jan 2021 11:11:41 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 3668r0tgyx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 Jan 2021 11:11:41 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 10MBBev6000679; Fri, 22 Jan 2021 11:11:40 GMT Received: from mwanda (/10.175.203.97) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 22 Jan 2021 03:11:40 -0800 Date: Fri, 22 Jan 2021 14:11:43 +0300 From: Dan Carpenter To: tiantao6@hisilicon.com Cc: linux-mm@kvack.org Subject: [bug report] mm/zswap: add the flag can_sleep_mapped Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9871 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 adultscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101220061 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9871 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101220061 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Tian Tao, The patch 6753c561f653: "mm/zswap: add the flag can_sleep_mapped" from Jan 20, 2021, leads to the following static checker warning: mm/zswap.c:1322 zswap_frontswap_load() error: uninitialized symbol 'ret'. mm/zswap.c 1250 static int zswap_frontswap_load(unsigned type, pgoff_t offset, 1251 struct page *page) 1252 { 1253 struct zswap_tree *tree = zswap_trees[type]; 1254 struct zswap_entry *entry; 1255 struct scatterlist input, output; 1256 struct crypto_acomp_ctx *acomp_ctx; 1257 u8 *src, *dst, *tmp; 1258 unsigned int dlen; 1259 int ret; 1260 1261 /* find */ 1262 spin_lock(&tree->lock); 1263 entry = zswap_entry_find_get(&tree->rbroot, offset); 1264 if (!entry) { 1265 /* entry was written back */ 1266 spin_unlock(&tree->lock); 1267 return -1; 1268 } 1269 spin_unlock(&tree->lock); 1270 1271 if (!entry->length) { 1272 dst = kmap_atomic(page); 1273 zswap_fill_page(dst, entry->value); 1274 kunmap_atomic(dst); ret = 0; on this path? 1275 goto freeentry; 1276 } 1277 1278 if (!zpool_can_sleep_mapped(entry->pool->zpool)) { 1279 1280 tmp = kmalloc(entry->length, GFP_ATOMIC); 1281 if (!tmp) { 1282 ret = -ENOMEM; 1283 goto freeentry; 1284 } 1285 } 1286 regards, dan carpenter