From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56046C433E0 for ; Thu, 21 Jan 2021 20:42:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACF0A2389F for ; Thu, 21 Jan 2021 20:42:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACF0A2389F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B5986B0006; Thu, 21 Jan 2021 15:42:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3654A6B0007; Thu, 21 Jan 2021 15:42:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22D126B0008; Thu, 21 Jan 2021 15:42:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id 0CCD76B0006 for ; Thu, 21 Jan 2021 15:42:36 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C7A708249980 for ; Thu, 21 Jan 2021 20:42:35 +0000 (UTC) X-FDA: 77730955470.11.tin06_5111c6327566 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id AA5E5180F8B81 for ; Thu, 21 Jan 2021 20:42:35 +0000 (UTC) X-HE-Tag: tin06_5111c6327566 X-Filterd-Recvd-Size: 3559 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Jan 2021 20:42:34 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id z11so3073908qkj.7 for ; Thu, 21 Jan 2021 12:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/cN+TIyFlXTYzj8exXBqwp7S9shR8K+JZFzTefh5owU=; b=tCnozVcakStoR6Ant0DnFGkC2zcvbtAQ+2Wx5n2GAa4iQsm/U/7xWnm/XNw80wd0oV m3BHXk/kskullDm/TF1t9Km9gNBOyz4pWGkiIwNPSzh2VpWKJBeDzuGTvbBM5kU7bf4d SzZukFdyF5QQim7GxlqmNWl4o4DIwD2fJ4d+4PL7M9C6Qqcqt7NVAZXwyx6yDUMWfJFw M1kWz250Rxt9/5/u0KnJlB6FWCSxvgZz3fLnm9oJElp6C9xu/77/a88LO2JJbX7r8dvd Gw0eIfKRp9to3eg1VWdHdPYUIQxaG9oq5EsGqNADGB4iKZmpE/UC9mQUCAQD+SRxcOOp L+Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/cN+TIyFlXTYzj8exXBqwp7S9shR8K+JZFzTefh5owU=; b=BPaiaxeI1s/41JdvqQdibIH+q+QaUUy/JS+nsuEttI0WEtsYPG0DlmtGKlUFdA0JvV r1gxgwM0SVITHSoaKvKT4hS/9BVEjgVxB1N6ovHf/+zdeGP2N2G7jNeM8o2/Vyjm7bPG q2PYaj4nPiHUmOomM3Thx3KlFFNdfpV9PQmj4zLbGp86qc+HLwXYe4foIfuTfl8HdUiK BlD0/EEHPATHTYSXsjQgwWE44kuEt41SlabuV8b3SbiAIHtlB8jYBNxoVlfFEYbKSWss uwo1r5kvzAvwoHiXoc9YrhilM7FaJF4UgHbvPDSFdca/Bu3PJjYoRvSYJiG6ApXbWCj8 kfhQ== X-Gm-Message-State: AOAM5317AomrvSRqIsiG5gGvh/hbFSfH44K+Iutu8HR6/FfGRIhu7mUe +YBA3hmDPEV96+WqBWvcn0x7OA== X-Google-Smtp-Source: ABdhPJyPI7EORYAgVycLlQegnFv2rd20pMb2lVvSFF30VqlvxDOeWo1+I8FlJvkL88KcDDYEjDVixw== X-Received: by 2002:a37:7a46:: with SMTP id v67mr1709338qkc.16.1611261754179; Thu, 21 Jan 2021 12:42:34 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:b808]) by smtp.gmail.com with ESMTPSA id c62sm4392313qkf.34.2021.01.21.12.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 12:42:33 -0800 (PST) Date: Thu, 21 Jan 2021 15:42:31 -0500 From: Johannes Weiner To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, Vishal Verma Subject: Re: [PATCH v2 1/4] mm: Introduce and use mapping_empty Message-ID: References: <20201026151849.24232-1-willy@infradead.org> <20201026151849.24232-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201026151849.24232-2-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 26, 2020 at 03:18:46PM +0000, Matthew Wilcox (Oracle) wrote: > Instead of checking the two counters (nrpages and nrexceptional), we > can just check whether i_pages is empty. > > Signed-off-by: Matthew Wilcox (Oracle) > Tested-by: Vishal Verma Acked-by: Johannes Weiner Heh, I was looking for the fs/inode.c hunk here, because I remember those BUG_ONs in the inode free path. Found it in the last patch - I guess they escaped grep but the compiler let you know? :-)