From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABB71C433E0 for ; Wed, 20 Jan 2021 10:44:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFF0923332 for ; Wed, 20 Jan 2021 10:44:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFF0923332 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D2396B0008; Wed, 20 Jan 2021 05:44:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4822D6B000A; Wed, 20 Jan 2021 05:44:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 398EA6B000C; Wed, 20 Jan 2021 05:44:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 220686B0008 for ; Wed, 20 Jan 2021 05:44:03 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DB4141EE6 for ; Wed, 20 Jan 2021 10:44:02 +0000 (UTC) X-FDA: 77725818324.18.tail53_5e019df27559 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id BB6C3100ED3CD for ; Wed, 20 Jan 2021 10:44:02 +0000 (UTC) X-HE-Tag: tail53_5e019df27559 X-Filterd-Recvd-Size: 5030 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 Jan 2021 10:44:01 +0000 (UTC) X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 42AAD1BF20B; Wed, 20 Jan 2021 10:43:58 +0000 (UTC) Date: Wed, 20 Jan 2021 11:43:57 +0100 From: Paul Kocialkowski To: Dan Carpenter Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Mauro Carvalho Chehab , linux-media@vger.kernel.org, =?utf-8?B?S8OpdmluIEwnaMO0cGl0YWw=?= , Sakari Ailus Subject: Re: [linux-next:master 2460/4407] drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR_ERR' Message-ID: References: <20210119185750.GO2696@kadam> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PD8IyB+9PRBc5eQP" Content-Disposition: inline In-Reply-To: <20210119185750.GO2696@kadam> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --PD8IyB+9PRBc5eQP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue 19 Jan 21, 21:57, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: b4bb878f3eb3e604ebfe83bbc17eb7af8d99cbf4 > commit: 11c0d8fdccc56fa15cb15906480b4737c31dd085 [2460/4407] media: i2c: = Add support for the OV8865 image sensor > config: i386-randconfig-m021-20210119 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 >=20 > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter >=20 > smatch warnings: > drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR= _ERR' Thanks, this was already reported and the fix is on its way :) Cheers, Paul > vim +/PTR_ERR +2852 drivers/media/i2c/ov8865.c >=20 > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2840 /* DOVDD: digital I= /O */ > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2841 sensor->dovdd =3D d= evm_regulator_get(dev, "dovdd"); > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2842 if (IS_ERR(sensor->= dvdd)) { > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2843 dev_err(dev, "cann= ot get DOVDD (digital I/O) regulator\n"); > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2844 ret =3D PTR_ERR(se= nsor->dvdd); > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2845 goto error_endpoin= t; > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2846 } > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2847 =20 > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2848 /* AVDD: analog */ > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2849 sensor->avdd =3D de= vm_regulator_get(dev, "avdd"); > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2850 if (IS_ERR(sensor->= avdd)) { > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2851 dev_err(dev, "cann= ot get AVDD (analog) regulator\n"); > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 @2852 ret =3D PTR_ERR(se= nsor->dvdd); >=20 > typo. s/dvdd/avdd/. >=20 > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2853 goto error_endpoin= t; > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2854 } > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2855 =20 > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2856 /* External Clock */ > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2857 =20 > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2858 sensor->extclk =3D = devm_clk_get(dev, NULL); > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2859 if (IS_ERR(sensor->= extclk)) { > 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2860 dev_err(dev, "fail= ed to get external clock\n"); >=20 > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --PD8IyB+9PRBc5eQP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmAICW0ACgkQ3cLmz3+f v9Hu9gf/RZlVOQmcD2HkqYJhoGw4NpthsWhb3oAOHS5f9m2bM6hv+TlNcwPR2rCF KrG1vvMpPfI9bdCDTS1/v64/A5RLxkZVc+plDdk7LTElWGnNOtTUTbNBcHRzVMFC h1BqxKAWFZWXsPnrugngRcc5H3dxXplnAB7fzXyOCnOm+d1nb4njcCA/x8ucvMMa ciq007w9zB7GbfTVezfnyauQ095oTLDibgpSxu3bOu66mTxDAlZFSVL06MUMF0jf KPPvmLck5scJ3jPdckoerpn0ZL28iDKWACRBAN/HnH9ZSzkvYHWegyj6arqVYlPe Dzfb8heSJrWgya4Prcf7ublMOOpqBg== =qoPW -----END PGP SIGNATURE----- --PD8IyB+9PRBc5eQP--